From patchwork Tue Jul 12 17:28:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuah Khan X-Patchwork-Id: 9225807 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D529B60868 for ; Tue, 12 Jul 2016 17:30:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C622127C39 for ; Tue, 12 Jul 2016 17:30:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B727327E78; Tue, 12 Jul 2016 17:30:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EEF7D27CCB for ; Tue, 12 Jul 2016 17:30:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bN1UQ-0001Np-8H; Tue, 12 Jul 2016 17:28:58 +0000 Received: from resqmta-po-10v.sys.comcast.net ([2001:558:fe16:19:96:114:154:169]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bN1UM-00017C-Kn for linux-arm-kernel@lists.infradead.org; Tue, 12 Jul 2016 17:28:55 +0000 Received: from resomta-po-19v.sys.comcast.net ([96.114.154.243]) by resqmta-po-10v.sys.comcast.net with SMTP id N1U0baovdbI5JN1U0bQ9iG; Tue, 12 Jul 2016 17:28:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1468344512; bh=bvr+5CIL6hfFxj33xlT1gRJ/avhmgeFQ5T/Ls8f5wOA=; h=Received:Received:Received:From:To:Subject:Date:Message-Id; b=tNZ0VT5MmFy7QOpwkrlQSAcvmSr/+J23mqKXSuhLmLqz6Mc3PZdHytarE5T0zbcD3 dN4evguYi+OYTNSIXsw+FvXpe4Np+xt6EI01jbyAfkAOUp6PC0PyGgJfX+br5qLwb5 BAbtvpeqUkLC9hjownRB+KGuaBKh7FwxLSTr54eG7UO0eB3yBogZmzmgpv19GDE0E1 pYOxjvelyDoMPNyYws/6wmrWVTMcBwXXYWWPeHcYs4LMsKnED5TIdJgWnWYaMRPMi5 ssBKe5TjbtSgg7IzqAxrsSEu7enj+gaw+0fPVRupLyoFMenIxc28WPhUWQ6OprV1+o YM5ERUsIirWgg== Received: from mail.gonehiking.org ([73.181.52.62]) by comcast with SMTP id N1Tzbsh19IePNN1Tzbpi2C; Tue, 12 Jul 2016 17:28:32 +0000 Received: from shuah-XPS-13-9350.sisa.samsung.com (shuah-xps.internal [192.168.1.87]) by mail.gonehiking.org (Postfix) with ESMTP id 3D5DA9F35B; Tue, 12 Jul 2016 11:28:31 -0600 (MDT) From: Shuah Khan To: kyungmin.park@samsung.com, k.debski@samsung.com, jtp.park@samsung.com, mchehab@kernel.org, javier@osg.samsung.com Subject: [PATCH v2] media: s5p-mfc Fix misspelled error message and checkpatch errors Date: Tue, 12 Jul 2016 11:28:30 -0600 Message-Id: <1468344510-32411-1-git-send-email-shuahkh@osg.samsung.com> X-Mailer: git-send-email 2.7.4 X-CMAE-Envelope: MS4wfHn9ZkoDyUJVKgi7qbLElseyeEoYWZdDXU8EJcRUIXqkB+d4iAsmV+IEt0dBK3vjbMrmrnIHcFo65bsWcPXBgGVmYSjjyxo7uscqyab5/9bPpk9fOC7U KUMlEmWJZGbhNchZ8Ryd7+O5t0yD7eRytjVzIe3Y9UleNwtVdqyRHJx9zofOH//2XPi+Uv01uAJh+JBXPxB6OqB6xNzKhT+0K69yGs1qRW03kQ9oQoQWupta hf2l4ZKBG/V3QujvRoT1YK9z+qSSGqyQkZsmzuN4Lo9sDjUWEeNAYELfhTC0XH9ourgaYiqCo15YqP/e6O8brDBOpmP2Yx0OL/t9E/4KtXx0xmj42vJ5h0OZ 1jIvHXSHxgLDVsBBOEAQt0Wk7i+ssuvXVaAAWIJe30GlLQbEOXD5iKyqOED7lH4ulX1G8EuWAK1FPS0V4tKlqRpsWozEU7z/VtOILsEemdATRPxZHwbq9wfC e4PSHFhQn2nmQbd3N1ftCdpOjXgd/mJOCD0aX2zEPscXMMnHK6FqTMq+o0s= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160712_102854_769503_83E73266 X-CRM114-Status: UNSURE ( 7.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: joe@perches.com, linux-kernel@vger.kernel.org, Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Fix misspelled error message and existing checkpatch errors in the error message conditional. WARNING: suspect code indent for conditional statements (8, 24) if (ctx->state != MFCINST_HEAD_PARSED && [...] mfc_err("Can not get crop information\n"); Signed-off-by: Shuah Khan Reviewed-by: Javier Martinez Canillas --- Changes since v1: - Addressed review comments from Joe Perches - Added reviewed by tag from Javier Martinez Canillas drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c index a01a373..0a9e8d1 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c @@ -775,11 +775,12 @@ static int vidioc_g_crop(struct file *file, void *priv, u32 left, right, top, bottom; if (ctx->state != MFCINST_HEAD_PARSED && - ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING - && ctx->state != MFCINST_FINISHED) { - mfc_err("Cannont set crop\n"); - return -EINVAL; - } + ctx->state != MFCINST_RUNNING && + ctx->state != MFCINST_FINISHING && + ctx->state != MFCINST_FINISHED) { + mfc_err("Can not get crop information\n"); + return -EINVAL; + } if (ctx->src_fmt->fourcc == V4L2_PIX_FMT_H264) { left = s5p_mfc_hw_call(dev->mfc_ops, get_crop_info_h, ctx); right = left >> S5P_FIMV_SHARED_CROP_RIGHT_SHIFT;