diff mbox

[v2,3/6] binding-doc: usb: usb-device: add optional properties for power sequence

Message ID 1468375610-18625-4-git-send-email-peter.chen@nxp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Peter Chen July 13, 2016, 2:06 a.m. UTC
Add optional properties for power sequence.

Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
 Documentation/devicetree/bindings/usb/usb-device.txt | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Rob Herring (Arm) July 16, 2016, 10:31 p.m. UTC | #1
On Wed, Jul 13, 2016 at 10:06:47AM +0800, Peter Chen wrote:
> Add optional properties for power sequence.
> 
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
>  Documentation/devicetree/bindings/usb/usb-device.txt | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-device.txt b/Documentation/devicetree/bindings/usb/usb-device.txt
> index 1c35e7b..0ccaadf 100644
> --- a/Documentation/devicetree/bindings/usb/usb-device.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-device.txt
> @@ -13,6 +13,10 @@ Required properties:
>  - reg: the port number which this device is connecting to, the range
>    is 1-31.
>  
> +Optional properties:
> +power sequence properties, see
> +Documentation/devicetree/bindings/power/pwrseq/pwrseq-generic.txt for detail
> +
>  Example:
>  
>  &usb1 {
> @@ -24,5 +28,10 @@ Example:
>  	hub: genesys@1 {
>  		compatible = "usb5e3,608";
>  		reg = <1>;
> +
> +		power-sequence;
> +		clocks = <&clks IMX6SX_CLK_CKO>;
> +		reset-gpios = <&gpio4 5 GPIO_ACTIVE_LOW>; /* hub reset pin */
> +		reset-duration-us = <10>;

These belong in the binding doc for the hub.

>  	};
>  }
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Peter Chen July 18, 2016, 2:55 a.m. UTC | #2
On Sat, Jul 16, 2016 at 05:31:59PM -0500, Rob Herring wrote:
> On Wed, Jul 13, 2016 at 10:06:47AM +0800, Peter Chen wrote:
> > Add optional properties for power sequence.
> > 
> > Signed-off-by: Peter Chen <peter.chen@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/usb/usb-device.txt | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/usb-device.txt b/Documentation/devicetree/bindings/usb/usb-device.txt
> > index 1c35e7b..0ccaadf 100644
> > --- a/Documentation/devicetree/bindings/usb/usb-device.txt
> > +++ b/Documentation/devicetree/bindings/usb/usb-device.txt
> > @@ -13,6 +13,10 @@ Required properties:
> >  - reg: the port number which this device is connecting to, the range
> >    is 1-31.
> >  
> > +Optional properties:
> > +power sequence properties, see
> > +Documentation/devicetree/bindings/power/pwrseq/pwrseq-generic.txt for detail
> > +
> >  Example:
> >  
> >  &usb1 {
> > @@ -24,5 +28,10 @@ Example:
> >  	hub: genesys@1 {
> >  		compatible = "usb5e3,608";
> >  		reg = <1>;
> > +
> > +		power-sequence;
> > +		clocks = <&clks IMX6SX_CLK_CKO>;
> > +		reset-gpios = <&gpio4 5 GPIO_ACTIVE_LOW>; /* hub reset pin */
> > +		reset-duration-us = <10>;
> 
> These belong in the binding doc for the hub.
> 

There is no dedicated binding doc for USB hub, we only have this binding
doc for hard-wired USB devices.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/usb/usb-device.txt b/Documentation/devicetree/bindings/usb/usb-device.txt
index 1c35e7b..0ccaadf 100644
--- a/Documentation/devicetree/bindings/usb/usb-device.txt
+++ b/Documentation/devicetree/bindings/usb/usb-device.txt
@@ -13,6 +13,10 @@  Required properties:
 - reg: the port number which this device is connecting to, the range
   is 1-31.
 
+Optional properties:
+power sequence properties, see
+Documentation/devicetree/bindings/power/pwrseq/pwrseq-generic.txt for detail
+
 Example:
 
 &usb1 {
@@ -24,5 +28,10 @@  Example:
 	hub: genesys@1 {
 		compatible = "usb5e3,608";
 		reg = <1>;
+
+		power-sequence;
+		clocks = <&clks IMX6SX_CLK_CKO>;
+		reset-gpios = <&gpio4 5 GPIO_ACTIVE_LOW>; /* hub reset pin */
+		reset-duration-us = <10>;
 	};
 }