diff mbox

[04/18] ARM: mvebu: a385-db-ap: enable USB (orion-ehci) port

Message ID 1469105055-25181-5-git-send-email-jaz@semihalf.com (mailing list archive)
State New, archived
Headers show

Commit Message

Grzegorz Jaszczyk July 21, 2016, 12:44 p.m. UTC
Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/boot/dts/armada-385-db-ap.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Gregory CLEMENT July 27, 2016, 4 p.m. UTC | #1
Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:

> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>


Here agina, as pointed by Andrew a commit log entry would be
nice. Except this:

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory
> ---
>  arch/arm/boot/dts/armada-385-db-ap.dts | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
> index 2d3fd6e..a18f516 100644
> --- a/arch/arm/boot/dts/armada-385-db-ap.dts
> +++ b/arch/arm/boot/dts/armada-385-db-ap.dts
> @@ -155,6 +155,10 @@
>  				bm,pool-short = <3>;
>  			};
>  
> +			usb@58000 {
> +				status = "okay";
> +			};
> +
>  			/* CON4 */
>  			ethernet@70000 {
>  				pinctrl-names = "default";
> -- 
> 1.8.3.1
>
Gregory CLEMENT July 27, 2016, 4:09 p.m. UTC | #2
Hi,
 
 On mer., juil. 27 2016, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:

> Hi Grzegorz,
>  
>  On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:
>
>> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
>
>
> Here agina, as pointed by Andrew a commit log entry would be
> nice. Except this:
>
> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

I also forget to mention that the title prefix should be change to:
"ARM: dts: mvebu: a385-db-ap:"

Gregory
>
> Thanks,
>
> Gregory
>> ---
>>  arch/arm/boot/dts/armada-385-db-ap.dts | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
>> index 2d3fd6e..a18f516 100644
>> --- a/arch/arm/boot/dts/armada-385-db-ap.dts
>> +++ b/arch/arm/boot/dts/armada-385-db-ap.dts
>> @@ -155,6 +155,10 @@
>>  				bm,pool-short = <3>;
>>  			};
>>  
>> +			usb@58000 {
>> +				status = "okay";
>> +			};
>> +
>>  			/* CON4 */
>>  			ethernet@70000 {
>>  				pinctrl-names = "default";
>> -- 
>> 1.8.3.1
>>
>
> -- 
> Gregory Clement, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox

Patch

diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
index 2d3fd6e..a18f516 100644
--- a/arch/arm/boot/dts/armada-385-db-ap.dts
+++ b/arch/arm/boot/dts/armada-385-db-ap.dts
@@ -155,6 +155,10 @@ 
 				bm,pool-short = <3>;
 			};
 
+			usb@58000 {
+				status = "okay";
+			};
+
 			/* CON4 */
 			ethernet@70000 {
 				pinctrl-names = "default";