diff mbox

[05/18] ARM: mvebu: a385-db-ap: add default partition description for NAND

Message ID 1469105055-25181-6-git-send-email-jaz@semihalf.com (mailing list archive)
State New, archived
Headers show

Commit Message

Grzegorz Jaszczyk July 21, 2016, 12:44 p.m. UTC
Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
---
 arch/arm/boot/dts/armada-385-db-ap.dts | 26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

Comments

Gregory CLEMENT July 27, 2016, 4:04 p.m. UTC | #1
Hi Grzegorz,
 
 On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:

> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
It looks good:

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory


> ---
>  arch/arm/boot/dts/armada-385-db-ap.dts | 26 +++++++++++++++++++++++---
>  1 file changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
> index a18f516..6648a3f 100644
> --- a/arch/arm/boot/dts/armada-385-db-ap.dts
> +++ b/arch/arm/boot/dts/armada-385-db-ap.dts
> @@ -182,15 +182,35 @@
>  
>  			nfc: flash@d0000 {
>  				status = "okay";
> -				#address-cells = <1>;
> -				#size-cells = <1>;
> -
>  				num-cs = <1>;
>  				nand-ecc-strength = <4>;
>  				nand-ecc-step-size = <512>;
>  				marvell,nand-keep-config;
>  				marvell,nand-enable-arbiter;
>  				nand-on-flash-bbt;
> +
> +				partitions {
> +					compatible = "fixed-partitions";
> +					#address-cells = <1>;
> +					#size-cells = <1>;
> +
> +					partition@0 {
> +						label = "U-Boot";
> +						reg = <0x00000000 0x00800000>;
> +						read-only;
> +					};
> +
> +					partition@800000 {
> +						label = "uImage";
> +						reg = <0x00800000 0x00400000>;
> +						read-only;
> +					};
> +
> +					partition@c00000 {
> +						label = "Root";
> +						reg = <0x00c00000 0x3f400000>;
> +					};
> +				};
>  			};
>  
>  			usb3@f0000 {
> -- 
> 1.8.3.1
>
Gregory CLEMENT July 27, 2016, 4:10 p.m. UTC | #2
Hi,
 
 On mer., juil. 27 2016, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:

> Hi Grzegorz,
>  
>  On jeu., juil. 21 2016, Grzegorz Jaszczyk <jaz@semihalf.com> wrote:
>
>> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> It looks good:
>
> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

And here again the title prefix should be change to:
"ARM: dts: mvebu: a385-db-ap:" also do not forget fo add a commit log.

Thanks,

Gregory

>
>> ---
>>  arch/arm/boot/dts/armada-385-db-ap.dts | 26 +++++++++++++++++++++++---
>>  1 file changed, 23 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
>> index a18f516..6648a3f 100644
>> --- a/arch/arm/boot/dts/armada-385-db-ap.dts
>> +++ b/arch/arm/boot/dts/armada-385-db-ap.dts
>> @@ -182,15 +182,35 @@
>>  
>>  			nfc: flash@d0000 {
>>  				status = "okay";
>> -				#address-cells = <1>;
>> -				#size-cells = <1>;
>> -
>>  				num-cs = <1>;
>>  				nand-ecc-strength = <4>;
>>  				nand-ecc-step-size = <512>;
>>  				marvell,nand-keep-config;
>>  				marvell,nand-enable-arbiter;
>>  				nand-on-flash-bbt;
>> +
>> +				partitions {
>> +					compatible = "fixed-partitions";
>> +					#address-cells = <1>;
>> +					#size-cells = <1>;
>> +
>> +					partition@0 {
>> +						label = "U-Boot";
>> +						reg = <0x00000000 0x00800000>;
>> +						read-only;
>> +					};
>> +
>> +					partition@800000 {
>> +						label = "uImage";
>> +						reg = <0x00800000 0x00400000>;
>> +						read-only;
>> +					};
>> +
>> +					partition@c00000 {
>> +						label = "Root";
>> +						reg = <0x00c00000 0x3f400000>;
>> +					};
>> +				};
>>  			};
>>  
>>  			usb3@f0000 {
>> -- 
>> 1.8.3.1
>>
>
> -- 
> Gregory Clement, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox

Patch

diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts
index a18f516..6648a3f 100644
--- a/arch/arm/boot/dts/armada-385-db-ap.dts
+++ b/arch/arm/boot/dts/armada-385-db-ap.dts
@@ -182,15 +182,35 @@ 
 
 			nfc: flash@d0000 {
 				status = "okay";
-				#address-cells = <1>;
-				#size-cells = <1>;
-
 				num-cs = <1>;
 				nand-ecc-strength = <4>;
 				nand-ecc-step-size = <512>;
 				marvell,nand-keep-config;
 				marvell,nand-enable-arbiter;
 				nand-on-flash-bbt;
+
+				partitions {
+					compatible = "fixed-partitions";
+					#address-cells = <1>;
+					#size-cells = <1>;
+
+					partition@0 {
+						label = "U-Boot";
+						reg = <0x00000000 0x00800000>;
+						read-only;
+					};
+
+					partition@800000 {
+						label = "uImage";
+						reg = <0x00800000 0x00400000>;
+						read-only;
+					};
+
+					partition@c00000 {
+						label = "Root";
+						reg = <0x00c00000 0x3f400000>;
+					};
+				};
 			};
 
 			usb3@f0000 {