| Message ID | 1473277073-12093-1-git-send-email-slemieux.tyco@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sylvain, On 07.09.2016 22:37, Sylvain Lemieux wrote: > From: Sylvain Lemieux <slemieux@tycoint.com> > > The change setup the peripheral clock (PERIPH_CLK) as the default > parent clock for PWM1 & PWM2. > > Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com> > --- > arch/arm/boot/dts/lpc32xx.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/lpc32xx.dtsi b/arch/arm/boot/dts/lpc32xx.dtsi > index e295e1e..ed85b95 100644 > --- a/arch/arm/boot/dts/lpc32xx.dtsi > +++ b/arch/arm/boot/dts/lpc32xx.dtsi > @@ -469,6 +469,9 @@ > compatible = "nxp,lpc3220-pwm"; > reg = <0x4005C000 0x4>; > clocks = <&clk LPC32XX_CLK_PWM1>; > + assigned-clocks = <&clk LPC32XX_CLK_PWM1>, > + <&clk LPC32XX_CLK_PERIPH>; I believe here "assigned-clocks = <&clk LPC32XX_CLK_PWM1>;" would be good enough. In this context the second clock could be potentially specified, if you are going to set its rate, but because it is a common clock for many controllers it should not be done from a PWM device node. > + assigned-clock-parents = <&clk LPC32XX_CLK_PERIPH>; > status = "disabled"; > }; > > @@ -476,6 +479,9 @@ > compatible = "nxp,lpc3220-pwm"; > reg = <0x4005C004 0x4>; > clocks = <&clk LPC32XX_CLK_PWM2>; > + assigned-clocks = <&clk LPC32XX_CLK_PWM2>, > + <&clk LPC32XX_CLK_PERIPH>; Same as above. Please remove the second <&clk LPC32XX_CLK_PERIPH> value from the assigned-clocks property. > + assigned-clock-parents = <&clk LPC32XX_CLK_PERIPH>; > status = "disabled"; > }; > > -- With best wishes, Vladimir
On Thu, 2016-09-08 at 02:46 +0300, Vladimir Zapolskiy wrote: > Hi Sylvain, > > On 07.09.2016 22:37, Sylvain Lemieux wrote: > > From: Sylvain Lemieux <slemieux@tycoint.com> > > > > The change setup the peripheral clock (PERIPH_CLK) as the default > > parent clock for PWM1 & PWM2. > > > > Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com> > > --- > > arch/arm/boot/dts/lpc32xx.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm/boot/dts/lpc32xx.dtsi > > b/arch/arm/boot/dts/lpc32xx.dtsi index e295e1e..ed85b95 100644 > > --- a/arch/arm/boot/dts/lpc32xx.dtsi > > +++ b/arch/arm/boot/dts/lpc32xx.dtsi > > @@ -469,6 +469,9 @@ > > compatible = "nxp,lpc3220-pwm"; > > reg = <0x4005C000 0x4>; > > clocks = <&clk LPC32XX_CLK_PWM1>; > > + assigned-clocks = <&clk LPC32XX_CLK_PWM1>, > > + <&clk LPC32XX_CLK_PERIPH>; > > I believe here "assigned-clocks = <&clk LPC32XX_CLK_PWM1>;" would be good > enough. In this context the second clock could be potentially specified, if you > are going to set its rate, but because it is a common clock for many controllers it > should not be done from a PWM device node. > Good catch! Thanks for the feedback; I will submit a version 2 of the patch. > > + assigned-clock-parents = <&clk > LPC32XX_CLK_PERIPH>; > > status = "disabled"; > > }; > > > > @@ -476,6 +479,9 @@ > > compatible = "nxp,lpc3220-pwm"; > > reg = <0x4005C004 0x4>; > > clocks = <&clk LPC32XX_CLK_PWM2>; > > + assigned-clocks = <&clk LPC32XX_CLK_PWM2>, > > + <&clk LPC32XX_CLK_PERIPH>; > > Same as above. > > Please remove the second <&clk LPC32XX_CLK_PERIPH> value from the > assigned-clocks property. > > > + assigned-clock-parents = <&clk > LPC32XX_CLK_PERIPH>; > > status = "disabled"; > > }; > > > > > > -- > With best wishes, > Vladimir
diff --git a/arch/arm/boot/dts/lpc32xx.dtsi b/arch/arm/boot/dts/lpc32xx.dtsi index e295e1e..ed85b95 100644 --- a/arch/arm/boot/dts/lpc32xx.dtsi +++ b/arch/arm/boot/dts/lpc32xx.dtsi @@ -469,6 +469,9 @@ compatible = "nxp,lpc3220-pwm"; reg = <0x4005C000 0x4>; clocks = <&clk LPC32XX_CLK_PWM1>; + assigned-clocks = <&clk LPC32XX_CLK_PWM1>, + <&clk LPC32XX_CLK_PERIPH>; + assigned-clock-parents = <&clk LPC32XX_CLK_PERIPH>; status = "disabled"; }; @@ -476,6 +479,9 @@ compatible = "nxp,lpc3220-pwm"; reg = <0x4005C004 0x4>; clocks = <&clk LPC32XX_CLK_PWM2>; + assigned-clocks = <&clk LPC32XX_CLK_PWM2>, + <&clk LPC32XX_CLK_PERIPH>; + assigned-clock-parents = <&clk LPC32XX_CLK_PERIPH>; status = "disabled"; };