| Message ID | 1475828757-926-11-git-send-email-clabbe.montjoie@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > Enable the sun8i-emac driver in the multi_v7 default configuration > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > --- > arch/arm/configs/multi_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index 5845910..f44d633 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -229,6 +229,7 @@ CONFIG_NETDEVICES=y > CONFIG_VIRTIO_NET=y > CONFIG_HIX5HD2_GMAC=y > CONFIG_SUN4I_EMAC=y > +CONFIG_SUN8I_EMAC=y Any reason to build it statically? Thanks, Maxime
On Mon, Oct 10, 2016 at 02:30:46PM +0200, Maxime Ripard wrote: > On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > > Enable the sun8i-emac driver in the multi_v7 default configuration > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > --- > > arch/arm/configs/multi_v7_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > > index 5845910..f44d633 100644 > > --- a/arch/arm/configs/multi_v7_defconfig > > +++ b/arch/arm/configs/multi_v7_defconfig > > @@ -229,6 +229,7 @@ CONFIG_NETDEVICES=y > > CONFIG_VIRTIO_NET=y > > CONFIG_HIX5HD2_GMAC=y > > CONFIG_SUN4I_EMAC=y > > +CONFIG_SUN8I_EMAC=y > > Any reason to build it statically? > No, just copied the same than CONFIG_SUN4I_EMAC that probably do not need it also. Regards Corentin Labbe
On Mon, 10 Oct 2016 14:35:11 +0200 LABBE Corentin <clabbe.montjoie@gmail.com> wrote: > On Mon, Oct 10, 2016 at 02:30:46PM +0200, Maxime Ripard wrote: > > On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > > > Enable the sun8i-emac driver in the multi_v7 default configuration > > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > > --- > > > arch/arm/configs/multi_v7_defconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > > > index 5845910..f44d633 100644 > > > --- a/arch/arm/configs/multi_v7_defconfig > > > +++ b/arch/arm/configs/multi_v7_defconfig > > > @@ -229,6 +229,7 @@ CONFIG_NETDEVICES=y > > > CONFIG_VIRTIO_NET=y > > > CONFIG_HIX5HD2_GMAC=y > > > CONFIG_SUN4I_EMAC=y > > > +CONFIG_SUN8I_EMAC=y > > > > Any reason to build it statically? > > > > No, just copied the same than CONFIG_SUN4I_EMAC that probably do not need it also. All arm configs are done the same way, and, some day, the generic ARM V7 kernel will not be loadable in 1Gb RAM...
On Mon, Oct 10, 2016 at 03:09:43PM +0200, Jean-Francois Moine wrote: > On Mon, 10 Oct 2016 14:35:11 +0200 > LABBE Corentin <clabbe.montjoie@gmail.com> wrote: > > > On Mon, Oct 10, 2016 at 02:30:46PM +0200, Maxime Ripard wrote: > > > On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > > > > Enable the sun8i-emac driver in the multi_v7 default configuration > > > > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > > > --- > > > > arch/arm/configs/multi_v7_defconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > > > > index 5845910..f44d633 100644 > > > > --- a/arch/arm/configs/multi_v7_defconfig > > > > +++ b/arch/arm/configs/multi_v7_defconfig > > > > @@ -229,6 +229,7 @@ CONFIG_NETDEVICES=y > > > > CONFIG_VIRTIO_NET=y > > > > CONFIG_HIX5HD2_GMAC=y > > > > CONFIG_SUN4I_EMAC=y > > > > +CONFIG_SUN8I_EMAC=y > > > > > > Any reason to build it statically? > > > > No, just copied the same than CONFIG_SUN4I_EMAC that probably do > > not need it also. > > All arm configs are done the same way, and, some day, the generic ARM > V7 kernel will not be loadable in 1Gb RAM... Yeah, if possible, I'd really like to avoid introducing statically built drivers to multi_v7. Maxime
On Tue, Oct 11, 2016 at 11:40:42AM +0200, Maxime Ripard wrote: > On Mon, Oct 10, 2016 at 03:09:43PM +0200, Jean-Francois Moine wrote: > > On Mon, 10 Oct 2016 14:35:11 +0200 > > LABBE Corentin <clabbe.montjoie@gmail.com> wrote: > > > > > On Mon, Oct 10, 2016 at 02:30:46PM +0200, Maxime Ripard wrote: > > > > On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > > > > > Enable the sun8i-emac driver in the multi_v7 default configuration > > > > > > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > > > > > --- > > > > > arch/arm/configs/multi_v7_defconfig | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > > > > > index 5845910..f44d633 100644 > > > > > --- a/arch/arm/configs/multi_v7_defconfig > > > > > +++ b/arch/arm/configs/multi_v7_defconfig > > > > > @@ -229,6 +229,7 @@ CONFIG_NETDEVICES=y > > > > > CONFIG_VIRTIO_NET=y > > > > > CONFIG_HIX5HD2_GMAC=y > > > > > CONFIG_SUN4I_EMAC=y > > > > > +CONFIG_SUN8I_EMAC=y > > > > > > > > Any reason to build it statically? > > > > > > No, just copied the same than CONFIG_SUN4I_EMAC that probably do > > > not need it also. > > > > All arm configs are done the same way, and, some day, the generic ARM > > V7 kernel will not be loadable in 1Gb RAM... > > Yeah, if possible, I'd really like to avoid introducing statically > built drivers to multi_v7. > I forgot to said it in my first answer, but yes I will change it. Regards
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 5845910..f44d633 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -229,6 +229,7 @@ CONFIG_NETDEVICES=y CONFIG_VIRTIO_NET=y CONFIG_HIX5HD2_GMAC=y CONFIG_SUN4I_EMAC=y +CONFIG_SUN8I_EMAC=y CONFIG_MACB=y CONFIG_BCMGENET=m CONFIG_SYSTEMPORT=m
Enable the sun8i-emac driver in the multi_v7 default configuration Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+)