| Message ID | 1476704849-24039-1-git-send-email-vladimir.murzin@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 17/10/16 12:47, Vladimir Murzin wrote: > Removale of skeleton.dtsi allows us also to fix the following > warning from the dts compiler: > Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name > > by adding proper unit addresses to the memory nodes. > > Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com> It's always better to cc device-tree list, anyways applied this to [1]. -- Regards, Sudeep [1] git.kernel.org/sudeep.holla/linux/h/vexpress-dt/for-next
On 17/10/16 17:51, Sudeep Holla wrote: > > > On 17/10/16 12:47, Vladimir Murzin wrote: >> Removale of skeleton.dtsi allows us also to fix the following >> warning from the dts compiler: >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name >> >> by adding proper unit addresses to the memory nodes. >> >> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com> > > It's always better to cc device-tree list, anyways applied this to [1]. Thanks! Vladimir > > -- > Regards, > Sudeep > > [1] git.kernel.org/sudeep.holla/linux/h/vexpress-dt/for-next > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >
diff --git a/arch/arm/boot/dts/mps2-an385.dts b/arch/arm/boot/dts/mps2-an385.dts index 31c374d..aebbebf 100644 --- a/arch/arm/boot/dts/mps2-an385.dts +++ b/arch/arm/boot/dts/mps2-an385.dts @@ -59,7 +59,7 @@ stdout-path = "serial0:9600n8"; }; - memory { + memory@21000000 { device_type = "memory"; reg = <0x21000000 0x1000000>; }; diff --git a/arch/arm/boot/dts/mps2-an399.dts b/arch/arm/boot/dts/mps2-an399.dts index 5e7e5ca..349abf7 100644 --- a/arch/arm/boot/dts/mps2-an399.dts +++ b/arch/arm/boot/dts/mps2-an399.dts @@ -59,7 +59,7 @@ stdout-path = "serial0:9600n8"; }; - memory { + memory@60000000 { device_type = "memory"; reg = <0x60000000 0x1000000>; }; diff --git a/arch/arm/boot/dts/mps2.dtsi b/arch/arm/boot/dts/mps2.dtsi index efb8a03..2346739 100644 --- a/arch/arm/boot/dts/mps2.dtsi +++ b/arch/arm/boot/dts/mps2.dtsi @@ -42,10 +42,12 @@ * OTHER DEALINGS IN THE SOFTWARE. */ -#include "skeleton.dtsi" #include "armv7-m.dtsi" / { + #address-cells = <1>; + #size-cells = <1>; + oscclk0: clk-osc0 { compatible = "fixed-clock"; #clock-cells = <0>;
Removale of skeleton.dtsi allows us also to fix the following warning from the dts compiler: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name by adding proper unit addresses to the memory nodes. Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com> --- arch/arm/boot/dts/mps2-an385.dts | 2 +- arch/arm/boot/dts/mps2-an399.dts | 2 +- arch/arm/boot/dts/mps2.dtsi | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-)