From patchwork Mon Oct 17 14:55:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9379527 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1177C607D4 for ; Mon, 17 Oct 2016 14:57:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0322729197 for ; Mon, 17 Oct 2016 14:57:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EB7EA292FC; Mon, 17 Oct 2016 14:57:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AE42329197 for ; Mon, 17 Oct 2016 14:57:34 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bw9Kp-0001Ij-Ea; Mon, 17 Oct 2016 14:56:15 +0000 Received: from mail-pa0-x244.google.com ([2607:f8b0:400e:c03::244]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bw9Kk-0001BS-I4 for linux-arm-kernel@lists.infradead.org; Mon, 17 Oct 2016 14:56:11 +0000 Received: by mail-pa0-x244.google.com with SMTP id qn10so9309993pac.2 for ; Mon, 17 Oct 2016 07:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=p3oTBIGtCvcYfcH0aPZlKSIhDlkvtAsCfdMD7psFw2c=; b=fY2bfkSY30XYWFnjYl7lRpAny1F8Mytp7hrlKh3pgxXIGwutT6mtB5hrJTazDvyTIR A140qbR6Dln0iMme8vLk/6zDPwBROd/94Q3iwW64FZt0smLYBpSAdEoc+Cg04DM5rbMR 2L5Drao3xP5PlqWiExzAi6W/A7ssftVsbmXGSPmoATwKH+Ksa+76ycbqJ2XnMHPnj+ai WEKklE78QpKjGpeOBBG+gQHcOB/Tg8QSsH1dFlMldZs6Yp5fObRjtElTL+Fm+6IqeFFK /kgph3NUVG1PtpXQXXN5TjwD6a34ZOfWM/q7XJCJeOp1VtSMcPO3gnEmIunhTzJsScSx Xxcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=p3oTBIGtCvcYfcH0aPZlKSIhDlkvtAsCfdMD7psFw2c=; b=MYY9K20Q14h+idbqqrlqFPsfZu2qjuUVQamedK0pDmiljqW+KZq9w0N6lE+Rap8LeX yD5+j+b9f2Idk7HkQ77v/5Coxp9uIXoFQj9oYWFHms/Hq7USW1Pvlju5ITQw3fVyH13e we41ZBVAxKAYfhT/jxhp4Cg9UUC5M/PkafMl1ArTYgKrkrZrG+9kUqAVbgcQwaz+13Zz OmZ8FX0r6v0swysE57QiRxiLNuT2wicgZDsKsTNnAV5iTQgSY6nftDvPfszIkSuj+fkQ 6bJjrXmKQOY/bAIC2nfZdDtpSYyTLRvENDQQXUbyQA0FoRmHrVmwaOKxbjT9RfOt27D2 Yqog== X-Gm-Message-State: AA6/9RnTRHFKnp5EkcOk1pq2/A4x1lCHEefw5CZazD4KTUobO32rbwR9fOVodsh57vA3TA== X-Received: by 10.66.248.132 with SMTP id ym4mr32520532pac.182.1476716149421; Mon, 17 Oct 2016 07:55:49 -0700 (PDT) Received: from 192.168.0.37 (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id u10sm48940248pau.32.2016.10.17.07.55.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Oct 2016 07:55:48 -0700 (PDT) From: Wei Yongjun To: Minghuan Lian , Mingkai Hu , Roy Zang , Bjorn Helgaas Subject: [PATCH -next] PCI: layerscape: Remove redundant dev_err call in ls_pcie_probe() Date: Mon, 17 Oct 2016 14:55:40 +0000 Message-Id: <1476716140-30608-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161017_075610_735578_46EF9909 X-CRM114-Status: GOOD ( 10.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, Wei Yongjun , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/pci/host/pci-layerscape.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 2cb7315..bbd3d23 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -251,10 +251,8 @@ static int __init ls_pcie_probe(struct platform_device *pdev) dbi_base = platform_get_resource_byname(pdev, IORESOURCE_MEM, "regs"); pcie->pp.dbi_base = devm_ioremap_resource(dev, dbi_base); - if (IS_ERR(pcie->pp.dbi_base)) { - dev_err(dev, "missing *regs* space\n"); + if (IS_ERR(pcie->pp.dbi_base)) return PTR_ERR(pcie->pp.dbi_base); - } pcie->drvdata = match->data; pcie->lut = pcie->pp.dbi_base + pcie->drvdata->lut_offset;