From patchwork Mon Oct 24 08:00:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 9391563 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 296FF60231 for ; Mon, 24 Oct 2016 08:02:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1994328669 for ; Mon, 24 Oct 2016 08:02:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0D8C328A08; Mon, 24 Oct 2016 08:02:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0C54F28669 for ; Mon, 24 Oct 2016 08:02:18 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1byaCy-0002jT-ON; Mon, 24 Oct 2016 08:02:12 +0000 Received: from conuserg-12.nifty.com ([210.131.2.79]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1byaA9-0007wu-OX for linux-arm-kernel@lists.infradead.org; Mon, 24 Oct 2016 07:59:18 +0000 Received: from beagle.diag.org (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id u9O7w6Hn008639; Mon, 24 Oct 2016 16:58:08 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com u9O7w6Hn008639 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1477295888; bh=LtcjeDu119Mpc7+Wu4XwyHpv7kx9RI/T4ABGPKTWq4c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rRWPw9dc93TW8vdiSLuhXmMnBS+CuiQUcYuiHHGHoOzqRHRHwx/QfkMLzRxsyVO9n Of+X553p7nKX+2rWNBvM5UC5hi6fh+B11+JsMS3fzb9EMSVUNA1NTtmfUEnHq/BlJI 8bah1sRj/Rvtx3KKRtfp8QBZoW4LhjipBcRcgWJJFqAh6ps71YcblVsG793wtwxa/w CPPV4Sh2mKaVT+QkgMZZo6MpSj1mMzK4MVGBE1aaRMda6QHZiP8iRpAjtsBVE+mb9i UQHxlTNZWguuxbwqyymK+xQNNYNxDPbxMr2TPStnfRE/sJy3WWFRRvoSjVy/6LQBjY l8l2krc1We2iw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-serial@vger.kernel.org Subject: [PATCH 2/4] serial: 8250_uniphier: fix clearing divisor latch access bit Date: Mon, 24 Oct 2016 17:00:28 +0900 Message-Id: <1477296030-7517-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1477296030-7517-1-git-send-email-yamada.masahiro@socionext.com> References: <1477296030-7517-1-git-send-email-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161024_005918_092171_EFDFFA27 X-CRM114-Status: UNSURE ( 8.53 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Denys Vlasenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Masahiro Yamada , Jiri Slaby , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP At this point, 'value' is always a byte, then this code is clearing bit 15, which is already clear. I meant to clear bit 7. Signed-off-by: Masahiro Yamada Reported-by: Denys Vlasenko --- drivers/tty/serial/8250/8250_uniphier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c index a8babb0..417d9e7 100644 --- a/drivers/tty/serial/8250/8250_uniphier.c +++ b/drivers/tty/serial/8250/8250_uniphier.c @@ -99,7 +99,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value) case UART_LCR: valshift = UNIPHIER_UART_LCR_SHIFT; /* Divisor latch access bit does not exist. */ - value &= ~(UART_LCR_DLAB << valshift); + value &= ~UART_LCR_DLAB; /* fall through */ case UART_MCR: offset = UNIPHIER_UART_LCR_MCR;