| Message ID | 1477588303-13681-1-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Oct 27, 2016 at 02:11:41PM -0300, Javier Martinez Canillas wrote: > There's a cognitive load to figure out which mmc device node corresponds > to the eMMC flash, uSD card and WiFI SDIO module on the Snow boards. > > So it's better to have comments in the DTS to make this more clear. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > > arch/arm/boot/dts/exynos5250-snow-common.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) Thanks, applied after squashing three into one. These are only comments, so no impact on the code, and meaning/goal of them is exactly same. Best regards, Krzysztof
Hello Krzysztof, On 10/28/2016 10:34 AM, Krzysztof Kozlowski wrote: > On Thu, Oct 27, 2016 at 02:11:41PM -0300, Javier Martinez Canillas wrote: >> There's a cognitive load to figure out which mmc device node corresponds >> to the eMMC flash, uSD card and WiFI SDIO module on the Snow boards. >> >> So it's better to have comments in the DTS to make this more clear. >> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >> --- >> >> arch/arm/boot/dts/exynos5250-snow-common.dtsi | 4 ++++ >> 1 file changed, 4 insertions(+) > > Thanks, applied after squashing three into one. These are only comments, > so no impact on the code, and meaning/goal of them is exactly same. > Ok, sounds good to me. Thanks! > Best regards, > Krzysztof > Best regards,
diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi b/arch/arm/boot/dts/exynos5250-snow-common.dtsi index d5d51916bb74..8f3a80430748 100644 --- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi +++ b/arch/arm/boot/dts/exynos5250-snow-common.dtsi @@ -523,6 +523,7 @@ status = "okay"; }; +/* eMMC flash */ &mmc_0 { status = "okay"; num-slots = <1>; @@ -536,6 +537,7 @@ cap-mmc-highspeed; }; +/* uSD card */ &mmc_2 { status = "okay"; num-slots = <1>; @@ -553,6 +555,8 @@ /* * On Snow we've got SIP WiFi and so can keep drive strengths low to * reduce EMI. + * + * WiFi SDIO module */ &mmc_3 { status = "okay";
There's a cognitive load to figure out which mmc device node corresponds to the eMMC flash, uSD card and WiFI SDIO module on the Snow boards. So it's better to have comments in the DTS to make this more clear. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- arch/arm/boot/dts/exynos5250-snow-common.dtsi | 4 ++++ 1 file changed, 4 insertions(+)