From patchwork Tue Nov 1 20:04:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Mason X-Patchwork-Id: 9407997 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EFAB760721 for ; Tue, 1 Nov 2016 20:06:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E290329A7C for ; Tue, 1 Nov 2016 20:06:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D70CC29A8A; Tue, 1 Nov 2016 20:06:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9A3A529A7C for ; Tue, 1 Nov 2016 20:06:52 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1c1fJQ-0007iU-8P; Tue, 01 Nov 2016 20:05:36 +0000 Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c1fJ4-0006Ip-3X for linux-arm-kernel@lists.infradead.org; Tue, 01 Nov 2016 20:05:15 +0000 Received: by mail-pf0-x22a.google.com with SMTP id 189so46862399pfz.3 for ; Tue, 01 Nov 2016 13:04:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=B6nJChFVtEyYZpvj7BByAVb8GzbUTsEAGIWSl7rLQ7Y=; b=CEsRdD15f1c8wRxttCW0s6nyYbjUMHxCFtm+rHq9ru5noxRek1f1ERq8jOTEglCFRe Qha1zuqi2VLyAvKjsK4pD/Y/DNNsLJC1o6RoUiuLJW0eMw4FJNliXW+ES20fk62kye3/ 0WBS/G53U5rkDnF5O0rS9yLhPTF10MGEF1l+I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=B6nJChFVtEyYZpvj7BByAVb8GzbUTsEAGIWSl7rLQ7Y=; b=W1mP/WRsIExjuiEYNE0P02yV5Rdy8rHsJH2OUevmBQwPAMNxZfmWtrkZ01aFXd6tir +Q/Lno5daS4jO34wY5JrITFogA/x6gDZY/uz55iW9y+aadu3NjL2tS3XdOjjwI6irZxf sHM+G0FVC2eLflv90mzcBlZneJ5afWKlO38I8iMih9lajkh5zUAI72VjHU93wbxWzrgL oVfQZ5vAssRJqtyt+LCcsnPPpff6XSBBukQgNY0jNXrTZYhBwq3BkB1+wTdAydAFT3b8 s7KycSG6GK1venucnsdLS8ioaZCDLEqVaRMSsVFvCr7Cv5NFh8/T+biwiWt9H9wyoiiw p9CQ== X-Gm-Message-State: ABUngvfgnNRQIEA7o5J/di1tIbUqidWw7h6QQxAbyPvbYJ2MuCMR/wVKMHXttKP2UKUluJ1p X-Received: by 10.98.24.198 with SMTP id 189mr62105116pfy.31.1478030694697; Tue, 01 Nov 2016 13:04:54 -0700 (PDT) Received: from venom.rtp.broadcom.com ([216.31.219.19]) by smtp.gmail.com with ESMTPSA id wc6sm44113821pab.47.2016.11.01.13.04.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 01 Nov 2016 13:04:54 -0700 (PDT) From: Jon Mason To: David Miller , Rob Herring , Mark Rutland , Florian Fainelli Subject: [PATCH v4 1/7] net: phy: broadcom: add bcm54xx_auxctl_read Date: Tue, 1 Nov 2016 16:04:36 -0400 Message-Id: <1478030682-27012-2-git-send-email-jon.mason@broadcom.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1478030682-27012-1-git-send-email-jon.mason@broadcom.com> References: <1478030682-27012-1-git-send-email-jon.mason@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161101_130514_222158_486D9138 X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, rafal@milecki.pl, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Add a helper function to read the AUXCTL register for the BCM54xx. This mirrors the bcm54xx_auxctl_write function already present in the code. Signed-off-by: Jon Mason --- drivers/net/phy/broadcom.c | 10 ++++++++++ include/linux/brcmphy.h | 1 + 2 files changed, 11 insertions(+) diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index 583ef8a..3a64b3d 100644 --- a/drivers/net/phy/broadcom.c +++ b/drivers/net/phy/broadcom.c @@ -30,6 +30,16 @@ MODULE_DESCRIPTION("Broadcom PHY driver"); MODULE_AUTHOR("Maciej W. Rozycki"); MODULE_LICENSE("GPL"); +static int bcm54xx_auxctl_read(struct phy_device *phydev, u16 regnum) +{ + /* The register must be written to both the Shadow Register Select and + * the Shadow Read Register Selector + */ + phy_write(phydev, MII_BCM54XX_AUX_CTL, regnum | + regnum << MII_BCM54XX_AUXCTL_SHDWSEL_READ_SHIFT); + return phy_read(phydev, MII_BCM54XX_AUX_CTL); +} + static int bcm54xx_auxctl_write(struct phy_device *phydev, u16 regnum, u16 val) { return phy_write(phydev, MII_BCM54XX_AUX_CTL, regnum | val); diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h index 60def78..0ed6691 100644 --- a/include/linux/brcmphy.h +++ b/include/linux/brcmphy.h @@ -110,6 +110,7 @@ #define MII_BCM54XX_AUXCTL_MISC_FORCE_AMDIX 0x0200 #define MII_BCM54XX_AUXCTL_MISC_RDSEL_MISC 0x7000 #define MII_BCM54XX_AUXCTL_SHDWSEL_MISC 0x0007 +#define MII_BCM54XX_AUXCTL_SHDWSEL_READ_SHIFT 12 #define MII_BCM54XX_AUXCTL_SHDWSEL_MASK 0x0007