| Message ID | 1478534334-15562-1-git-send-email-yamada.masahiro@socionext.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Nov 08, 2016 at 12:58:54AM +0900, Masahiro Yamada wrote: > Nothing in this header file depends on <linux/types.h>. > Rather, <linux/errno.h> should be included for -ENODEV. So how do we end up with a definition for u32? I think you need both these include files.
On Mon, Nov 07, 2016 at 04:14:48PM +0000, Russell King - ARM Linux wrote: > On Tue, Nov 08, 2016 at 12:58:54AM +0900, Masahiro Yamada wrote: > > Nothing in this header file depends on <linux/types.h>. > > Rather, <linux/errno.h> should be included for -ENODEV. > > So how do we end up with a definition for u32? > > I think you need both these include files. I've noticed you haven't responded to the above. I've discarded the patch you've placed in the patch system in the hope of a replacement with this comment addressed. Thanks.
diff --git a/arch/arm/include/asm/hardware/cache-uniphier.h b/arch/arm/include/asm/hardware/cache-uniphier.h index eaa60da..0ef42ae 100644 --- a/arch/arm/include/asm/hardware/cache-uniphier.h +++ b/arch/arm/include/asm/hardware/cache-uniphier.h @@ -16,7 +16,7 @@ #ifndef __CACHE_UNIPHIER_H #define __CACHE_UNIPHIER_H -#include <linux/types.h> +#include <linux/errno.h> #ifdef CONFIG_CACHE_UNIPHIER int uniphier_cache_init(void);
Nothing in this header file depends on <linux/types.h>. Rather, <linux/errno.h> should be included for -ENODEV. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- KernelVersion: 4.9-rc1 arch/arm/include/asm/hardware/cache-uniphier.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)