| Message ID | 1478697721-2323-2-git-send-email-wxt@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2016/11/9 21:21, Caesar Wang wrote: > From: Ziyuan Xu <xzy.xu@rock-chips.com> > > Control power domain for eMMC via genpd to reduce power consumption. > > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> > Signed-off-by: Caesar Wang <wxt@rock-chips.com> It was verified on my rk3399 evb with kernel4.4, so free feel to add my tag, Tested-by: Shawn Lin <shawn.lin@rock-chips.com> BTW, it seems my reply is bounced form Yakir's address, so please remove him from CC list if he changed his mail address. > --- > > Changes in v2: > - Reviewed-on: https://chromium-review.googlesource.com/376558 > - Verified on ChromeOS kernel4.4 > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index cbb7f8b..b401176 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -269,6 +269,7 @@ > #clock-cells = <0>; > phys = <&emmc_phy>; > phy-names = "phy_arasan"; > + power-domains = <&power RK3399_PD_EMMC>; > status = "disabled"; > }; > > @@ -690,6 +691,11 @@ > status = "disabled"; > }; > > + qos_emmc: qos@ffa58000 { > + compatible = "syscon"; > + reg = <0x0 0xffa58000 0x0 0x20>; > + }; > + > qos_gmac: qos@ffa5c000 { > compatible = "syscon"; > reg = <0x0 0xffa5c000 0x0 0x20>; > @@ -823,6 +829,11 @@ > }; > > /* These power domains are grouped by VD_LOGIC */ > + pd_emmc@RK3399_PD_EMMC { > + reg = <RK3399_PD_EMMC>; > + clocks = <&cru ACLK_EMMC>; > + pm_qos = <&qos_emmc>; > + }; > pd_gmac@RK3399_PD_GMAC { > reg = <RK3399_PD_GMAC>; > clocks = <&cru ACLK_GMAC>; >
Am Mittwoch, 9. November 2016, 21:21:53 CET schrieb Caesar Wang: > From: Ziyuan Xu <xzy.xu@rock-chips.com> > > Control power domain for eMMC via genpd to reduce power consumption. > > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> > Signed-off-by: Caesar Wang <wxt@rock-chips.com> Authorship / Signed-off mismatch. From above suggest Ziyuan is the author while first Signed-off-by indicates Elaine as author. Please clarify. Thanks Heiko > --- > > Changes in v2: > - Reviewed-on: https://chromium-review.googlesource.com/376558 > - Verified on ChromeOS kernel4.4 > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index cbb7f8b..b401176 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -269,6 +269,7 @@ > #clock-cells = <0>; > phys = <&emmc_phy>; > phy-names = "phy_arasan"; > + power-domains = <&power RK3399_PD_EMMC>; > status = "disabled"; > }; > > @@ -690,6 +691,11 @@ > status = "disabled"; > }; > > + qos_emmc: qos@ffa58000 { > + compatible = "syscon"; > + reg = <0x0 0xffa58000 0x0 0x20>; > + }; > + > qos_gmac: qos@ffa5c000 { > compatible = "syscon"; > reg = <0x0 0xffa5c000 0x0 0x20>; > @@ -823,6 +829,11 @@ > }; > > /* These power domains are grouped by VD_LOGIC */ > + pd_emmc@RK3399_PD_EMMC { > + reg = <RK3399_PD_EMMC>; > + clocks = <&cru ACLK_EMMC>; > + pm_qos = <&qos_emmc>; > + }; > pd_gmac@RK3399_PD_GMAC { > reg = <RK3399_PD_GMAC>; > clocks = <&cru ACLK_GMAC>;
On 2016年11月14日 22:45, Heiko Stuebner wrote: > Am Mittwoch, 9. November 2016, 21:21:53 CET schrieb Caesar Wang: >> From: Ziyuan Xu <xzy.xu@rock-chips.com> >> >> Control power domain for eMMC via genpd to reduce power consumption. >> >> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> >> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> >> Signed-off-by: Caesar Wang <wxt@rock-chips.com> > Authorship / Signed-off mismatch. From above suggest Ziyuan is the author > while first Signed-off-by indicates Elaine as author. Please clarify. I believe the Elaine is the first author. Sorry for this kind of question to brother you again. :( - Caesar > > Thanks > Heiko > >> --- >> >> Changes in v2: >> - Reviewed-on: https://chromium-review.googlesource.com/376558 >> - Verified on ChromeOS kernel4.4 >> >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index cbb7f8b..b401176 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> @@ -269,6 +269,7 @@ >> #clock-cells = <0>; >> phys = <&emmc_phy>; >> phy-names = "phy_arasan"; >> + power-domains = <&power RK3399_PD_EMMC>; >> status = "disabled"; >> }; >> >> @@ -690,6 +691,11 @@ >> status = "disabled"; >> }; >> >> + qos_emmc: qos@ffa58000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffa58000 0x0 0x20>; >> + }; >> + >> qos_gmac: qos@ffa5c000 { >> compatible = "syscon"; >> reg = <0x0 0xffa5c000 0x0 0x20>; >> @@ -823,6 +829,11 @@ >> }; >> >> /* These power domains are grouped by VD_LOGIC */ >> + pd_emmc@RK3399_PD_EMMC { >> + reg = <RK3399_PD_EMMC>; >> + clocks = <&cru ACLK_EMMC>; >> + pm_qos = <&qos_emmc>; >> + }; >> pd_gmac@RK3399_PD_GMAC { >> reg = <RK3399_PD_GMAC>; >> clocks = <&cru ACLK_GMAC>; > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
On 2016年11月12日 12:22, Shawn Lin wrote: > On 2016/11/9 21:21, Caesar Wang wrote: >> From: Ziyuan Xu <xzy.xu@rock-chips.com> >> >> Control power domain for eMMC via genpd to reduce power consumption. >> >> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> >> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> >> Signed-off-by: Caesar Wang <wxt@rock-chips.com> > > It was verified on my rk3399 evb with kernel4.4, so > free feel to add my tag, > > Tested-by: Shawn Lin <shawn.lin@rock-chips.com> > Thanks the tests. > BTW, it seems my reply is bounced form Yakir's address, so please > remove him from CC list if he changed his mail address. Right, Yakir's (ykk@rock-chips.com) address had left this world.;-) But the patman tool is auto sending with the Cc people. - Caesar > >> --- >> >> Changes in v2: >> - Reviewed-on: https://chromium-review.googlesource.com/376558 >> - Verified on ChromeOS kernel4.4 >> >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> index cbb7f8b..b401176 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> @@ -269,6 +269,7 @@ >> #clock-cells = <0>; >> phys = <&emmc_phy>; >> phy-names = "phy_arasan"; >> + power-domains = <&power RK3399_PD_EMMC>; >> status = "disabled"; >> }; >> >> @@ -690,6 +691,11 @@ >> status = "disabled"; >> }; >> >> + qos_emmc: qos@ffa58000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffa58000 0x0 0x20>; >> + }; >> + >> qos_gmac: qos@ffa5c000 { >> compatible = "syscon"; >> reg = <0x0 0xffa5c000 0x0 0x20>; >> @@ -823,6 +829,11 @@ >> }; >> >> /* These power domains are grouped by VD_LOGIC */ >> + pd_emmc@RK3399_PD_EMMC { >> + reg = <RK3399_PD_EMMC>; >> + clocks = <&cru ACLK_EMMC>; >> + pm_qos = <&qos_emmc>; >> + }; >> pd_gmac@RK3399_PD_GMAC { >> reg = <RK3399_PD_GMAC>; >> clocks = <&cru ACLK_GMAC>; >> > >
Am Montag, 14. November 2016, 23:01:27 CET schrieb Caesar Wang: > On 2016年11月14日 22:45, Heiko Stuebner wrote: > > Am Mittwoch, 9. November 2016, 21:21:53 CET schrieb Caesar Wang: > >> From: Ziyuan Xu <xzy.xu@rock-chips.com> > >> > >> Control power domain for eMMC via genpd to reduce power consumption. > >> > >> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > >> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> > >> Signed-off-by: Caesar Wang <wxt@rock-chips.com> > > > > Authorship / Signed-off mismatch. From above suggest Ziyuan is the author > > while first Signed-off-by indicates Elaine as author. Please clarify. > > I believe the Elaine is the first author. Sorry for this kind of > question to brother you again. :( no problem :-) and thanks for the very fast reply. Applied to my dts64 branch. Thanks Heiko
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index cbb7f8b..b401176 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi @@ -269,6 +269,7 @@ #clock-cells = <0>; phys = <&emmc_phy>; phy-names = "phy_arasan"; + power-domains = <&power RK3399_PD_EMMC>; status = "disabled"; }; @@ -690,6 +691,11 @@ status = "disabled"; }; + qos_emmc: qos@ffa58000 { + compatible = "syscon"; + reg = <0x0 0xffa58000 0x0 0x20>; + }; + qos_gmac: qos@ffa5c000 { compatible = "syscon"; reg = <0x0 0xffa5c000 0x0 0x20>; @@ -823,6 +829,11 @@ }; /* These power domains are grouped by VD_LOGIC */ + pd_emmc@RK3399_PD_EMMC { + reg = <RK3399_PD_EMMC>; + clocks = <&cru ACLK_EMMC>; + pm_qos = <&qos_emmc>; + }; pd_gmac@RK3399_PD_GMAC { reg = <RK3399_PD_GMAC>; clocks = <&cru ACLK_GMAC>;