| Message ID | 1479806768-39911-4-git-send-email-vladimir.murzin@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Nov 22, 2016 at 09:26:00AM +0000, Vladimir Murzin wrote: > Explicit selection of HIGHMEM breaks NOMMU builds. It seems that > HIGHMEM is user selectable option, so probably it would be better to > let user to make a decision on this options or, at least, move it to > defconfig. That's kind of the point of ARCH_OMAP2PLUS_TYPICAL - it's a user option to let the user select a range of options for typical OMAP2+ configurations, so that the user doesn't have to dig around looking for multiple options, some of which are hard requirements for OMAP to be functional. OMAP is a particularly difficult case because the hardware tends to be very complex. However, HIGHMEM should never be a requirement to boot, so this looks sane.
* Russell King - ARM Linux <linux@armlinux.org.uk> [161122 01:51]: > On Tue, Nov 22, 2016 at 09:26:00AM +0000, Vladimir Murzin wrote: > > Explicit selection of HIGHMEM breaks NOMMU builds. It seems that > > HIGHMEM is user selectable option, so probably it would be better to > > let user to make a decision on this options or, at least, move it to > > defconfig. > > That's kind of the point of ARCH_OMAP2PLUS_TYPICAL - it's a user > option to let the user select a range of options for typical OMAP2+ > configurations, so that the user doesn't have to dig around looking > for multiple options, some of which are hard requirements for OMAP > to be functional. OMAP is a particularly difficult case because the > hardware tends to be very complex. > > However, HIGHMEM should never be a requirement to boot, so this looks > sane. Yeah we can add that to the defconfig: Acked-by: Tony Lindgren <tony@atomide.com>
On 23/11/16 15:49, Tony Lindgren wrote: > * Russell King - ARM Linux <linux@armlinux.org.uk> [161122 01:51]: >> On Tue, Nov 22, 2016 at 09:26:00AM +0000, Vladimir Murzin wrote: >>> Explicit selection of HIGHMEM breaks NOMMU builds. It seems that >>> HIGHMEM is user selectable option, so probably it would be better to >>> let user to make a decision on this options or, at least, move it to >>> defconfig. >> >> That's kind of the point of ARCH_OMAP2PLUS_TYPICAL - it's a user >> option to let the user select a range of options for typical OMAP2+ >> configurations, so that the user doesn't have to dig around looking >> for multiple options, some of which are hard requirements for OMAP >> to be functional. OMAP is a particularly difficult case because the >> hardware tends to be very complex. >> >> However, HIGHMEM should never be a requirement to boot, so this looks >> sane. > > Yeah we can add that to the defconfig: > > Acked-by: Tony Lindgren <tony@atomide.com> > Thanks! Vladimir
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index a9afeeb..4e3fb69 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -120,7 +120,6 @@ config ARCH_OMAP2PLUS_TYPICAL bool "Typical OMAP configuration" default y select AEABI - select HIGHMEM select I2C select I2C_OMAP select MENELAUS if ARCH_OMAP2
Explicit selection of HIGHMEM breaks NOMMU builds. It seems that HIGHMEM is user selectable option, so probably it would be better to let user to make a decision on this options or, at least, move it to defconfig. Cc: Tony Lindgren <tony@atomide.com> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com> --- arch/arm/mach-omap2/Kconfig | 1 - 1 file changed, 1 deletion(-)