From patchwork Sat Dec 10 13:08:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pankaj Dubey X-Patchwork-Id: 9469311 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C4F4B60234 for ; Sat, 10 Dec 2016 13:09:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B532028425 for ; Sat, 10 Dec 2016 13:09:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A79D02858C; Sat, 10 Dec 2016 13:09:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 38AA328425 for ; Sat, 10 Dec 2016 13:09:52 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1cFhO0-0007DM-2T; Sat, 10 Dec 2016 13:08:20 +0000 Received: from mailout1.samsung.com ([203.254.224.24]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cFhMa-0006bQ-8d for linux-arm-kernel@lists.infradead.org; Sat, 10 Dec 2016 13:06:55 +0000 Received: from epcpsbgm2new.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OHZ0235C0ED59A0@mailout1.samsung.com> for linux-arm-kernel@lists.infradead.org; Sat, 10 Dec 2016 22:06:24 +0900 (KST) X-AuditID: cbfee61b-f796f6d000004092-7a-584bfdd0bc20 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id 64.75.16530.0DDFB485; Sat, 10 Dec 2016 22:06:24 +0900 (KST) Received: from pankaj.sisodomain.com ([107.108.83.125]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OHZ000990EAMM70@mmp1.samsung.com>; Sat, 10 Dec 2016 22:06:24 +0900 (KST) From: Pankaj Dubey To: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v8 5/8] ARM: EXYNOS: refactor power management specific routines Date: Sat, 10 Dec 2016 18:38:40 +0530 Message-id: <1481375323-29724-6-git-send-email-pankaj.dubey@samsung.com> X-Mailer: git-send-email 2.7.4 In-reply-to: <1481375323-29724-1-git-send-email-pankaj.dubey@samsung.com> References: <1481375323-29724-1-git-send-email-pankaj.dubey@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmkeLIzCtJLcpLzFFi42I5/e+xgO6Fv94RBjd75Cz+TjrGbjF39iRG izdv1zBZ9D9+zWxx/vwGdotNj6+xWsw4v4/JYu2Ru+wWi7Z+YbfoWMbowOXx+9ckRo+JZ3U9 Nq3qZPPYvKTeY0v/XXaPvi2rGD0+b5ILYI9ys8lITUxJLVJIzUvOT8nMS7dVCg1x07VQUshL zE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW8bvVb9ZClY5VVzZv4+9gfGIeRcjJ4eE gInEkhltjBC2mMSFe+vZQGwhgaWMEmd6bLsYuYDsn4wSp/t3gSXYBHQlnryfywxiiwh4S0w+ 85cdpIhZ4DCjxK2Xd8CKhAUCJDa9vA1mswioSqxavwNsA6+Ah8TezctZILbJSdw81wk2iFPA U+LB7SlQmz0kvs/byDKBkXcBI8MqRonUguSC4qT0XKO81HK94sTc4tK8dL3k/NxNjOAIeCa9 g/HwLvdDjAIcjEo8vBV23hFCrIllxZW5hxglOJiVRHh3/wAK8aYkVlalFuXHF5XmpBYfYjQF Omwis5Rocj4wOvNK4g1NzE3MjQ0szC0tTYyUxHkbZz8LFxJITyxJzU5NLUgtgulj4uCUamD0 EXE9cuNnujnXR+s3N8SfWwcL5H66HBv2YmZcsq556iLW4Igmr52B4lJ85mlWEzYxvLHxallY dffSDk2e3k0N1XqMLxPPfXOMyJKsmZwT4HhTvGTNhOIr8i2yp38sr3ieyLs3+Wr31d2M5upT jNNnxwbc+m9i3eO0pyw3lP3tjbs9e1cVflNiKc5INNRiLipOBAALBtMrlgIAAA== X-MTR: 20000000000000000@CPGS X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161210_050652_617563_C5D4135A X-CRM114-Status: GOOD ( 16.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arnd@arndb.de, geert+renesas@glider.be, Pankaj Dubey , krzk@kernel.org, javier@osg.samsung.com, kgene@kernel.org, thomas.ab@samsung.com, m.szyprowski@samsung.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP To remove dependency on soc_is_exynosMMMM macros and remove multiple checks for such macros lets refactor code in pm.c This patch matches SoC specific information via private data of soc_device_attribute and initialize it at one place and then uses it all other places Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/pm.c | 185 ++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 155 insertions(+), 30 deletions(-) diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c index c0b46c3..d43bea8 100644 --- a/arch/arm/mach-exynos/pm.c +++ b/arch/arm/mach-exynos/pm.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include @@ -28,22 +29,49 @@ #include "common.h" +struct exynos_s2r_data { + void __iomem* (*boot_vector_addr)(void); + void __iomem* (*boot_vector_flag)(void); + void (*set_wakeupmask)(void); + void (*enter_aftr)(void); +}; + +static const struct exynos_s2r_data *s2r_data; + +static void __iomem *exynos4210_rev11_boot_vector_addr(void) +{ + return pmu_base_addr + S5P_INFORM7; +} + +static void __iomem *exynos4210_rev10_boot_vector_addr(void) +{ + return sysram_base_addr + 0x24; +} + static inline void __iomem *exynos_boot_vector_addr(void) { - if (samsung_rev() == EXYNOS4210_REV_1_1) - return pmu_base_addr + S5P_INFORM7; - else if (samsung_rev() == EXYNOS4210_REV_1_0) - return sysram_base_addr + 0x24; - return pmu_base_addr + S5P_INFORM0; + if (s2r_data && s2r_data->boot_vector_addr) + return s2r_data->boot_vector_addr(); + else + return pmu_base_addr + S5P_INFORM0; +} + +static void __iomem *exynos4210_rev11_boot_vector_flag(void) +{ + return pmu_base_addr + S5P_INFORM6; +} + +static void __iomem *exynos4210_rev10_boot_vector_flag(void) +{ + return sysram_base_addr + 0x20; } static inline void __iomem *exynos_boot_vector_flag(void) { - if (samsung_rev() == EXYNOS4210_REV_1_1) - return pmu_base_addr + S5P_INFORM6; - else if (samsung_rev() == EXYNOS4210_REV_1_0) - return sysram_base_addr + 0x20; - return pmu_base_addr + S5P_INFORM1; + if (s2r_data && s2r_data->boot_vector_flag) + return s2r_data->boot_vector_flag(); + else + return pmu_base_addr + S5P_INFORM1; } #define S5P_CHECK_AFTR 0xFCBA0D10 @@ -120,12 +148,19 @@ int exynos_pm_central_resume(void) return 0; } +static void exynos3250_set_wakeupmask(void) +{ + pmu_raw_writel(0x40003ffe, S5P_WAKEUP_MASK); + pmu_raw_writel(0x0, S5P_WAKEUP_MASK2); +} + /* Ext-GIC nIRQ/nFIQ is the only wakeup source in AFTR */ -static void exynos_set_wakeupmask(long mask) +static void exynos_set_wakeupmask(void) { - pmu_raw_writel(mask, S5P_WAKEUP_MASK); - if (soc_is_exynos3250()) - pmu_raw_writel(0x0, S5P_WAKEUP_MASK2); + if (s2r_data && s2r_data->set_wakeupmask) + s2r_data->set_wakeupmask(); + else + pmu_raw_writel(0x0000ff3e, S5P_WAKEUP_MASK); } static void exynos_cpu_set_boot_vector(long flags) @@ -139,7 +174,7 @@ static int exynos_aftr_finisher(unsigned long flags) { int ret; - exynos_set_wakeupmask(soc_is_exynos3250() ? 0x40003ffe : 0x0000ff3e); + exynos_set_wakeupmask(); /* Set value of power down register for aftr mode */ exynos_sys_powerdown_conf(SYS_AFTR); @@ -154,23 +189,30 @@ static int exynos_aftr_finisher(unsigned long flags) return 1; } -void exynos_enter_aftr(void) +static void exynos3250_enter_aftr(void) { unsigned int cpuid = smp_processor_id(); cpu_pm_enter(); - if (soc_is_exynos3250()) - exynos_set_boot_flag(cpuid, C2_STATE); + exynos_set_boot_flag(cpuid, C2_STATE); + exynos_pm_central_suspend(); + cpu_suspend(0, exynos_aftr_finisher); + exynos_pm_central_resume(); + exynos_clear_boot_flag(cpuid, C2_STATE); + + cpu_pm_exit(); +} + +void exynos4x12_enter_aftr(void) +{ + cpu_pm_enter(); exynos_pm_central_suspend(); - if (of_machine_is_compatible("samsung,exynos4212") || - of_machine_is_compatible("samsung,exynos4412")) { - /* Setting SEQ_OPTION register */ - pmu_raw_writel(S5P_USE_STANDBY_WFI0 | S5P_USE_STANDBY_WFE0, - S5P_CENTRAL_SEQ_OPTION); - } + /* Setting SEQ_OPTION register */ + pmu_raw_writel(S5P_USE_STANDBY_WFI0 | S5P_USE_STANDBY_WFE0, + S5P_CENTRAL_SEQ_OPTION); cpu_suspend(0, exynos_aftr_finisher); @@ -182,12 +224,95 @@ void exynos_enter_aftr(void) exynos_pm_central_resume(); - if (soc_is_exynos3250()) - exynos_clear_boot_flag(cpuid, C2_STATE); + cpu_pm_exit(); +} + +void exynos_common_enter_aftr(void) +{ + cpu_pm_enter(); + + exynos_pm_central_suspend(); + cpu_suspend(0, exynos_aftr_finisher); + + if (read_cpuid_part() == ARM_CPU_PART_CORTEX_A9) { + exynos_scu_enable(); + if (call_firmware_op(resume) == -ENOSYS) + exynos_cpu_restore_register(); + } + + exynos_pm_central_resume(); cpu_pm_exit(); } +void exynos_enter_aftr(void) +{ + if (s2r_data && s2r_data->enter_aftr) + s2r_data->enter_aftr(); +} + +static const struct exynos_s2r_data exynos_common_s2r_data = { + .enter_aftr = exynos_common_enter_aftr, +}; + +static const struct exynos_s2r_data exynos3250_s2r_data = { + .set_wakeupmask = exynos3250_set_wakeupmask, + .enter_aftr = exynos3250_enter_aftr, +}; + +static const struct exynos_s2r_data exynos4210_rev11_s2r_data = { + .boot_vector_addr = exynos4210_rev11_boot_vector_addr, + .boot_vector_flag = exynos4210_rev11_boot_vector_flag, + .enter_aftr = exynos_common_enter_aftr, +}; + +static const struct exynos_s2r_data exynos4210_rev10_s2r_data = { + .boot_vector_addr = exynos4210_rev10_boot_vector_addr, + .boot_vector_flag = exynos4210_rev10_boot_vector_flag, + .enter_aftr = exynos_common_enter_aftr, +}; + +static const struct exynos_s2r_data exynos4x12_s2r_data = { + .enter_aftr = exynos4x12_enter_aftr, +}; + +static const struct soc_device_attribute exynos_soc_revision[] = { + { .soc_id = "EXYNOS3250", .data = &exynos3250_s2r_data }, + { + .soc_id = "EXYNOS4210", .revision = "11", + .data = &exynos4210_rev11_s2r_data + }, + { + .soc_id = "EXYNOS4210", .revision = "10", + .data = &exynos4210_rev10_s2r_data + }, + { .soc_id = "EXYNOS4212", .data = &exynos4x12_s2r_data }, + { .soc_id = "EXYNOS4412", .data = &exynos4x12_s2r_data }, + { .soc_id = "EXYNOS4415", .data = &exynos_common_s2r_data }, + { .soc_id = "EXYNOS5250", .data = &exynos_common_s2r_data }, + { .soc_id = "EXYNOS5260", .data = &exynos_common_s2r_data }, + { .soc_id = "EXYNOS5410", .data = &exynos_common_s2r_data }, + { .soc_id = "EXYNOS5420", .data = &exynos_common_s2r_data }, + { .soc_id = "EXYNOS5440", .data = &exynos_common_s2r_data }, + { .soc_id = "EXYNOS5800", .data = &exynos_common_s2r_data }, +}; + +int __init exynos_s2r_init(void) +{ + const struct soc_device_attribute *match; + + match = soc_device_match(exynos_soc_revision); + + if (match) + s2r_data = (const struct exynos_s2r_data *) match->data; + + if (!s2r_data) + return -ENODEV; + + return 0; +} +arch_initcall(exynos_s2r_init); + #if defined(CONFIG_SMP) && defined(CONFIG_ARM_EXYNOS_CPUIDLE) static atomic_t cpu1_wakeup = ATOMIC_INIT(0); @@ -253,7 +378,7 @@ static int exynos_cpu0_enter_aftr(void) while (exynos_cpu_power_state(1) != S5P_CORE_LOCAL_PWR_EN) cpu_relax(); - if (soc_is_exynos3250()) { + if (of_machine_is_compatible("samsung,exynos3250")) { while (!pmu_raw_readl(S5P_PMU_SPARE2) && !atomic_read(&cpu1_wakeup)) cpu_relax(); @@ -275,7 +400,7 @@ static int exynos_cpu0_enter_aftr(void) call_firmware_op(cpu_boot, 1); - if (soc_is_exynos3250()) + if (of_machine_is_compatible("samsung,exynos3250")) dsb_sev(); else arch_send_wakeup_ipi_mask(cpumask_of(1)); @@ -287,7 +412,7 @@ static int exynos_cpu0_enter_aftr(void) static int exynos_wfi_finisher(unsigned long flags) { - if (soc_is_exynos3250()) + if (of_machine_is_compatible("samsung,exynos3250")) flush_cache_all(); cpu_do_idle(); @@ -309,7 +434,7 @@ static int exynos_cpu1_powerdown(void) */ exynos_cpu_power_down(1); - if (soc_is_exynos3250()) + if (of_machine_is_compatible("samsung,exynos3250")) pmu_raw_writel(0, S5P_PMU_SPARE2); ret = cpu_suspend(0, exynos_wfi_finisher);