| Message ID | 1481375323-29724-7-git-send-email-pankaj.dubey@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Dec 10, 2016 at 06:38:41PM +0530, Pankaj Dubey wrote: > We are taking care of setting secondary cpu boot address in > exynos_boot_secondary just before sending ipi to secondary CPUs, > so we can safely remove this setting from smp_prepare_cpus. Indeed setting boot address is doubled. However between them, the power is turned on and Exynos3250 is being restarted. It would be nice to test it on Exynos3250 (Artik5 or Gear2?) and some of Exynos4 family. Beside that looks good to me, I just want to see some tested-by. Best regards, Krzysztof > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > --- > arch/arm/mach-exynos/platsmp.c | 25 ------------------------- > 1 file changed, 25 deletions(-) > > diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c > index 43eec10..4de254e 100644 > --- a/arch/arm/mach-exynos/platsmp.c > +++ b/arch/arm/mach-exynos/platsmp.c > @@ -403,8 +403,6 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle) > > static void __init exynos_smp_prepare_cpus(unsigned int max_cpus) > { > - int i; > - > exynos_sysram_init(); > > exynos_set_delayed_reset_assertion(true); > @@ -414,29 +412,6 @@ static void __init exynos_smp_prepare_cpus(unsigned int max_cpus) > if (exynos_scu_enable()) > return; > } > - /* > - * Write the address of secondary startup into the > - * system-wide flags register. The boot monitor waits > - * until it receives a soft interrupt, and then the > - * secondary CPU branches to this address. > - * > - * Try using firmware operation first and fall back to > - * boot register if it fails. > - */ > - for (i = 1; i < max_cpus; ++i) { > - unsigned long boot_addr; > - u32 mpidr; > - u32 core_id; > - int ret; > - > - mpidr = cpu_logical_map(i); > - core_id = MPIDR_AFFINITY_LEVEL(mpidr, 0); > - boot_addr = virt_to_phys(exynos4_secondary_startup); > - > - ret = exynos_set_boot_addr(core_id, boot_addr); > - if (ret) > - break; > - } > } > > #ifdef CONFIG_HOTPLUG_CPU > -- > 2.7.4 >
Hi Krzysztof, 2016-12-18 3:48 GMT+09:00 Krzysztof Kozlowski <krzk@kernel.org>: > On Sat, Dec 10, 2016 at 06:38:41PM +0530, Pankaj Dubey wrote: >> We are taking care of setting secondary cpu boot address in >> exynos_boot_secondary just before sending ipi to secondary CPUs, >> so we can safely remove this setting from smp_prepare_cpus. > > Indeed setting boot address is doubled. However between them, the power > is turned on and Exynos3250 is being restarted. > > It would be nice to test it on Exynos3250 (Artik5 or Gear2?) and some of > Exynos4 family. Beside that looks good to me, I just want to see some > tested-by. I'll test it on Exynos3250(gear2,artik5) and Exynos4(trats2) on Monday and send the test result. Best Regards, Chanwoo Choi [snip]
diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c index 43eec10..4de254e 100644 --- a/arch/arm/mach-exynos/platsmp.c +++ b/arch/arm/mach-exynos/platsmp.c @@ -403,8 +403,6 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle) static void __init exynos_smp_prepare_cpus(unsigned int max_cpus) { - int i; - exynos_sysram_init(); exynos_set_delayed_reset_assertion(true); @@ -414,29 +412,6 @@ static void __init exynos_smp_prepare_cpus(unsigned int max_cpus) if (exynos_scu_enable()) return; } - /* - * Write the address of secondary startup into the - * system-wide flags register. The boot monitor waits - * until it receives a soft interrupt, and then the - * secondary CPU branches to this address. - * - * Try using firmware operation first and fall back to - * boot register if it fails. - */ - for (i = 1; i < max_cpus; ++i) { - unsigned long boot_addr; - u32 mpidr; - u32 core_id; - int ret; - - mpidr = cpu_logical_map(i); - core_id = MPIDR_AFFINITY_LEVEL(mpidr, 0); - boot_addr = virt_to_phys(exynos4_secondary_startup); - - ret = exynos_set_boot_addr(core_id, boot_addr); - if (ret) - break; - } } #ifdef CONFIG_HOTPLUG_CPU
We are taking care of setting secondary cpu boot address in exynos_boot_secondary just before sending ipi to secondary CPUs, so we can safely remove this setting from smp_prepare_cpus. Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> --- arch/arm/mach-exynos/platsmp.c | 25 ------------------------- 1 file changed, 25 deletions(-)