| Message ID | 1482265384-715-4-git-send-email-david@lechnology.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12/20/2016 02:23 PM, David Lechner wrote: > TI DA8xx/OMAPL13x/AM17xx/AM18xx SoCs have extra UART registers beyond Similar comment about adding Keystone SoCs to the list of SoCs. > the standard 8250 registers, so we need a new compatible string to > indicate this. Also, at least one of these registers uses the full 32 > bits, so we need to specify reg-io-width in addition to reg-shift. > > "ns16550a" is left in the compatible specification since it does work > as long as the bootloader configures the SoC UART power management > registers. > > Signed-off-by: David Lechner <david@lechnology.com> > --- > arch/arm/boot/dts/da850.dtsi | 9 ++++++--- Similar changes should be made to the various Keystone dtsi files. > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > index 104155d..f6cd212 100644 > --- a/arch/arm/boot/dts/da850.dtsi > +++ b/arch/arm/boot/dts/da850.dtsi > @@ -266,22 +266,25 @@ > interrupt-names = "edm3_tcerrint"; > }; > serial0: serial@42000 { > - compatible = "ns16550a"; > + compatible = "ti,da830-uart", "ns16550a"; > reg = <0x42000 0x100>; > + reg-io-width = <4>; > reg-shift = <2>; > interrupts = <25>; > status = "disabled"; > }; > serial1: serial@10c000 { > - compatible = "ns16550a"; > + compatible = "ti,da830-uart", "ns16550a"; > reg = <0x10c000 0x100>; > + reg-io-width = <4>; > reg-shift = <2>; > interrupts = <53>; > status = "disabled"; > }; > serial2: serial@10d000 { > - compatible = "ns16550a"; > + compatible = "ti,da830-uart", "ns16550a"; > reg = <0x10d000 0x100>; > + reg-io-width = <4>; > reg-shift = <2>; > interrupts = <61>; > status = "disabled"; >
On Thursday 22 December 2016 09:36 PM, Franklin S Cooper Jr wrote: > > > On 12/20/2016 02:23 PM, David Lechner wrote: >> TI DA8xx/OMAPL13x/AM17xx/AM18xx SoCs have extra UART registers beyond > > Similar comment about adding Keystone SoCs to the list of SoCs. > >> the standard 8250 registers, so we need a new compatible string to >> indicate this. Also, at least one of these registers uses the full 32 >> bits, so we need to specify reg-io-width in addition to reg-shift. >> >> "ns16550a" is left in the compatible specification since it does work >> as long as the bootloader configures the SoC UART power management >> registers. >> >> Signed-off-by: David Lechner <david@lechnology.com> >> --- >> arch/arm/boot/dts/da850.dtsi | 9 ++++++--- > > Similar changes should be made to the various Keystone dtsi files. That will be a different patch though since the two changes will go through different trees. And I strongly suspect David does not have access to a keystone board. So it will have to be done by someone at TI. Thanks, Sekhar
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index 104155d..f6cd212 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi @@ -266,22 +266,25 @@ interrupt-names = "edm3_tcerrint"; }; serial0: serial@42000 { - compatible = "ns16550a"; + compatible = "ti,da830-uart", "ns16550a"; reg = <0x42000 0x100>; + reg-io-width = <4>; reg-shift = <2>; interrupts = <25>; status = "disabled"; }; serial1: serial@10c000 { - compatible = "ns16550a"; + compatible = "ti,da830-uart", "ns16550a"; reg = <0x10c000 0x100>; + reg-io-width = <4>; reg-shift = <2>; interrupts = <53>; status = "disabled"; }; serial2: serial@10d000 { - compatible = "ns16550a"; + compatible = "ti,da830-uart", "ns16550a"; reg = <0x10d000 0x100>; + reg-io-width = <4>; reg-shift = <2>; interrupts = <61>; status = "disabled";
TI DA8xx/OMAPL13x/AM17xx/AM18xx SoCs have extra UART registers beyond the standard 8250 registers, so we need a new compatible string to indicate this. Also, at least one of these registers uses the full 32 bits, so we need to specify reg-io-width in addition to reg-shift. "ns16550a" is left in the compatible specification since it does work as long as the bootloader configures the SoC UART power management registers. Signed-off-by: David Lechner <david@lechnology.com> --- arch/arm/boot/dts/da850.dtsi | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)