From patchwork Mon Jan 2 15:38:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 9493829 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5743B62AB2 for ; Mon, 2 Jan 2017 15:41:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 49E712015F for ; Mon, 2 Jan 2017 15:41:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3DC18267EC; Mon, 2 Jan 2017 15:41:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4771F2015F for ; Mon, 2 Jan 2017 15:41:08 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1cO4hB-0005T6-Nc; Mon, 02 Jan 2017 15:38:45 +0000 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49] helo=osg.samsung.com) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1cO4h4-0005KD-0q for linux-arm-kernel@lists.infradead.org; Mon, 02 Jan 2017 15:38:40 +0000 Received: from localhost (localhost [127.0.0.1]) by osg.samsung.com (Postfix) with ESMTP id 8A12DA1311; Mon, 2 Jan 2017 15:38:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osg.samsung.com Received: from osg.samsung.com ([127.0.0.1]) by localhost (s-opensource.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HSBv7QyOHJxR; Mon, 2 Jan 2017 15:38:29 +0000 (UTC) Received: from minerva.localdomain (unknown [181.121.136.80]) by osg.samsung.com (Postfix) with ESMTPSA id 26831A12FC; Mon, 2 Jan 2017 15:38:26 +0000 (UTC) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Subject: [PATCH] crypto: picoxcell - Fix module autoload for non-OF registration Date: Mon, 2 Jan 2017 12:38:02 -0300 Message-Id: <1483371482-4956-1-git-send-email-javier@osg.samsung.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170102_073838_178347_EC91641F X-CRM114-Status: UNSURE ( 9.53 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Herbert Xu , Javier Martinez Canillas , linux-crypto@vger.kernel.org, Jamie Iles , "David S. Miller" , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module if the device isn't registered via OF. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo drivers/crypto/picoxcell_crypto.ko | grep alias alias: of:N*T*Cpicochip,spacc-l2C* alias: of:N*T*Cpicochip,spacc-l2 alias: of:N*T*Cpicochip,spacc-ipsecC* alias: of:N*T*Cpicochip,spacc-ipsec After this patch: $ modinfo drivers/crypto/picoxcell_crypto.ko | grep alias alias: of:N*T*Cpicochip,spacc-l2C* alias: of:N*T*Cpicochip,spacc-l2 alias: of:N*T*Cpicochip,spacc-ipsecC* alias: of:N*T*Cpicochip,spacc-ipsec alias: platform:picochip,spacc-l2 alias: platform:picochip,spacc-ipsec Signed-off-by: Javier Martinez Canillas --- drivers/crypto/picoxcell_crypto.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/picoxcell_crypto.c b/drivers/crypto/picoxcell_crypto.c index 47576098831f..64449b7c00af 100644 --- a/drivers/crypto/picoxcell_crypto.c +++ b/drivers/crypto/picoxcell_crypto.c @@ -1808,6 +1808,7 @@ static const struct platform_device_id spacc_id_table[] = { { "picochip,spacc-l2", }, { } }; +MODULE_DEVICE_TABLE(platform, spacc_id_table); static struct platform_driver spacc_driver = { .probe = spacc_probe,