| Message ID | 1483430237-26823-5-git-send-email-jcsing.lee@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Jaechul, On 01/03/2017 04:57 AM, Jaechul Lee wrote: > Add DT node support for TM2 touchkey device. > > Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index 887a1f1..ef7d21c 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > @@ -18,3 +18,15 @@ > compatible = "samsung,tm2e", "samsung,exynos5433"; > }; > > +&hsi2c_9 { > + status = "okay"; > + > + touchkey@20 { > + compatible = "samsung,tm2-touchkey"; > + reg = <0x20>; > + interrupt-parent = <&gpa3>; > + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > + vcc-supply = <&ldo32_reg>; > + vdd-supply = <&ldo33_reg>; > + }; > +}; > If you re-spin with the changes suggested by Chanwoo instead of the commont .dtsi, feel free to add: Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
On Tue, Jan 03, 2017 at 04:57:17PM +0900, Jaechul Lee wrote: > Add DT node support for TM2 touchkey device. > > Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > Signed-off-by: Beomho Seo <beomho.seo@samsung.com> > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> The order of sign-offs should follow the order of "who touched it". I assume that the real order was like this: 1. Initially create by Beomho, 2. Adjustments by Andi, 3. Final adjustments and sending by you. If that is correct then the order should be 1->2->3. Beside of that, patch looks good. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts index 887a1f1..ef7d21c 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts @@ -18,3 +18,15 @@ compatible = "samsung,tm2e", "samsung,exynos5433"; }; +&hsi2c_9 { + status = "okay"; + + touchkey@20 { + compatible = "samsung,tm2-touchkey"; + reg = <0x20>; + interrupt-parent = <&gpa3>; + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; + vcc-supply = <&ldo32_reg>; + vdd-supply = <&ldo33_reg>; + }; +};