diff mbox

[3/8] Documentation: dt-bindings: Add STM32 pinctrl driver DT bindings

Message ID 1485868465-30446-4-git-send-email-alexandre.torgue@st.com (mailing list archive)
State New, archived
Headers show

Commit Message

Alexandre TORGUE Jan. 31, 2017, 1:14 p.m. UTC 
Add compatible sting for stm32h743 MCU.

Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>

Comments

Rob Herring (Arm) Feb. 1, 2017, 5:31 p.m. UTC | #1 
On Tue, Jan 31, 2017 at 02:14:20PM +0100, Alexandre TORGUE wrote:
> Add compatible sting for stm32h743 MCU.
> 
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> index b24583a..ac8dcb7 100644
> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> @@ -10,6 +10,7 @@ Required properies:
>   - compatible: value should be one of the following:
>     (a) "st,stm32f429-pinctrl"
>     (b) "st,stm32f746-pinctrl"
> +   (c) "st,stm32h743-pinctrl"

Drop the a,b,c.

>   - #address-cells: The value of this property must be 1
>   - #size-cells	: The value of this property must be 1
>   - ranges	: defines mapping between pin controller node (parent) to
> -- 
> 1.9.1
>
Rob Herring (Arm) Feb. 1, 2017, 5:33 p.m. UTC | #2 
On Tue, Jan 31, 2017 at 02:14:20PM +0100, Alexandre TORGUE wrote:
> Add compatible sting for stm32h743 MCU.

Also, you can drop "Documentation: " from the subject as it is 
redundant.

> 
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> index b24583a..ac8dcb7 100644
> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> @@ -10,6 +10,7 @@ Required properies:
>   - compatible: value should be one of the following:
>     (a) "st,stm32f429-pinctrl"
>     (b) "st,stm32f746-pinctrl"
> +   (c) "st,stm32h743-pinctrl"
>   - #address-cells: The value of this property must be 1
>   - #size-cells	: The value of this property must be 1
>   - ranges	: defines mapping between pin controller node (parent) to
> -- 
> 1.9.1
>
Linus Walleij Feb. 6, 2017, 8:43 a.m. UTC | #3 
On Tue, Jan 31, 2017 at 2:14 PM, Alexandre TORGUE
<alexandre.torgue@st.com> wrote:

> Add compatible sting for stm32h743 MCU.
>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>

Patch applied, incorporating the changes suggested by Rob,
amending subject and dropping (a,b,c).

Yours,
Linus Walleij
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
index b24583a..ac8dcb7 100644
--- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
@@ -10,6 +10,7 @@  Required properies:
  - compatible: value should be one of the following:
    (a) "st,stm32f429-pinctrl"
    (b) "st,stm32f746-pinctrl"
+   (c) "st,stm32h743-pinctrl"
  - #address-cells: The value of this property must be 1
  - #size-cells	: The value of this property must be 1
  - ranges	: defines mapping between pin controller node (parent) to