| Message ID | 1485967306-30589-1-git-send-email-fabrice.gasnier@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2017-02-01 17:41 GMT+01:00 Fabrice Gasnier <fabrice.gasnier@st.com>: > Add missing of_platform_depopulate() upon driver removal. > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> > --- > drivers/mfd/stm32-timers.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c > index 41bd901..192cbb6 100644 > --- a/drivers/mfd/stm32-timers.c > +++ b/drivers/mfd/stm32-timers.c > @@ -61,6 +61,13 @@ static int stm32_timers_probe(struct platform_device *pdev) > return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); > } > > +static int stm32_timers_remove(struct platform_device *pdev) > +{ > + of_platform_depopulate(&pdev->dev); > + > + return 0; > +} > + > static const struct of_device_id stm32_timers_of_match[] = { > { .compatible = "st,stm32-timers", }, > { /* end node */ }, > @@ -69,6 +76,7 @@ static int stm32_timers_probe(struct platform_device *pdev) > > static struct platform_driver stm32_timers_driver = { > .probe = stm32_timers_probe, > + .remove = stm32_timers_remove, > .driver = { > .name = "stm32-timers", > .of_match_table = stm32_timers_of_match, > -- > 1.9.1 > Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
On Wed, 01 Feb 2017, Fabrice Gasnier wrote: > Add missing of_platform_depopulate() upon driver removal. > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> > --- > drivers/mfd/stm32-timers.c | 8 ++++++++ > 1 file changed, 8 insertions(+) Applied, thanks. > diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c > index 41bd901..192cbb6 100644 > --- a/drivers/mfd/stm32-timers.c > +++ b/drivers/mfd/stm32-timers.c > @@ -61,6 +61,13 @@ static int stm32_timers_probe(struct platform_device *pdev) > return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); > } > > +static int stm32_timers_remove(struct platform_device *pdev) > +{ > + of_platform_depopulate(&pdev->dev); > + > + return 0; > +} > + > static const struct of_device_id stm32_timers_of_match[] = { > { .compatible = "st,stm32-timers", }, > { /* end node */ }, > @@ -69,6 +76,7 @@ static int stm32_timers_probe(struct platform_device *pdev) > > static struct platform_driver stm32_timers_driver = { > .probe = stm32_timers_probe, > + .remove = stm32_timers_remove, > .driver = { > .name = "stm32-timers", > .of_match_table = stm32_timers_of_match,
diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c index 41bd901..192cbb6 100644 --- a/drivers/mfd/stm32-timers.c +++ b/drivers/mfd/stm32-timers.c @@ -61,6 +61,13 @@ static int stm32_timers_probe(struct platform_device *pdev) return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); } +static int stm32_timers_remove(struct platform_device *pdev) +{ + of_platform_depopulate(&pdev->dev); + + return 0; +} + static const struct of_device_id stm32_timers_of_match[] = { { .compatible = "st,stm32-timers", }, { /* end node */ }, @@ -69,6 +76,7 @@ static int stm32_timers_probe(struct platform_device *pdev) static struct platform_driver stm32_timers_driver = { .probe = stm32_timers_probe, + .remove = stm32_timers_remove, .driver = { .name = "stm32-timers", .of_match_table = stm32_timers_of_match,
Add missing of_platform_depopulate() upon driver removal. Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> --- drivers/mfd/stm32-timers.c | 8 ++++++++ 1 file changed, 8 insertions(+)