| Message ID | 1487364137-3008-1-git-send-email-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Ansuel, On Fri, Feb 17, 2017 at 09:42:17PM +0100, Ansuel Smith wrote: > In others board we have the sata led set to funcion with the sata led trigger by default. > This patch makes the same for these board that have sata led but disabled by not associating it to any trigger Please line wrap the commit message. Other than that, > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> Acked-by: Jason Cooper <jason@lakedaemon.net> thx, Jason. > --- > arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 + > arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 + > arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-385-linksys-caiman.dts b/arch/arm/boot/dts/armada-385-linksys-caiman.dts > index f3cee91..a1b6e68 100644 > --- a/arch/arm/boot/dts/armada-385-linksys-caiman.dts > +++ b/arch/arm/boot/dts/armada-385-linksys-caiman.dts > @@ -109,6 +109,7 @@ > > sata { > label = "caiman:white:sata"; > + linux,default-trigger = "disk-activity"; > }; > }; > }; > diff --git a/arch/arm/boot/dts/armada-385-linksys-cobra.dts b/arch/arm/boot/dts/armada-385-linksys-cobra.dts > index 1110718..a1a75af 100644 > --- a/arch/arm/boot/dts/armada-385-linksys-cobra.dts > +++ b/arch/arm/boot/dts/armada-385-linksys-cobra.dts > @@ -109,6 +109,7 @@ > > sata { > label = "cobra:white:sata"; > + linux,default-trigger = "disk-activity"; > }; > }; > }; > diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts > index 83ac884..dcd73ab 100644 > --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts > +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts > @@ -156,6 +156,7 @@ > esata@4 { > label = "mamba:white:esata"; > reg = <0x4>; > + linux,default-trigger = "disk-activity"; > }; > > usb2@5 { > -- > 1.9.1 >
Hi, Am 18.02.2017 um 15:12 schrieb Jason Cooper: > On Fri, Feb 17, 2017 at 09:42:17PM +0100, Ansuel Smith wrote: >> In others board we have the sata led set to funcion with the sata led trigger by default. >> This patch makes the same for these board that have sata led but disabled by not associating it to any trigger > > Please line wrap the commit message. The subject could also use some love, like mentioning "ARM:" and "armada" and dropping "Board". Compare git log --oneline. Regards, Andreas > Other than that, > >> >> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > > Acked-by: Jason Cooper <jason@lakedaemon.net> > > thx, > > Jason. > >> --- >> arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 + >> arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 + >> arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 + >> 3 files changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/armada-385-linksys-caiman.dts b/arch/arm/boot/dts/armada-385-linksys-caiman.dts index f3cee91..a1b6e68 100644 --- a/arch/arm/boot/dts/armada-385-linksys-caiman.dts +++ b/arch/arm/boot/dts/armada-385-linksys-caiman.dts @@ -109,6 +109,7 @@ sata { label = "caiman:white:sata"; + linux,default-trigger = "disk-activity"; }; }; }; diff --git a/arch/arm/boot/dts/armada-385-linksys-cobra.dts b/arch/arm/boot/dts/armada-385-linksys-cobra.dts index 1110718..a1a75af 100644 --- a/arch/arm/boot/dts/armada-385-linksys-cobra.dts +++ b/arch/arm/boot/dts/armada-385-linksys-cobra.dts @@ -109,6 +109,7 @@ sata { label = "cobra:white:sata"; + linux,default-trigger = "disk-activity"; }; }; }; diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts index 83ac884..dcd73ab 100644 --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts @@ -156,6 +156,7 @@ esata@4 { label = "mamba:white:esata"; reg = <0x4>; + linux,default-trigger = "disk-activity"; }; usb2@5 {
In others board we have the sata led set to funcion with the sata led trigger by default. This patch makes the same for these board that have sata led but disabled by not associating it to any trigger Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> --- arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 + arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 + arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 + 3 files changed, 3 insertions(+)