From patchwork Mon Feb 20 17:22:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ben Hutchings X-Patchwork-Id: 9583401 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 02B376047C for ; Mon, 20 Feb 2017 17:35:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 09B852844E for ; Mon, 20 Feb 2017 17:35:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F299628549; Mon, 20 Feb 2017 17:35:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 923EB2844E for ; Mon, 20 Feb 2017 17:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Mime-Version:References:In-Reply-To:Date:To:From:Subject:Message-ID:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/URIeIUgzwI1bAtxWO4EYpJmPYgP/wYVjCNc2/Xk6pQ=; b=q/2J1Ca5UPJASeFFm3kz+Gwfw E9k2uTyPOEYY86fBjLAJyzG7QCVLH2iGf6ZdBLmrxhoBbplgE9ZKrT0/n3mvbkz5M1BhgrS/ce5X3 y1XGaFiABBfVwqm9lfr3m9cE61BPPgiGM56PVli30N5qbheteH/URTXqedcM3qGSLpHKwF9Ha6yQD VKxi7rxonTGB39zgbzUHzMYO+1zoCVvI/Ms/9JnFfb/AhGDt66x05sILh+ujvdsH12O0x8PszD3Vn GFrc13WK1SBh9jLuZLinXWyxieMnc4uv0GUiTPNKtqDx6oE/Gq5DDKp0CaAuNyj8j2Z5U4WDPUGZp 91Rz9gQYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cfrrp-0006f1-3C; Mon, 20 Feb 2017 17:35:17 +0000 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cfrg1-0003Fz-Co for linux-arm-kernel@lists.infradead.org; Mon, 20 Feb 2017 17:23:19 +0000 Received: from [2a02:8011:400e:2:6f00:88c8:c921:d332] (helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cfrff-0008Ka-MT; Mon, 20 Feb 2017 17:22:43 +0000 Received: from ben by deadeye with local (Exim 4.89) (envelope-from ) id 1cfrff-0004M2-C7; Mon, 20 Feb 2017 17:22:43 +0000 Message-ID: <1487611358.2885.3.camel@decadent.org.uk> Subject: Re: [PATCH] ARM: dts: kirkwood: Fix SATA pinmux-ing for TS419 From: Ben Hutchings To: Thomas Petazzoni Date: Mon, 20 Feb 2017 17:22:38 +0000 In-Reply-To: <20170220175049.45f319bb@free-electrons.com> References: <20170218003251.GC4152@decadent.org.uk> <20170220135955.63fbcaa3@free-electrons.com> <1487608825.2885.1.camel@decadent.org.uk> <20170220175049.45f319bb@free-electrons.com> X-Mailer: Evolution 3.22.4-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170220_092305_769073_0D9A3DA5 X-CRM114-Status: UNSURE ( 8.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Jason Cooper , gmbh@gazeta.pl, =?ISO-8859-1?Q?Gr=E9gory?= Clement , 855017@bugs.debian.org, linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 2017-02-20 at 17:50 +0100, Thomas Petazzoni wrote: > Hello, > > On Mon, 20 Feb 2017 16:40:25 +0000, Ben Hutchings wrote: > > > That is precisely what I intended.  20-23 are used by the second > > Ethernet port.  The old board code doesn't assign 4 or 5 at all. > > Then I believe it would be more explicit to have separate pin muxing > configurations for SATA on this board. You mean, define additional pinmux nodes and override the pinctrl-0 property of &sata? More like this: Ben. --- a/arch/arm/boot/dts/kirkwood-ts419.dtsi +++ b/arch/arm/boot/dts/kirkwood-ts419.dtsi @@ -73,3 +73,19 @@ phy-handle = <ðphy1>; }; }; + +&pinctrl { + pmx_sata0_ts419: pmx-sata0-ts419 { + marvell,pins = "mpp15"; + marvell,function = "sata0"; + }; + + pmx_sata1_ts419: pmx-sata1-ts419 { + marvell,pins = "mpp16"; + marvell,function = "sata1"; + }; +}; + +&sata { + pinctrl-0 = <&pmx_sata0_ts419 &pmx_sata1_ts419>; +}; --- END ---