| Message ID | 1487838778-13473-1-git-send-email-claudiu.beznea@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, There is a typo in your subject, please fix. On 23/02/2017 at 10:32:58 +0200, Claudiu Beznea wrote: > Add pwm controller bindings for sam5d2_xplained > and enable it. > > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi | 4 ++++ > arch/arm/boot/dts/sama5d2.dtsi | 8 ++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi > index 9fc270f..493ea29 100644 > --- a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi > +++ b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi > @@ -318,6 +318,10 @@ > }; > }; > > + pwm0: pwm@f802c000 { > + status = "okay"; > + }; > + > flx0: flexcom@f8034000 { > atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>; > status = "disabled"; /* conflict with ISC_D2 & ISC_D3 data pins */ > diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi > index cd459e8..e88785e 100644 > --- a/arch/arm/boot/dts/sama5d2.dtsi > +++ b/arch/arm/boot/dts/sama5d2.dtsi > @@ -1098,6 +1098,14 @@ > status = "disabled"; > }; > > + pwm0: pwm@f802c000 { > + compatible = "atmel,sama5d2-pwm"; This compatible is not documented and is not used in any driver. Is that really working? > + reg = <0xf802c000 0x4000>; > + interrupts = <38 IRQ_TYPE_LEVEL_HIGH 7>; > + #pwm-cells = <3>; > + clocks = <&pwm_clk>; > + }; > + > sfr: sfr@f8030000 { > compatible = "atmel,sama5d2-sfr", "syscon"; > reg = <0xf8030000 0x98>; > -- > 2.7.4 >
Hi, I will correct it asap. Thank you, Claudiu Beznea On 23.02.2017 10:42, Alexandre Belloni wrote: > Hi, > > There is a typo in your subject, please fix. > > On 23/02/2017 at 10:32:58 +0200, Claudiu Beznea wrote: >> Add pwm controller bindings for sam5d2_xplained >> and enable it. >> >> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> >> --- >> arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi | 4 ++++ >> arch/arm/boot/dts/sama5d2.dtsi | 8 ++++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi >> index 9fc270f..493ea29 100644 >> --- a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi >> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi >> @@ -318,6 +318,10 @@ >> }; >> }; >> >> + pwm0: pwm@f802c000 { >> + status = "okay"; >> + }; >> + >> flx0: flexcom@f8034000 { >> atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>; >> status = "disabled"; /* conflict with ISC_D2 & ISC_D3 data pins */ >> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi >> index cd459e8..e88785e 100644 >> --- a/arch/arm/boot/dts/sama5d2.dtsi >> +++ b/arch/arm/boot/dts/sama5d2.dtsi >> @@ -1098,6 +1098,14 @@ >> status = "disabled"; >> }; >> >> + pwm0: pwm@f802c000 { >> + compatible = "atmel,sama5d2-pwm"; > This compatible is not documented and is not used in any driver. Is that > really working? > >> + reg = <0xf802c000 0x4000>; >> + interrupts = <38 IRQ_TYPE_LEVEL_HIGH 7>; >> + #pwm-cells = <3>; >> + clocks = <&pwm_clk>; >> + }; >> + >> sfr: sfr@f8030000 { >> compatible = "atmel,sama5d2-sfr", "syscon"; >> reg = <0xf8030000 0x98>; >> -- >> 2.7.4 >>
Hi Alexandre, Sorry for the late response, I am seeing just now your question bellow. Thank you, Claudiu Beznea On 23.02.2017 10:42, Alexandre Belloni wrote: > Hi, > > There is a typo in your subject, please fix. > > On 23/02/2017 at 10:32:58 +0200, Claudiu Beznea wrote: >> Add pwm controller bindings for sam5d2_xplained >> and enable it. >> >> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> >> --- >> arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi | 4 ++++ >> arch/arm/boot/dts/sama5d2.dtsi | 8 ++++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi >> index 9fc270f..493ea29 100644 >> --- a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi >> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi >> @@ -318,6 +318,10 @@ >> }; >> }; >> >> + pwm0: pwm@f802c000 { >> + status = "okay"; >> + }; >> + >> flx0: flexcom@f8034000 { >> atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>; >> status = "disabled"; /* conflict with ISC_D2 & ISC_D3 data pins */ >> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi >> index cd459e8..e88785e 100644 >> --- a/arch/arm/boot/dts/sama5d2.dtsi >> +++ b/arch/arm/boot/dts/sama5d2.dtsi >> @@ -1098,6 +1098,14 @@ >> status = "disabled"; >> }; >> >> + pwm0: pwm@f802c000 { >> + compatible = "atmel,sama5d2-pwm"; > This compatible is not documented and is not used in any driver. Is that > really working? At the moment I send this patch another driver patch was send to used this device tree bindings and also to document it. Meanwhile you reviewed also that other patch. Please let me know if you want to send again this DT patch since I didn't yet receive any inputs its v2. > >> + reg = <0xf802c000 0x4000>; >> + interrupts = <38 IRQ_TYPE_LEVEL_HIGH 7>; >> + #pwm-cells = <3>; >> + clocks = <&pwm_clk>; >> + }; >> + >> sfr: sfr@f8030000 { >> compatible = "atmel,sama5d2-sfr", "syscon"; >> reg = <0xf8030000 0x98>; >> -- >> 2.7.4 >>
Hi, On 28/03/2017 at 14:04:25 +0300, m18063 wrote: > >> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi > >> index cd459e8..e88785e 100644 > >> --- a/arch/arm/boot/dts/sama5d2.dtsi > >> +++ b/arch/arm/boot/dts/sama5d2.dtsi > >> @@ -1098,6 +1098,14 @@ > >> status = "disabled"; > >> }; > >> > >> + pwm0: pwm@f802c000 { > >> + compatible = "atmel,sama5d2-pwm"; > > This compatible is not documented and is not used in any driver. Is that > > really working? > > At the moment I send this patch another driver patch was send > to used this device tree bindings and also to document it. > Meanwhile you reviewed also that other patch. > Yes, I received that patch first, without the other ones. You should have put everything in the same series. > Please let me know if you want to send again this DT patch since > I didn't yet receive any inputs its v2. > I'll take it once the pwm patch are taken by Thierry because it is not useful as-is, unless you use: compatible = "atmel,sama5d2-pwm", "atmel,sama5d3-pwm";
diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi index 9fc270f..493ea29 100644 --- a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi +++ b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi @@ -318,6 +318,10 @@ }; }; + pwm0: pwm@f802c000 { + status = "okay"; + }; + flx0: flexcom@f8034000 { atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>; status = "disabled"; /* conflict with ISC_D2 & ISC_D3 data pins */ diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi index cd459e8..e88785e 100644 --- a/arch/arm/boot/dts/sama5d2.dtsi +++ b/arch/arm/boot/dts/sama5d2.dtsi @@ -1098,6 +1098,14 @@ status = "disabled"; }; + pwm0: pwm@f802c000 { + compatible = "atmel,sama5d2-pwm"; + reg = <0xf802c000 0x4000>; + interrupts = <38 IRQ_TYPE_LEVEL_HIGH 7>; + #pwm-cells = <3>; + clocks = <&pwm_clk>; + }; + sfr: sfr@f8030000 { compatible = "atmel,sama5d2-sfr", "syscon"; reg = <0xf8030000 0x98>;
Add pwm controller bindings for sam5d2_xplained and enable it. Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> --- arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi | 4 ++++ arch/arm/boot/dts/sama5d2.dtsi | 8 ++++++++ 2 files changed, 12 insertions(+)