diff mbox

[v2,for,4.11] tty: acpi/spcr: QDF2400 E44 checks for wrong OEM revision

Message ID 1488313833-12430-1-git-send-email-timur@codeaurora.org (mailing list archive)
State New, archived
Headers show

Commit Message

Timur Tabi Feb. 28, 2017, 8:30 p.m. UTC
For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44,
the ACPI oem_revision field is actually set to 1, not 0.

Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")

Tested-by: Manoj Iyer <manoj.iyer@canonical.com>
Signed-off-by: Timur Tabi <timur@codeaurora.org>
---
 drivers/acpi/spcr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Timur Tabi March 13, 2017, 4:19 a.m. UTC | #1
On Tue, Feb 28, 2017 at 2:30 PM, Timur Tabi <timur@codeaurora.org> wrote:
> For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44,
> the ACPI oem_revision field is actually set to 1, not 0.
>
> Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
>
> Tested-by: Manoj Iyer <manoj.iyer@canonical.com>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>

Greg, this is a critical fix for our platform.  Can you please pick it
up for 4.11-rc3?  Thank you.
Timur Tabi March 22, 2017, 3:13 p.m. UTC | #2
On Sun, Mar 12, 2017 at 11:19 PM, Timur Tabi <timur@codeaurora.org> wrote:
> On Tue, Feb 28, 2017 at 2:30 PM, Timur Tabi <timur@codeaurora.org> wrote:
>> For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44,
>> the ACPI oem_revision field is actually set to 1, not 0.
>>
>> Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
>>
>> Tested-by: Manoj Iyer <manoj.iyer@canonical.com>
>> Signed-off-by: Timur Tabi <timur@codeaurora.org>
>
> Greg, this is a critical fix for our platform.  Can you please pick it
> up for 4.11-rc3?  Thank you.

Ok, how about 4.11-rc4?
Greg KH March 22, 2017, 3:45 p.m. UTC | #3
On Wed, Mar 22, 2017 at 10:13:00AM -0500, Timur Tabi wrote:
> On Sun, Mar 12, 2017 at 11:19 PM, Timur Tabi <timur@codeaurora.org> wrote:
> > On Tue, Feb 28, 2017 at 2:30 PM, Timur Tabi <timur@codeaurora.org> wrote:
> >> For Qualcomm Technologies QDF2400 SOCs that are affected by erratum E44,
> >> the ACPI oem_revision field is actually set to 1, not 0.
> >>
> >> Fixes: d8a4995bcea1 ("tty: pl011: Work around QDF2400 E44 stuck BUSY bit")
> >>
> >> Tested-by: Manoj Iyer <manoj.iyer@canonical.com>
> >> Signed-off-by: Timur Tabi <timur@codeaurora.org>
> >
> > Greg, this is a critical fix for our platform.  Can you please pick it
> > up for 4.11-rc3?  Thank you.
> 
> Ok, how about 4.11-rc4?

It's in the queue in tty-linus, right?  If so, that should make it into
4.11-final.

thanks,

greg k-h
diff mbox

Patch

diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
index 2b5d0fa..2051a8c 100644
--- a/drivers/acpi/spcr.c
+++ b/drivers/acpi/spcr.c
@@ -30,7 +30,7 @@  static bool qdf2400_erratum_44_present(struct acpi_table_header *h)
 		return true;
 
 	if (!memcmp(h->oem_table_id, "QDF2400 ", ACPI_OEM_TABLE_ID_SIZE) &&
-			h->oem_revision == 0)
+			h->oem_revision == 1)
 		return true;
 
 	return false;