From patchwork Mon Mar 20 06:15:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 9632577 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 669FB6020B for ; Sun, 19 Mar 2017 14:20:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 55E8B284D1 for ; Sun, 19 Mar 2017 14:20:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 468A4284D5; Sun, 19 Mar 2017 14:20:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DATE_IN_FUTURE_12_24, DKIM_SIGNED, DKIM_VALID autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5022126224 for ; Sun, 19 Mar 2017 14:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/vi8OuonlhaMulbv2hrp5yr50I7TA+24lhpnySM8zOA=; b=eOFuqTt7aD4tT/ pifiRVH8Qwwsd6s5Jb0g0ypYIKpkRKBj6m3uJqdiS4KntfPxxlogi6RXKwmRz+fz55BKWeJwdhQcX iL4A5PGWG8520GOH0cBVuq4x8V3YtHKIh+8QzQw9kCMPQicis0kgjq9onOL2evO8azRT013KCV3no MF0wDw1q/rQp/u5sMVhe/V8WXzPKn6Rk9ty+hwC1Mxr/VC6O+1hZEz7QizRxziNTuOQDMKTmUTqpB qyfCjrikAqVC8x7ACuSxUP7DJ+aD9DlJgpW6t4m1ZjPJp752L/LhIGLZvogibBfO/Lz+FH4z7hJfU UJZ9jyND4shhlglOlDEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cpbgg-0004WY-5G; Sun, 19 Mar 2017 14:20:02 +0000 Received: from mail-co1nam03on0081.outbound.protection.outlook.com ([104.47.40.81] helo=NAM03-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cpbgD-0003vf-8r for linux-arm-kernel@lists.infradead.org; Sun, 19 Mar 2017 14:19:35 +0000 Received: from CY4PR03CA0024.namprd03.prod.outlook.com (10.168.162.34) by DM5PR03MB2794.namprd03.prod.outlook.com (10.168.198.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Sun, 19 Mar 2017 14:19:11 +0000 Received: from BL2FFO11OLC003.protection.gbl (2a01:111:f400:7c09::188) by CY4PR03CA0024.outlook.office365.com (2603:10b6:903:33::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.977.11 via Frontend Transport; Sun, 19 Mar 2017 14:19:11 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; gmail.com; dkim=none (message not signed) header.d=none; gmail.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11OLC003.mail.protection.outlook.com (10.173.161.187) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.977.7 via Frontend Transport; Sun, 19 Mar 2017 14:19:10 +0000 Received: from b29396-OptiPlex-7040.ap.freescale.net (b29396-OptiPlex-7040.ap.freescale.net [10.192.242.182]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v2JEJ18g024445; Sun, 19 Mar 2017 07:19:08 -0700 From: Dong Aisheng To: Subject: [PATCH 2/8] soc: imx: gpc: fix the wrong using of regmap cache Date: Mon, 20 Mar 2017 14:15:41 +0800 Message-ID: <1489990547-1510-3-git-send-email-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1489990547-1510-1-git-send-email-aisheng.dong@nxp.com> References: <1489990547-1510-1-git-send-email-aisheng.dong@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131344067510154381; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39850400002)(39380400002)(39400400002)(39450400003)(39840400002)(39860400002)(39410400002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(9170700003)(105606002)(8676002)(36756003)(77096006)(2351001)(53936002)(8936002)(6666003)(6916009)(2950100002)(50226002)(106466001)(110136004)(38730400002)(39060400002)(5003940100001)(47776003)(48376002)(50466002)(81166006)(189998001)(4326008)(8656002)(33646002)(54906002)(305945005)(356003)(104016004)(50986999)(2906002)(76176999)(5660300001)(85426001)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2794; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC003; 1:QzZ+vdvC+PGFw49mO/Fe8SkNToagFvcM64/vmdHs7un35dPvGiR8tpUWkqGPSFA4EDl/YESVKop4zrV1PAd5tJBt7TewBOUbLUx/O4jEwWQBsdH7cTst5/KJ42QKAFsmYBW1pYSCSPLDRm09tCQurbLUFrpf52XgQDL3UkFbS3w9Y1f/zyoHxyPxCbjYAW8AQjbeDhKHIWG77MAM+wc0NtMcmOO+2nuk312PiVtq9E68XalS+gh8EqhT2oVeXwGF7xHPQpFGIL1bj0EXm25JG2tPCGenSkPn/Wz4pHMt2K5TTOKno1kJPkL1XPcjFjrodIBJB2n/3hEyGYdcJnvZkF/TEs+jhfD4nSlPQgYYZA2Z3I8CotpYKPV9LBr328t1k3vofVBbl/PDQDXdhv5dzuD+764h9SW/oz0X1jZeIEAgDJ8GbGCrj19oxfLvM9LNbnpp8srcKSC/lR1zQ3iBhbmIBjD7EPdzA7JhZA2hOuut7+sn2FoFPLymWJ+rUKNNG1GKmEI99pEP0kiw3XAbcdbShFMLbgOyV+d/oYFWaVx0UnV8GqvemXzmrLP3f7hx/eHrkoeQXdlPTp53Bg7E4v9q5Ri7Dp5zu9V2mtOK6LE= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: c31b2398-588d-497f-d32e-08d46ed2e9c0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:DM5PR03MB2794; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2794; 3:ZLDbYmBZsIQYu/MWHTEotbkJiH8C12qIbj/dzZGuPLDzj9eekbAxw1VXdVhCxd3U5A4cC4zHD0wPWFWtwY47X+aJd7PvsK3m2/2hmXwVNv8A68mX4Ujl9AoZUEkx9y6YJ+3r2S/2viMtWAntZqX7Ztp2RW2KM4zT3GIQl5NpwTVcciB4NEhfl2nzXj+rZRajub5DxISfqPl6ZsR9+vvhSo5T/2s2LBwO7kQWBCs6cDqmtM4FGWpMU8t2tfRrpgi97ddfqskRj4T4pTlbudHrt/wDgnfgn7YeK5QGBMNUSnDubtEoTHhJzUlX/1UocJwmb5wpw8L/Dfuw8VoT3gCYdkHqHx30YTgptwQm52u6OlHEotrfTs4sJqVO8XEkwlUJ; 25:HF2NvIyc9qaSHQaWdVU92Rgtt8Boe9m7x96p1anWt2n76Hd5ww+zt72CmyjOARkUSXRPXFIQzQYrLWPxTojrSaGF1dYcjLfxPE2OSOmjLDzLwLUQLWGEUN7JLmUPLBPTn8qDmuYcZPCN9JAr7tXbQcauH4BiWJzHvVZeoGARoOKT3K72A4WZClFOsh2Q2YS/I6Rqpx7Nm6a+usAvBPxmnOF6kp8I55e5x7d//kykuhoRq0VRbwQ5s7KOUta4VeNjgw4VmzN8bpgxmR9Vqnmc0wj0KHnTYAddQUycHBTIw3GQvC7CisG5q4aPrHCo0OfSppzp7mxShqjTobaFdzTReedECovTkvILcWG0CjSbvaGCsrWPebMwvSgm8vJ3QVXRzjN8bDU3XifpYyyeMAv9kifmKfpSfEr9iKCIiVclQgubfStQZjNkU/GbMNjGHRSw8oSrjNPMCfu5O3UB9xTaSQ== X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2794; 31:cbGbgTPxVOkKN5Z2KhzCL4LI4qfkXu9LWlYerBonEe9Nkmrur+6zszV5WhSiuWboSZmOib07WWzLyNrDR+G/atECWd4jrmdJ9UTNDEB0u2r8y3gwJro2KC4VQg+bN9H/uZb+Ew16q07K4kGtY5cydm2xD8qtDgfHGXrxqaoRR75AyxHJW3yG9TqTx2nj23SRcjv4R7BSOZW/jTt1kSb8uNHOgAGlWpYzmc9SXjZg2XewOPAKL7eqko2D86XBcIEVI6tZxLJUL30/G2iReMxaMxaRMgNiueh+ipn2pUAy38w= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13015025)(8121501046)(13017025)(13018025)(13023025)(5005006)(13024025)(10201501046)(3002001)(6055026)(6096035)(20161123561025)(20161123565025)(20161123563025)(20161123559025)(20161123556025); SRVR:DM5PR03MB2794; BCL:0; PCL:0; RULEID:(400006); SRVR:DM5PR03MB2794; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2794; 4:xbMKXVVBud+BEtJp4wsDh5der6fMkA9hwhvNstLgnJooCrJBD3aiao7EEqxb6nVEZQ5+oEOmTJVWfRVvyRYhRp4PNoz6x/M5grg7ZKDd+TJe8eziH5KSqC4Ak5jb1Z/pgUxEkTmEqOKXf3sKPv7nLYVLIPePoqsh3Z0WL/jIEHaaDB4oyuzMdhYKkdk2tMDSDXu6tE3m9UZSosTs5s4qCtvhUW0EZxxDpVeJskHHgxVJwGZkVAhLQmN22IaM+w5HK88umGTmEEXC+lLbWZxossByeQ4lWLm0JHoQD6TH7kfg3PH34ZcMMLxlBHTuO7OjS1fROppCG5EpKXPBaxUvgqHI+OSpMipAKHNHRllxCaBH99+eZQ+wwzcSrYqxOkKEPHpKiDJfVbdJBok+gAmHAfM/o/82ZqgVbGF8NXvtdcHuzk4/BwGetVJ+4W9DjI47m2aGD9OqwOBYwlg8SnmJcm+lxAjolOULSJ1acMftSc0Jj+UUSdFUu1mERMBCwULUB8NsesWkqHVGiqPrZngT6n2fGyOv9JYcH7rSb2/d0qR0K9C+wxFS6FoN4g2T5Gm5VatE+dB1av/DQIRpcEzGt+8O0KO+uxj8ciz6Plw2PiZn4GWflGhOyMls636UQsjH+6Xsqmk59NaPRTOmpM6PWIqsHuS5MGGhZH2KKA7yR9NPLlzdcZ3O9k7luR2vfxXZFnnZP+RoTXvyOI/q4QPxK33IKe3zdzcyWPjZjhL57cL/V0Kt7EMeb1Kj/DWLtP9L X-Forefront-PRVS: 025100C802 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR03MB2794; 23:ZSYwWLyncc8Rhb0w3hDvvmu/0GI40KnzTq1KsyBNX?= =?us-ascii?Q?ojRnvqqJR4lUU7TnsTtLWo11BRp3eugzZt1QClTLLCptdi/+ujlrw+csvgwy?= =?us-ascii?Q?aYKRJwrJfAGtvGXrbu2oyp6JEKVuIcajnyc2beGAGLK9paaumtlrTsZgm2SA?= =?us-ascii?Q?GlA6t+fAwprefst65TRdpnOba9xU8Hhcpt3mYENvmHJU7PzFgd5/gcah+NKA?= =?us-ascii?Q?6E8MZBkAAsuapRoTVjMO+iL3lDGt+NVDk4keR9Z3EJHh1bdHWMOEPEbAPFBs?= =?us-ascii?Q?HsTdvXTUuWLCAR7iOLLP3bLesm63gZgJHAy0DYX+vfrXCw+B8bjRUy4A0a2B?= =?us-ascii?Q?BgxLZ2Sdz2kByNa4AVVAdp0PCEzGU/f76R1TFu9rQDJuZnvC1LVXZJiV2U29?= =?us-ascii?Q?oDfl9T3dvmeDUe76wNQM6yY3GM3BW4CDSRBMJGffgjPaxKQ6SuBjC8hrVMoV?= =?us-ascii?Q?e+L/1VbxB0MKhWyRdUI1OeuP5mFYBLc6wEASIODcqhmXJUKtAXCojJeFhHx4?= =?us-ascii?Q?eQW58R/f1v/VBjn8ItDxUsEcgXs2ji9qn9NnikYaEaXWJyFaRMSbZkbzf7ZY?= =?us-ascii?Q?84KQpugR8FWmF2+FIjGAk/05ZSpWpOgBuSMj7nCjUFlmCsZ14aWlcpul9HLV?= =?us-ascii?Q?e5hJIIvLtGS6UEW+axVGN22uqLsqqzMu70zOX1MSyPBQkWhuXDASSkbOfE+9?= =?us-ascii?Q?Df3RULM9K+9mxrED7x32qgI8LD+e5PX88/AMzA0CcqXZZzca0xkm60RfvMUK?= =?us-ascii?Q?bvyAJHz/fBfSgajt+ddwgMkpfS/Qg1pp0hDJ4X65GkV8Gm9iRp5OycnWjxwd?= =?us-ascii?Q?1uNJmxdzkAsfBWFGWPYh1adhzpX2rCd3E44BxsfhZdYtMOrTCr8qtjRc9WXO?= =?us-ascii?Q?ItzaB57coe7GI1fPi02PlZvwTRtr6oBv97isz36EMD1tKPdT7cvB+kxd5TqD?= =?us-ascii?Q?PH/zYmaIgLkXe1wp+1mRKcNoGZlXRsxj5yW9QOTPllB36Ymej1K2Q6ovu4h6?= =?us-ascii?Q?j0d+rKHuMjEGV8DhR0qgnijZcM/eP7ziE5TbtWYin96HGgjktGohdTUXlvWK?= =?us-ascii?Q?zeoKpDgjURd4CVYgUwzvJQeEORd2/18JKMOgYEZUi6bYMBEWg/9KPybTSFge?= =?us-ascii?Q?sS2kAz1hBOlm8kK3hU1VHkBVCegdsYzJM7BnV5dU3gxxCM+E5ikNFns5QDBy?= =?us-ascii?Q?HE43uydKzzkw1fyh3A19wIetbkxzBleGNTG0H3im/RjPlxjYCSudE3H5wWDi?= =?us-ascii?Q?kdCWNh48NjTfzjAl0U=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2794; 6:43oz1pcW/1Fm0JBRiOw49DbTSANAerHhJtgcWXudv2MuR1JydvtUyDmu/U1XuZt0+TUV4OWr7kP9Jt/K7Sw92XoynpRsgp8bmngl5yO1OkMjUvjlBr13fUaQrU4lRJxCjcn8aJAYp8d5J7wYVnJY747egdyNcr9g7F/EXQ5RSiStjYP5GTn8/qERwifSFtnF6kRFzjJxShqyNE4k5g2sOOvnZPIh4dsonjrLLyXDOHLfx7UBr2WK08D1LHOqygQ5Itnuv3LKM67wl4uVUjGjJrbF+oc8Md2dWEr4AI+TeP9Z5ULQzulTFCnb2Rfv+WxbBBgWlUW9BHXNBqf41qPIxw3Fntm+vtSuPOyNmXOxG1D8lXjhZfNJyzeuFqSwkWPUDaafRkx0SX1NZyjjmxLKMlf00KKho+TDMbluCrLLpr4=; 5:xZswazgTjLyMVnrJLolGBQuk8AIzaRG9DrqgJavc9LwPjVkjjlVstxl7VMb7ZEILfoWJ4JZn2EkA2NcBXQ72Z+WwD6vvYo9GVHEkGjAdI7u213kzgaVG2hA89MBTmdUUE50TLHh4sEQl3WUwGGEDQCsmA5/BCSp5Wfoeg3FKTqhiE106m4CNwgIZXY+d9Xwm; 24:eyxy+FvClCxq7XOuHXP6MNVL9E9Uxl6rMFMG5lrolc3OiHfmT4M44r58pKaYsq8C7dYZO2fbPw97sRieDyw6mXe1UNv1XaULXAQ3LP7YaF0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2794; 7:neZGxkXFbMBX7en/IkEKbEVgE62MAO3nGGy4ZNzVIQlyuk6eiVGmkONUq6OF+IKlTsXt9SugAjlSdBW+HAWtxk3axBgBOAiB6g0PuhWHgTAhm6tO7oPDvEM5O+tkHWN4PdXM0kRcV7XDPIl9kkq3WpCtCijzb+LlC4IBlHuKs+4UxJd3OgEBn769TrbXT3wHnUJr/tkzp3odJkHbjqoFOc0lw/I4RavW/phGFvEbGRTZwp9qy85xgsv3Ko3xXey7wHORcuYDa+cRdnoDkcrUqkD/COD4u6DnaXB5h+mRCfwOlR665T0fc9j9ajNhvzZ2qY04W77T0NmLhujvcD/rqQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2017 14:19:10.7814 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2794 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170319_071933_549300_2C9478C4 X-CRM114-Status: UNSURE ( 9.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aisheng.dong@nxp.com, dongas86@gmail.com, andrew.smirnov@gmail.com, fabio.estevam@nxp.com, shawnguo@kernel.org, l.stach@pengutronix.de Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Without providing the proper reg_defaults, the regmap registers first read out may be always 0 if enabling cache, which results in the following issue we met. e.g. During driver probe in imx6_pm_domain_power_on(): regmap_read(pd->regmap, pd->reg_offs + GPC_PGC_PUPSCR_OFFS, &val); The PGC_PUPSCR register val is always 0 but it's actually 0xf01 in HW. Since GPC registers are tightly related to CPU bring up and may be changed in bootloader, we don't want to provide defaults. And the cache really does not save too much for GPC module. Therefore, simply disable cache to fix the issue and make life easy. Cc: Lucas Stach Cc: Shawn Guo Fixes: 721cabf6c660 ("soc: imx: move PGC handling to a new GPC driver") Signed-off-by: Dong Aisheng Reviewed-by: Lucas Stach --- drivers/soc/imx/gpc.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c index c9bfdfd..7e6a672 100644 --- a/drivers/soc/imx/gpc.c +++ b/drivers/soc/imx/gpc.c @@ -289,22 +289,12 @@ static bool imx_gpc_readable_reg(struct device *dev, unsigned int reg) return (reg % 4 == 0) && (reg <= 0x2ac); } -static bool imx_gpc_volatile_reg(struct device *dev, unsigned int reg) -{ - if (reg == GPC_CNTR) - return true; - - return false; -} - static const struct regmap_config imx_gpc_regmap_config = { - .cache_type = REGCACHE_FLAT, .reg_bits = 32, .val_bits = 32, .reg_stride = 4, .readable_reg = imx_gpc_readable_reg, - .volatile_reg = imx_gpc_volatile_reg, .max_register = 0x2ac, };