From patchwork Tue Mar 21 19:24:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iyappan Subramanian X-Patchwork-Id: 9637551 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4B7FB6020B for ; Tue, 21 Mar 2017 19:53:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C3E727C14 for ; Tue, 21 Mar 2017 19:53:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 30A7728304; Tue, 21 Mar 2017 19:53:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C4A6B27C14 for ; Tue, 21 Mar 2017 19:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=nqSRnoxqvquKPYl5lyF07g97gTn1m1vDp4LObzFLsHM=; b=BLHT9mp5ITJiYpGp/myn074s2w eq8+LP8aD70BFRIR6sBoCFpkiTwu5/f258uFlZCAEpIf+2URE6zO3NLJ9woUUa6t470JcbudCa67J a5m9ADQ2K2LP+fkvXyOzmAA/O2V7k1w+Ihtq43d15zyn9O2eE2lnzAWZIkCpM+D+rujD1B1XevUmM CaV6vglJdYpMJUnqS0eoCnBAUnE1syXEsgbVy8dwSTaYU8PoIW9ozZ+JublpJ8L49AkcIugE7wHL3 aTIDiuyhIjDVdTaalL7VbFV2dxfXuAQrDhnusDHRODUnGTPt4NDJ9AtUx3Ydl/aCUhltaqUUSBY2h GKyDuFnA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cqPq8-00037g-6R; Tue, 21 Mar 2017 19:53:08 +0000 Received: from casper.infradead.org ([2001:770:15f::2]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cqPph-0002KG-2w for linux-arm-kernel@bombadil.infradead.org; Tue, 21 Mar 2017 19:52:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9UMuvLTewIcJjv61X4baW5HRIO3HP6+Nt+kgwwkIFnE=; b=pwtz/kmnRNNtra06yJ9kxZLUI Fr1ryN/1ixfEGYabdWVNU8vjSVTCHhL/m52gekX9pBEu9jzvEPDlCpIrLeNKGfmZ4iBJWYCxdB652 MTDuohPCMcQEatC7FO3Q+frlYQLj+f2WCSM7tnMaLV2iSI4UG1u9XeY5k8v5PtmraxiPsMSaQyOq8 x2gKXOcEVpKHwy1nR9mCgNGm+4Qaf3LUnCZ+epG6YYZSnH3RE03kWI4Jm1+IwTbrlKXGuioPSM6/P ZxldAcSUELmtRdiNIvVXrXrJx5UYLy3p6EAnRFlkujKNq35AlZcY4kKe2dSuKHGKsZsCLv/HUGi1m 8dhRzvdWw==; Received: from mail-pg0-x22b.google.com ([2607:f8b0:400e:c05::22b]) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cqPNp-0004sB-RX for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2017 19:23:56 +0000 Received: by mail-pg0-x22b.google.com with SMTP id t143so32208567pgb.2 for ; Tue, 21 Mar 2017 12:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apm.com; s=apm; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9UMuvLTewIcJjv61X4baW5HRIO3HP6+Nt+kgwwkIFnE=; b=Dfz8ZInuy9/NHulYYmKca2C/4lpzniYrrh/HKLTKVyCzsx8ibFwgwuFqr55IO3+3AL qA6kW319MUt1pVkInKNLiapntxwxjxOYkXZyKPxZya5bPujnbjC06g+ZFB9/q2OirX15 C0RLM9mgwO6ypYp0ksDL0NB5HNhnaKcRZ+pPE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9UMuvLTewIcJjv61X4baW5HRIO3HP6+Nt+kgwwkIFnE=; b=jvkzewjVKbKPZTf7foE1d5QLs4W9bD9Eavi0I29JHvVpQrkxVOAYBsvJTl4D2wqJmd 0rlQ0DjPXvBfkF/1IRJu1Wbe+y+UvaLd2ZVTJ55sUzhWLhPvXdAuKpP947WfjLFd1kAU PueIvq1ZQy6LRRoWGzLUpZQYELez1x/CR2xG0XASJbxBnsNpjAEQ4CQkHx+e8mKxn8Dj fcTJDGSeOWbU0UQT+S2+5nTZ8mK1uziovJ6gLYlcR5JKk99GM2h4vhNbWpUSL/ulRHxi mEAR+CnfDEo8I0HxUJCylocPl7ig3ivcHtiU/0hvA66bRPZ31nSFaZWYPjFAWA5MuFSa Ic2Q== X-Gm-Message-State: AFeK/H1ch3gJtovO4PQT/KUvUgfsDD8QRJZ1YHt9MBR+5iJa7QRjtC1Lylgm7tUtc+W/6Lj+ X-Received: by 10.98.72.147 with SMTP id q19mr41880109pfi.253.1490124210308; Tue, 21 Mar 2017 12:23:30 -0700 (PDT) Received: from isubrama-dev.amcc.com ([206.80.4.98]) by smtp.gmail.com with ESMTPSA id u69sm41113642pfg.121.2017.03.21.12.23.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 21 Mar 2017 12:23:29 -0700 (PDT) From: Iyappan Subramanian To: davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, David.Laight@aculab.com Subject: [PATCH net-next 4/4] drivers: net: xgene-v2: misc fixes Date: Tue, 21 Mar 2017 12:24:43 -0700 Message-Id: <1490124283-10371-5-git-send-email-isubramanian@apm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1490124283-10371-1-git-send-email-isubramanian@apm.com> References: <1490124283-10371-1-git-send-email-isubramanian@apm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170321_192354_070100_A7C6882A X-CRM114-Status: GOOD ( 16.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kchudgar@apm.com, patches@apm.com, linux-arm-kernel@lists.infradead.org, Iyappan Subramanian MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Fixed review comments from the previous patch-set. - changed return value check of platform_get_irq() to < 0 - replaced devm_request(free)_irq() calls by request(free)_irq() since they are called from open() and close() - changed sizeof(struct mystruct) to sizeof(*mystruct) - reduced indentation on tx_timeout() Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene-v2/main.c | 55 +++++++++++++++----------------- 1 file changed, 26 insertions(+), 29 deletions(-) diff --git a/drivers/net/ethernet/apm/xgene-v2/main.c b/drivers/net/ethernet/apm/xgene-v2/main.c index 9a5a5ec..ce31c47 100644 --- a/drivers/net/ethernet/apm/xgene-v2/main.c +++ b/drivers/net/ethernet/apm/xgene-v2/main.c @@ -66,9 +66,8 @@ static int xge_get_resources(struct xge_pdata *pdata) } ret = platform_get_irq(pdev, 0); - if (ret <= 0) { - dev_err(dev, "Unable to get ENET IRQ\n"); - ret = ret ? : -ENXIO; + if (ret < 0) { + dev_err(dev, "Unable to get irq\n"); return ret; } pdata->resources.irq = ret; @@ -156,13 +155,12 @@ static irqreturn_t xge_irq(const int irq, void *data) static int xge_request_irq(struct net_device *ndev) { struct xge_pdata *pdata = netdev_priv(ndev); - struct device *dev = &pdata->pdev->dev; int ret; snprintf(pdata->irq_name, IRQ_ID_SIZE, "%s", ndev->name); - ret = devm_request_irq(dev, pdata->resources.irq, xge_irq, - 0, pdata->irq_name, pdata); + ret = request_irq(pdata->resources.irq, xge_irq, 0, pdata->irq_name, + pdata); if (ret) netdev_err(ndev, "Failed to request irq %s\n", pdata->irq_name); @@ -172,9 +170,8 @@ static int xge_request_irq(struct net_device *ndev) static void xge_free_irq(struct net_device *ndev) { struct xge_pdata *pdata = netdev_priv(ndev); - struct device *dev = &pdata->pdev->dev; - devm_free_irq(dev, pdata->resources.irq, pdata); + free_irq(pdata->resources.irq, pdata); } static bool is_tx_slot_available(struct xge_raw_desc *raw_desc) @@ -424,7 +421,7 @@ static struct xge_desc_ring *xge_create_desc_ring(struct net_device *ndev) struct xge_desc_ring *ring; u16 size; - ring = kzalloc(sizeof(struct xge_desc_ring), GFP_KERNEL); + ring = kzalloc(sizeof(*ring), GFP_KERNEL); if (!ring) return NULL; @@ -436,7 +433,7 @@ static struct xge_desc_ring *xge_create_desc_ring(struct net_device *ndev) if (!ring->desc_addr) goto err; - ring->pkt_info = kcalloc(XGENE_ENET_NUM_DESC, sizeof(struct pkt_info), + ring->pkt_info = kcalloc(XGENE_ENET_NUM_DESC, sizeof(*ring->pkt_info), GFP_KERNEL); if (!ring->pkt_info) goto err; @@ -598,28 +595,28 @@ static void xge_timeout(struct net_device *ndev) rtnl_lock(); - if (netif_running(ndev)) { - netif_carrier_off(ndev); - netif_stop_queue(ndev); - xge_intr_disable(pdata); - napi_disable(&pdata->napi); + if (!netif_running(ndev)) + goto out; - xge_wr_csr(pdata, DMATXCTRL, 0); - xge_txc_poll(ndev); - xge_free_pending_skb(ndev); - xge_wr_csr(pdata, DMATXSTATUS, ~0U); + netif_stop_queue(ndev); + xge_intr_disable(pdata); + napi_disable(&pdata->napi); - xge_setup_desc(pdata->tx_ring); - xge_update_tx_desc_addr(pdata); - xge_mac_init(pdata); + xge_wr_csr(pdata, DMATXCTRL, 0); + xge_txc_poll(ndev); + xge_free_pending_skb(ndev); + xge_wr_csr(pdata, DMATXSTATUS, ~0U); - napi_enable(&pdata->napi); - xge_intr_enable(pdata); - xge_mac_enable(pdata); - netif_start_queue(ndev); - netif_carrier_on(ndev); - } + xge_setup_desc(pdata->tx_ring); + xge_update_tx_desc_addr(pdata); + xge_mac_init(pdata); + + napi_enable(&pdata->napi); + xge_intr_enable(pdata); + xge_mac_enable(pdata); + netif_start_queue(ndev); +out: rtnl_unlock(); } @@ -653,7 +650,7 @@ static int xge_probe(struct platform_device *pdev) struct xge_pdata *pdata; int ret; - ndev = alloc_etherdev(sizeof(struct xge_pdata)); + ndev = alloc_etherdev(sizeof(*pdata)); if (!ndev) return -ENOMEM;