From patchwork Thu Apr 6 09:43:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Zabel X-Patchwork-Id: 9666765 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7247D60364 for ; Thu, 6 Apr 2017 09:44:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6A37526E76 for ; Thu, 6 Apr 2017 09:44:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5EA3928354; Thu, 6 Apr 2017 09:44:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B38AD26E76 for ; Thu, 6 Apr 2017 09:44:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UkuaWnqWJyiBKqHNHo0yypIq2CpbuY+lbb5YuLkIqY8=; b=urh2DP0nAnvJbE qozEpm8ZPk0SyiB0GTVfZ1iWr/gQSFPRQAE2aVt+dNknQ3vWyQMEOdwtpmw3s1849zVwFicwbwX09 EheKB7q6Eo584bB7pxn0V8xvcsMIpy6VXIIzINY5tVKwjz0x+zuRz3DvsJGlHOXmJAxOy3750bgq7 rJ6EQuENfZ5YMEeJ2H364Ofj8HDF51tQC7MOse8X6/ON8vVrMcIp5q8ob8qIfDF1T8AWZ+fMGUTBu 6diyhG0f5ZM+WLsAHp+JADnTz7qSM4b9pf5yHJP7eFSlGEti11LoC0I7odaPjbvgnqPlMhksOafkA xegv36Wa9/NSU+H/zQtw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cw3y8-0003R1-LK; Thu, 06 Apr 2017 09:44:44 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cw3y4-0003L6-0A for linux-arm-kernel@lists.infradead.org; Thu, 06 Apr 2017 09:44:42 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.84_2) (envelope-from ) id 1cw3xA-0001PV-3x; Thu, 06 Apr 2017 11:43:44 +0200 Message-ID: <1491471814.2392.11.camel@pengutronix.de> Subject: Re: [PATCH v6 19/39] media: Add i.MX media core driver From: Philipp Zabel To: Steve Longerbeam Date: Thu, 06 Apr 2017 11:43:34 +0200 In-Reply-To: <1490661656-10318-20-git-send-email-steve_longerbeam@mentor.com> References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-20-git-send-email-steve_longerbeam@mentor.com> X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170406_024440_296062_F52AF794 X-CRM114-Status: GOOD ( 13.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, andrew-ct.chen@mediatek.com, minghsiu.tsai@mediatek.com, nick@shmanahar.org, songjun.wu@microchip.com, hverkuil@xs4all.nl, Steve Longerbeam , pavel@ucw.cz, robert.jarzmik@free.fr, devel@driverdev.osuosl.org, markus.heiser@darmarIT.de, laurent.pinchart+renesas@ideasonboard.com, shuah@kernel.org, linux@armlinux.org.uk, geert@linux-m68k.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, sakari.ailus@linux.intel.com, arnd@arndb.de, mchehab@kernel.org, bparrot@ti.com, robh+dt@kernel.org, horms+renesas@verge.net.au, tiffany.lin@mediatek.com, linux-arm-kernel@lists.infradead.org, niklas.soderlund+renesas@ragnatech.se, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, jean-christophe.trotin@st.com, kernel@pengutronix.de, fabio.estevam@nxp.com, shawnguo@kernel.org, sudipm.mukherjee@gmail.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 2017-03-27 at 17:40 -0700, Steve Longerbeam wrote: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam [...] > diff --git a/drivers/staging/media/imx/imx-media-of.c b/drivers/staging/media/imx/imx-media-of.c > new file mode 100644 > index 0000000..b383be4 > --- /dev/null > +++ b/drivers/staging/media/imx/imx-media-of.c > @@ -0,0 +1,267 @@ [...] > +/* > + * find the remote device node and remote port id (remote pad #) > + * given local endpoint node > + */ > +static void of_get_remote_pad(struct device_node *epnode, > + struct device_node **remote_node, > + int *remote_pad) > +{ > + struct device_node *rp, *rpp; > + struct device_node *remote; > + > + rp = of_graph_get_remote_port(epnode); > + rpp = of_graph_get_remote_port_parent(epnode); > + > + if (of_device_is_compatible(rpp, "fsl,imx6q-ipu")) { > + /* the remote is one of the CSI ports */ > + remote = rp; > + *remote_pad = 0; > + of_node_put(rpp); > + } else { > + remote = rpp; > + of_property_read_u32(rp, "reg", remote_pad); If this fails because there is no reg property, *remote_pad will keep the previous value. It should be set to 0 in this case. ----------8<---------- ---------->8---------- regards Philipp --- a/drivers/staging/media/imx/imx-media-of.c +++ b/drivers/staging/media/imx/imx-media-of.c @@ -85,7 +85,9 @@ static void of_get_remote_pad(struct device_node *epnode, of_node_put(rpp); } else { remote = rpp; - of_property_read_u32(rp, "reg", remote_pad); + /* FIXME port number and pad index are not the same */ + if (of_property_read_u32(rp, "reg", remote_pad)) + *remote_pad = 0; of_node_put(rp); }