From patchwork Tue Apr 18 23:05:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Baicar X-Patchwork-Id: 9686571 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5B050601C2 for ; Tue, 18 Apr 2017 23:08:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4AA8F27D4D for ; Tue, 18 Apr 2017 23:08:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3D9C22839C; Tue, 18 Apr 2017 23:08:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id ABF4D27D4D for ; Tue, 18 Apr 2017 23:08:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Do8tpIT7MQZsEG/UffkvHFb56JF59rU54xRRlGc/0hk=; b=ZsdeYAq3UbTEl6RlcRUcHDk6s2 vCJQTtiUSacroLsAM8hdPQYooWhytJTIV5Fndr666NgLVHFnfLE/YUvLGyk+2Gr7HnvAhzA+mt1kL d9gAZSMNRlwt65CqA/fSY3MuRNEl93qFiC6I+IrQCthXJNbhorVEHOlzX4wpLOz9ru8TLa5rTafZ7 LmWBUpA9Nxuyi1GdnywPy9WrW1ah7zgCE0E8URdA6A8QaLZZ9VYMrUc0osyTxAC3SYOrFDb/AIJXF V+ZQZt3DxmLo0/i08L7ECMWSk9aNrmGaqczu06AGfQTKaDZEPEeUO9Ma4tPlGJmebGi3GKHd4KzIX uZCeZfZA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1d0cEU-0001Xd-3w; Tue, 18 Apr 2017 23:08:26 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1d0cCZ-0007rL-NG for linux-arm-kernel@lists.infradead.org; Tue, 18 Apr 2017 23:06:53 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1A67B61060; Tue, 18 Apr 2017 23:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1492556768; bh=x9BxlbfpAVwxVzKhmgnDuUgqrUuxYZnbat0sL+hGY1o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FrhtrP78E5LoQTHDEMkVayTdlG+DlGjqh/RkGrptjzxvVTbrIJD7a6/GJJ4srNqSD Rcae92AoJM55ldUPWx3pVf5IimoTB1u0a2j8xt7l4LhY7KSHZYE26q1nPeDWSRZt/z u9hWefnWlz2Wu6hDHTBVVxeVGNL6abMrER3BQnis= Received: from tbaicar-lnx.qualcomm.com (unknown [129.46.14.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: tbaicar@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 22FC66114D; Tue, 18 Apr 2017 23:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1492556764; bh=x9BxlbfpAVwxVzKhmgnDuUgqrUuxYZnbat0sL+hGY1o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EQK0KFB4yNNijL2sNkiaI9o1nu/P39qZJaWsXsCQ/D9BsPvnjiMsuY6NbJ6NF6g37 4dD8Ovmf7i97a8SXk6V/wd/XwGoWfFng9Ejycuoa4VZ5SoDwhwQF1wg4zoQA6Q/E4s Ss7Z0VH5Ht9ib9kYRT2bOulXcfJbleqCmkgxGKp8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 22FC66114D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org From: Tyler Baicar To: christoffer.dall@linaro.org, marc.zyngier@arm.com, pbonzini@redhat.com, rkrcmar@redhat.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, lenb@kernel.org, matt@codeblueprint.co.uk, robert.moore@intel.com, lv.zheng@intel.com, nkaje@codeaurora.org, zjzhang@codeaurora.org, mark.rutland@arm.com, james.morse@arm.com, akpm@linux-foundation.org, eun.taik.lee@samsung.com, sandeepa.s.prabhu@gmail.com, labbott@redhat.com, shijie.huang@arm.com, rruigrok@codeaurora.org, paul.gortmaker@windriver.com, tn@semihalf.com, fu.wei@linaro.org, rostedt@goodmis.org, bristot@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org, devel@acpica.org, Suzuki.Poulose@arm.com, punit.agrawal@arm.com, astone@redhat.com, harba@codeaurora.org, hanjun.guo@linaro.org, john.garry@huawei.com, shiju.jose@huawei.com, joe@perches.com, bp@alien8.de, rafael@kernel.org, tony.luck@intel.com, gengdongjiu@huawei.com, xiexiuqi@huawei.com Subject: [PATCH V15 08/11] efi: print unrecognized CPER section Date: Tue, 18 Apr 2017 17:05:20 -0600 Message-Id: <1492556723-9189-9-git-send-email-tbaicar@codeaurora.org> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1492556723-9189-1-git-send-email-tbaicar@codeaurora.org> References: <1492556723-9189-1-git-send-email-tbaicar@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170418_160628_461741_42AAB56D X-CRM114-Status: GOOD ( 11.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tyler Baicar MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP UEFI spec allows for non-standard section in Common Platform Error Record. This is defined in section N.2.3 of UEFI version 2.5. Currently if the CPER section's type (UUID) does not match with one of the section types that the kernel knows how to parse, the section is skipped. Therefore, user is not able to see such CPER data, for instance, error record of non-standard section. For above mentioned case, this change prints out the raw data in hex in dmesg buffer. Data length is taken from Error Data length field of Generic Error Data Entry. The following is a sample output from dmesg: [ 140.739180] {1}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 2 [ 140.739182] {1}[Hardware Error]: It has been corrected by h/w and requires no further action [ 140.739191] {1}[Hardware Error]: event severity: corrected [ 140.739196] {1}[Hardware Error]: time: precise 2017-03-15 20:37:35 [ 140.739197] {1}[Hardware Error]: Error 0, type: corrected [ 140.739203] {1}[Hardware Error]: section type: unknown, d2e2621c-f936-468d-0d84-15a4ed015c8b [ 140.739205] {1}[Hardware Error]: section length: 568 (0x238) [ 140.739210] {1}[Hardware Error]: 00000000: 4d415201 4d492031 453a4d45 435f4343 .RAM1 IMEM:ECC_C [ 140.739214] {1}[Hardware Error]: 00000010: 53515f45 44525f42 00000000 00000000 E_QSB_RD........ [ 140.739217] {1}[Hardware Error]: 00000020: 00000000 00000000 00000000 00000000 ................ [ 140.739220] {1}[Hardware Error]: 00000030: 00000000 00000000 01010000 01010000 ................ [ 140.739223] {1}[Hardware Error]: 00000040: 00000000 00000000 00000005 00000000 ................ [ 140.739226] {1}[Hardware Error]: 00000050: 01010000 00000000 00000001 00dddd00 ................ ... The raw data from the error can then be decoded using vendor specific tools. Signed-off-by: Tyler Baicar CC: Jonathan (Zhixiong) Zhang Reviewed-by: James Morse --- drivers/firmware/efi/cper.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c index f959185..610d31a 100644 --- a/drivers/firmware/efi/cper.c +++ b/drivers/firmware/efi/cper.c @@ -596,8 +596,16 @@ static void cper_estatus_timestamp(const char *pfx, cper_print_proc_arm(newpfx, arm_err); else goto err_section_too_small; - } else - printk("%s""section type: unknown, %pUl\n", newpfx, sec_type); + } else { + const void *unknown_err; + + unknown_err = acpi_hest_get_payload(gdata); + printk("%ssection type: unknown, %pUl\n", newpfx, sec_type); + printk("%ssection length: %d (%#x)\n", newpfx, + gdata->error_data_length, gdata->error_data_length); + print_hex_dump(newpfx, "", DUMP_PREFIX_OFFSET, 16, 4, + unknown_err, gdata->error_data_length, true); + } return;