From patchwork Tue Jul 4 09:10:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boris BREZILLON X-Patchwork-Id: 9824397 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 77781602F0 for ; Tue, 4 Jul 2017 09:11:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6579727FB1 for ; Tue, 4 Jul 2017 09:11:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 59B702844C; Tue, 4 Jul 2017 09:11:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D731827FB1 for ; Tue, 4 Jul 2017 09:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=wh79qTNuLKtXk8jU48ssBUFKbsV/IMg+mU1r8++J8I8=; b=UN6 v1V22ZLZmP8OIPO9xbZGBjS5goPmX79wvdBKWiVbXQ/YTsXfV+hxMsudv7xtKAIQ85JwFwaHRPZD2 RgEh2emSwIf80W3lcxfThgYiUDeZiXPp6KIRYeZZoD4JioX7BPRA4jvkIgOYtnU3FcIGpkLj5l5Pl yzKDiVVvTeBLtMKOTXZYI1ovlFhgRtcqZG11H5xfzFNFHkgFpFiJB7rBb1XGQlGedA/4H1il8gXnz S6TYjNzD23BlSdnVqQF5C5Qjr/iCCbdw3w+Rb97UvumWZlVJIWQaNlkNZ8RtJstpXDloUBkMx8aNY 9MifQpPeEZwlcyPwRyN4z3pJJp2fFBw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dSJrk-0002DR-Vo; Tue, 04 Jul 2017 09:11:28 +0000 Received: from mail.free-electrons.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dSJrX-0001pd-0p for linux-arm-kernel@lists.infradead.org; Tue, 04 Jul 2017 09:11:16 +0000 Received: by mail.free-electrons.com (Postfix, from userid 110) id E5F5E21FCA; Tue, 4 Jul 2017 11:10:51 +0200 (CEST) Received: from bbrezillon.lan (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.free-electrons.com (Postfix) with ESMTPSA id A906621FC5; Tue, 4 Jul 2017 11:10:41 +0200 (CEST) From: Boris Brezillon To: Thomas Gleixner , Jason Cooper , Marc Zyngier , Nicolas Ferre , Alexandre Belloni Subject: [PATCH 1/3] irqchip/atmel-aic: Fix unbalanced of_node_put() in aic_common_irq_fixup() Date: Tue, 4 Jul 2017 11:10:39 +0200 Message-Id: <1499159441-29801-1-git-send-email-boris.brezillon@free-electrons.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170704_021115_254575_1C8C0B67 X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP aic_common_irq_fixup() is calling twice of_node_put() on the same node thus leading to an unbalanced refcount on the root node. Signed-off-by: Boris Brezillon Reported-by: Alexandre Belloni Fixes: b2f579b58e93 ("irqchip: atmel-aic: Add irq fixup infrastructure") Cc: --- drivers/irqchip/irq-atmel-aic-common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/irqchip/irq-atmel-aic-common.c b/drivers/irqchip/irq-atmel-aic-common.c index 28b26c80f4cf..7c5a43488d27 100644 --- a/drivers/irqchip/irq-atmel-aic-common.c +++ b/drivers/irqchip/irq-atmel-aic-common.c @@ -196,7 +196,6 @@ static void __init aic_common_irq_fixup(const struct of_device_id *matches) return; match = of_match_node(matches, root); - of_node_put(root); if (match) { void (*fixup)(struct device_node *) = match->data;