diff mbox

[v1,2/3] dt-bindings: display: panel: Add support for Orise Tech otm8009a dsi panel

Message ID 1499185805-23354-3-git-send-email-philippe.cornu@st.com (mailing list archive)
State New, archived
Headers show

Commit Message

Philippe CORNU July 4, 2017, 4:30 p.m. UTC
The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using
a MIPI-DSI video interface. Its backlight is managed through the DSI link.

Signed-off-by: Philippe CORNU <philippe.cornu@st.com>
---
 .../bindings/display/panel/orisetech,otm8009a.txt    | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt

Comments

Philippe CORNU July 6, 2017, 2:21 p.m. UTC | #1
On 07/04/2017 06:30 PM, Philippe CORNU wrote:
> The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using
> a MIPI-DSI video interface. Its backlight is managed through the DSI link.
> 
> Signed-off-by: Philippe CORNU <philippe.cornu@st.com>
> ---
>   .../bindings/display/panel/orisetech,otm8009a.txt    | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt
> new file mode 100644
> index 0000000..0bb8237
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt
> @@ -0,0 +1,20 @@
> +Orise Tech OTM8009A 3.97" 480x800 TFT LCD panel (MIPI-DSI video mode)
> +
> +The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using
> +a MIPI-DSI video interface. Its backlight is managed through the DSI link.
> +
> +Required properties:
> +  - compatible: "orisetech,otm8009a"
> +  - reg: the virtual channel number of a DSI peripheral
> +  - reset-gpios: a GPIO spec for the reset pin (active low). (Optional)
> +
> +Example:
> +&dsi {
> +	...
> +
> +	panel@0 {
> +		compatible = "orisetech,otm8009a";
> +		reg = <0>;
> +		reset-gpios = <&gpioh 7 0>;

Hi All,
I should have written instead:
  +		reset-gpios = <&gpioh 7 GPIO_ACTIVE_LOW>;

reset-gpios is active low and the define GPIO_ACTIVE_LOW = 1 so the 
example was not good.

I will send soon the v2 with the correction.
Many thanks
Philippe


> +	};
> +};
>
Rob Herring (Arm) July 10, 2017, 1:12 a.m. UTC | #2
On Tue, Jul 04, 2017 at 06:30:04PM +0200, Philippe CORNU wrote:
> The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using
> a MIPI-DSI video interface. Its backlight is managed through the DSI link.
> 
> Signed-off-by: Philippe CORNU <philippe.cornu@st.com>
> ---
>  .../bindings/display/panel/orisetech,otm8009a.txt    | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt
> new file mode 100644
> index 0000000..0bb8237
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt
> @@ -0,0 +1,20 @@
> +Orise Tech OTM8009A 3.97" 480x800 TFT LCD panel (MIPI-DSI video mode)
> +
> +The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using
> +a MIPI-DSI video interface. Its backlight is managed through the DSI link.
> +
> +Required properties:
> +  - compatible: "orisetech,otm8009a"
> +  - reg: the virtual channel number of a DSI peripheral
> +  - reset-gpios: a GPIO spec for the reset pin (active low). (Optional)

If this is optional, move it to its own section.

> +
> +Example:
> +&dsi {
> +	...
> +
> +	panel@0 {
> +		compatible = "orisetech,otm8009a";
> +		reg = <0>;
> +		reset-gpios = <&gpioh 7 0>;
> +	};
> +};
> -- 
> 1.9.1
>
Philippe CORNU July 10, 2017, 9:34 a.m. UTC | #3
On 07/10/2017 03:12 AM, Rob Herring wrote:
> On Tue, Jul 04, 2017 at 06:30:04PM +0200, Philippe CORNU wrote:
>> The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using
>> a MIPI-DSI video interface. Its backlight is managed through the DSI link.
>>
>> Signed-off-by: Philippe CORNU <philippe.cornu@st.com>
>> ---
>>   .../bindings/display/panel/orisetech,otm8009a.txt    | 20 ++++++++++++++++++++
>>   1 file changed, 20 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt
>> new file mode 100644
>> index 0000000..0bb8237
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt
>> @@ -0,0 +1,20 @@
>> +Orise Tech OTM8009A 3.97" 480x800 TFT LCD panel (MIPI-DSI video mode)
>> +
>> +The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using
>> +a MIPI-DSI video interface. Its backlight is managed through the DSI link.
>> +
>> +Required properties:
>> +  - compatible: "orisetech,otm8009a"
>> +  - reg: the virtual channel number of a DSI peripheral
>> +  - reset-gpios: a GPIO spec for the reset pin (active low). (Optional)
> 
> If this is optional, move it to its own section.
> 

Dear Rob,
Many thanks for your comment. Fixed in v2, sent few minutes ago.
Best regards,
Philippe

>> +
>> +Example:
>> +&dsi {
>> +	...
>> +
>> +	panel@0 {
>> +		compatible = "orisetech,otm8009a";
>> +		reg = <0>;
>> +		reset-gpios = <&gpioh 7 0>;
>> +	};
>> +};
>> -- 
>> 1.9.1
>>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt
new file mode 100644
index 0000000..0bb8237
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt
@@ -0,0 +1,20 @@ 
+Orise Tech OTM8009A 3.97" 480x800 TFT LCD panel (MIPI-DSI video mode)
+
+The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using
+a MIPI-DSI video interface. Its backlight is managed through the DSI link.
+
+Required properties:
+  - compatible: "orisetech,otm8009a"
+  - reg: the virtual channel number of a DSI peripheral
+  - reset-gpios: a GPIO spec for the reset pin (active low). (Optional)
+
+Example:
+&dsi {
+	...
+
+	panel@0 {
+		compatible = "orisetech,otm8009a";
+		reg = <0>;
+		reset-gpios = <&gpioh 7 0>;
+	};
+};