From patchwork Tue Jul 18 06:02:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeffy Chen X-Patchwork-Id: 9846983 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0123C602C8 for ; Tue, 18 Jul 2017 06:18:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE58823B3C for ; Tue, 18 Jul 2017 06:18:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E2C56274D0; Tue, 18 Jul 2017 06:18:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8294623B3C for ; Tue, 18 Jul 2017 06:18:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ZH6cyFFYUdhzH8Pp/aaFJ3K5ZTlLaUpLLXUBTAncFz4=; b=uWJx8hnYGoOWgDxdaBsNEoDnZS o46AVj0eub7ygv44QFSGnFr7zBwI4qc3ijhY19I53LICQ8exEY56RjjLhFfpGgbpeZ2JtC/odhcBP VoPQ0xIVEevO9qAN/Th4EjKPflCE06XwJCLdcKkR9KUvHKd/asK7y7DxG1DAaUY/rtxvCUIZzyQCk m5pvZ6acX9+TcogCPQA8+GeQiJysvdhW3D/etinD7KIgR1P2wYTll0JoA5zO0G2D0Wntim/mzzRRA fUKypX3iRmwoMo4zuOhjhK7Yy4qXszPvkqHKLHbCTTZbiK2HQUElOPKJ8dOSyoVDR4zsoolYRMv1l 2NmzSJSQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dXLpp-00021i-10; Tue, 18 Jul 2017 06:18:17 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dXLpn-0001yP-Kr for linux-arm-kernel@bombadil.infradead.org; Tue, 18 Jul 2017 06:18:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GIbLCIdqsZphMhri9bGOwEwD2dvgRYPXWDfwGIpbXfs=; b=CtsrmB8+qcmLROVQqi4onT85L S2R/FrXGhhpMVBTqnhzm93q0icU36BITMF1Ui0+ixhMVxgHjvVe02mBK2raunLlsLu8zFSN4PZMAW cMg/dK2mvXfyQmvC4BeZQXFRAb7qXmiMyMa1D+hyAH11WRH8Vlc1zbcYp92dyo2VSRgm4we2rJEra zElMLiO01vYl3GYzaz5gpFpoiYQD6yDUVn6reYvmv0LZyn0XtUtsyrJdwDOFwgd7R/jStyaaeGczN milOD6SCHLSJcbB9iNCeNhw6n0dZU4qnMVNZ2sYYPlMq2MsSDj4z4ssXH2nJWeonxoEi1OVuFhINv boH/UnkJA==; Received: from regular1.263xmail.com ([211.150.99.135]) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dXLbr-00081b-Jj for linux-arm-kernel@lists.infradead.org; Tue, 18 Jul 2017 06:03:53 +0000 Received: from jeffy.chen?rock-chips.com (unknown [192.168.167.231]) by regular1.263xmail.com (Postfix) with ESMTP id 437C51E56F; Tue, 18 Jul 2017 14:03:25 +0800 (CST) X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 Received: from localhost (localhost [127.0.0.1]) by smtp.263.net (Postfix) with ESMTPA id 66B9E3BC; Tue, 18 Jul 2017 14:03:19 +0800 (CST) X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-SENDER: cjf@rock-chips.com X-DNS-TYPE: 0 Received: from localhost (unknown [103.29.142.67]) by smtp.263.net (Postfix) whith ESMTP id 8130SDOGTN; Tue, 18 Jul 2017 14:03:23 +0800 (CST) From: Jeffy Chen To: linux-kernel@vger.kernel.org Subject: [PATCH 3/5] serial: xuartps: Remove __init marking from early write Date: Tue, 18 Jul 2017 14:02:56 +0800 Message-Id: <1500357778-23169-4-git-send-email-jeffy.chen@rock-chips.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1500357778-23169-1-git-send-email-jeffy.chen@rock-chips.com> References: <1500357778-23169-1-git-send-email-jeffy.chen@rock-chips.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170718_070352_023825_1A17A7B0 X-CRM114-Status: UNSURE ( 9.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: briannorris@chromium.org, peter@hurleysoftware.com, gregkh@linuxfoundation.org, Jeffy Chen , dianders@chromium.org, Michal Simek , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Jiri Slaby , =?UTF-8?q?S=C3=B6ren=20Brinkmann?= MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The earlycon would be alive outside the init code in these cases: 1/ we have keep_bootcon in cmdline. 2/ we don't have a real console to switch to. So remove the __init marking to avoid invalid memory access. Signed-off-by: Jeffy Chen --- drivers/tty/serial/xilinx_uartps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index fde55dc..31a630a 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1163,7 +1163,7 @@ static void cdns_uart_console_putchar(struct uart_port *port, int ch) writel(ch, port->membase + CDNS_UART_FIFO); } -static void __init cdns_early_write(struct console *con, const char *s, +static void cdns_early_write(struct console *con, const char *s, unsigned n) { struct earlycon_device *dev = con->data;