From patchwork Tue Jul 18 10:57:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J, KEERTHY" X-Patchwork-Id: 9847869 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B6200602A7 for ; Tue, 18 Jul 2017 10:58:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BDC1F2854A for ; Tue, 18 Jul 2017 10:58:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B225A28573; Tue, 18 Jul 2017 10:58:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4342A2854A for ; Tue, 18 Jul 2017 10:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RZsd4gtI6EtusEsbuXm3eHshfMIK1lBV7XTzQmax/TE=; b=oaxKkja8OEj0X8 j/dux4vCmXI8ilGhkndztqby+vhhf1FhYrUWpY2YDwIjg4K1cKzopvRzbne41mqamPnrjdrkYFutx DDCwnhRVPe5/tMOR+L/UItLWeYrZ/e7y7g588xp18Cc7Lie6OabLXQwP1WVBn1sX2oPD2s1K6uCVj 2ImrQd6EHV/HOCb4VehBZhqR8sYBl2bbN7kuxUtCs54Ns1chlrGDglBSw8pIHo5eqciIGSMYiJO7K Vdy4YzB20U+RB0AwtHIp2atwn94LYSz9ugEm/nt+uE7tb5QT2/9CUnYqsmOZjsfN+2b8nfS2Xubli k5uu2OPIgaGz7Cb/bFPQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dXQCj-0007Sx-0J; Tue, 18 Jul 2017 10:58:13 +0000 Received: from lelnx193.ext.ti.com ([198.47.27.77]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dXQCQ-00076K-C2 for linux-arm-kernel@lists.infradead.org; Tue, 18 Jul 2017 10:57:56 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id v6IAvScx030356; Tue, 18 Jul 2017 05:57:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1500375448; bh=NxQrd0atETk58557fc8JLYQvS1j66nlmp+lDdUBUO2I=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=HhN2f11CEQCkwgMzOuBY7rPp2ZF7/iI5ieKNbd3DC4SykccjhVrhpPzFHH8qbNlmo Oa/ClVBr7Wg5vc7nzNCgSL/1uUvYJcK5Lx+p93FgJbQwWpZbuMcONErH3R3R+kT3fm IELeRI3xDUhG8OMuz775y4K5DMJhZL3tw4gR3iXU= Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v6IAvSl7024138; Tue, 18 Jul 2017 05:57:28 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.294.0; Tue, 18 Jul 2017 05:57:28 -0500 Received: from ula0393675.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v6IAvGEF010100; Tue, 18 Jul 2017 05:57:25 -0500 From: Keerthy To: , Subject: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Date: Tue, 18 Jul 2017 16:27:14 +0530 Message-ID: <1500375436-9435-3-git-send-email-j-keerthy@ti.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1500375436-9435-1-git-send-email-j-keerthy@ti.com> References: <1500375436-9435-1-git-send-email-j-keerthy@ti.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170718_035754_596280_7CC0237E X-CRM114-Status: UNSURE ( 8.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, j-keerthy@ti.com, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, fcooper@ti.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Currently davinci_gpio_irq_setup return value is ignored. Handle the return value appropriately. Signed-off-by: Keerthy --- drivers/gpio/gpio-davinci.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index 2c88054..932f270 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -233,15 +233,23 @@ static int davinci_gpio_probe(struct platform_device *pdev) chips->regs[bank] = gpio_base + offset_array[bank]; ret = devm_gpiochip_add_data(dev, &chips->chip, chips); + if (ret) + goto err; + + platform_set_drvdata(pdev, chips); + ret = davinci_gpio_irq_setup(pdev); if (ret) { - ctrl_num = 0; - bank_base = 0; - return ret; + platform_set_drvdata(pdev, NULL); + goto err; } - platform_set_drvdata(pdev, chips); - davinci_gpio_irq_setup(pdev); return 0; + +err: + ctrl_num = 0; + bank_base = 0; + + return ret; } /*--------------------------------------------------------------------------*/