From patchwork Fri Jul 21 06:55:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 9856251 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6094560392 for ; Fri, 21 Jul 2017 06:57:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3F5C72876B for ; Fri, 21 Jul 2017 06:57:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 344972877C; Fri, 21 Jul 2017 06:57:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BB80B2876B for ; Fri, 21 Jul 2017 06:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=2fS6hRnZ3AsYszenoc3PZLmY6L8W8FWqs5+uL0bc1sk=; b=BM3CSh2x0vFrTABiVHJKdTQqu8 SmG1VzyUiU064aL8WQp+GQFiPhyeW4vSMOED7KT/8H6HdrHGPJ3CqIMeBQ/lSgvYT01sSSOeuikdF ytK+mjMmyor/wlTfeY0YaW+aQbQMo11+v9SfX/E7jieyLmtKtAwXYup1exTw8n9uZAWSdmGosICbb Gkl2VzI+x3FyBqSt9vmdRA0raG/gClZIpKtRfGH0HWqdQFfobDMzUpmdIDiYF2KnVCcIGE9p9xpXx W90umk4Lubl9gsYu0zonLXx6WZHhaSLkRzWcKHUF0cIUfN5sKgfRWOeLPBOXK5egjW7wscvKFF3p9 4byvorjA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dYRsT-0006bQ-8j; Fri, 21 Jul 2017 06:57:33 +0000 Received: from mail-wr0-x233.google.com ([2a00:1450:400c:c0c::233]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dYRrg-0005jq-OX for linux-arm-kernel@lists.infradead.org; Fri, 21 Jul 2017 06:56:47 +0000 Received: by mail-wr0-x233.google.com with SMTP id k71so25143620wrc.2 for ; Thu, 20 Jul 2017 23:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MMisM5mcorXGMuOn2g169zP8JloTy8BtSHmww7hbTCw=; b=J3TzJGcP0n7ARTPS7y6WVMURDc6yEwNPbj2efhkN7yTd8yh+613oAQqAdktNOkHeOU J6eT37Uc1E3cgnniyAw/W5lGKeayYnEz5q3IpGPsKlUtoWMxLnFKzcIlvDRR5/XWSavq aQEOZCI3koTOupwIXJ27N0FiRht24BPS0eEsk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MMisM5mcorXGMuOn2g169zP8JloTy8BtSHmww7hbTCw=; b=ti1UnAhYo+S2bojKL21ZjBerU96ZXJZnkQQhpcIjwquX1U/Qag2W9F/wRBfbtmM430 yfs/UfUonJQ7NXXteYCte9Z2sFIhk+pujHImHEPYC3x0RG2Cr9gm36tOxcK5Q2PM96Xh 22I3m1GFCwyYkOCPPOP5zJboz+yluCBUesOsVzhfTKkPSYebGXA/r+r7ZcQklv/3bS20 waluqgHh1TAds+WgWWo7BJIOh/Ri7aKichx4rmHNfBH9pKG+Y5TP3Yx+lonlUypThf5O pPbASlMPFG5YgAThG+OzeDPGko6HEUk5aTQaFdFBFt2NoXG03nc+aAOO9hb2ZH+XlvHN u6Fg== X-Gm-Message-State: AIVw113YhPTFTON4ugSvQzeGOmHUTu/hNbqS1LKu0Uk+IuarDuJy4Qzp NYgwmxWJXvCiy8X9 X-Received: by 10.223.135.29 with SMTP id a29mr8916858wra.138.1500620182585; Thu, 20 Jul 2017 23:56:22 -0700 (PDT) Received: from anup-HP-Compaq-8100-Elite-CMT-PC.dhcp.avagotech.net ([192.19.237.250]) by smtp.gmail.com with ESMTPSA id 77sm751684wmk.8.2017.07.20.23.56.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 20 Jul 2017 23:56:22 -0700 (PDT) From: Anup Patel To: Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Jassi Brar Subject: [PATCH v2 3/7] mailbox: bcm-flexrm-mailbox: Fix mask used in CMPL_START_ADDR_VALUE() Date: Fri, 21 Jul 2017 12:25:38 +0530 Message-Id: <1500620142-910-4-git-send-email-anup.patel@broadcom.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500620142-910-1-git-send-email-anup.patel@broadcom.com> References: <1500620142-910-1-git-send-email-anup.patel@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170720_235645_143039_EDB34F90 X-CRM114-Status: GOOD ( 10.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Florian Fainelli , Anup Patel , Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, stable@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The mask used in CMPL_START_ADDR_VALUE() should be 27bits instead of 26bits. This incorrect mask was causing completion writes to 40bits physical address fail. This patch fixes mask used in CMPL_START_ADDR_VALUE() macro. Fixes: dbc049eee730 ("mailbox: Add driver for Broadcom FlexRM ring manager") Signed-off-by: Anup Patel Reviewed-by: Ray Jui Reviewed-by: Scott Branden Cc: stable@vger.kernel.org --- drivers/mailbox/bcm-flexrm-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c index a0be2ea..46ad305 100644 --- a/drivers/mailbox/bcm-flexrm-mailbox.c +++ b/drivers/mailbox/bcm-flexrm-mailbox.c @@ -97,7 +97,7 @@ /* Register RING_CMPL_START_ADDR fields */ #define CMPL_START_ADDR_VALUE(pa) \ - ((u32)((((u64)(pa)) >> RING_CMPL_ALIGN_ORDER) & 0x03ffffff)) + ((u32)((((u64)(pa)) >> RING_CMPL_ALIGN_ORDER) & 0x07ffffff)) /* Register RING_CONTROL fields */ #define CONTROL_MASK_DISABLE_CONTROL 12