| Message ID | 1501137036-20155-2-git-send-email-vivek.gautam@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/26/2017 11:30 PM, Vivek Gautam wrote: > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/pmi8994.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi > index d3879a4e8076..3b04ca63c31e 100644 > --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi > @@ -8,6 +8,23 @@ > reg = <0x2 SPMI_USID>; > #address-cells = <1>; > #size-cells = <0>; > + > + pmi8994_gpios: gpios@c000 { > + compatible = "qcom,pmi8994-gpio"; Please also include the generic "qcom,spmi-gpio" compatible. We really don't need to add the "qcom,pmi8994-gpio" one to the driver right now so I would leave that out of the driver but leave it here in the dtsi file of course.
On Fri, Jul 28, 2017 at 2:30 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: > On 07/26/2017 11:30 PM, Vivek Gautam wrote: >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/pmi8994.dtsi | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi >> index d3879a4e8076..3b04ca63c31e 100644 >> --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi >> +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi >> @@ -8,6 +8,23 @@ >> reg = <0x2 SPMI_USID>; >> #address-cells = <1>; >> #size-cells = <0>; >> + >> + pmi8994_gpios: gpios@c000 { >> + compatible = "qcom,pmi8994-gpio"; > > > Please also include the generic "qcom,spmi-gpio" compatible. We really > don't need to add the "qcom,pmi8994-gpio" one to the driver right now so > I would leave that out of the driver but leave it here in the dtsi file > of course. Sure, will add the "qcom,spmi-gpio" compatible as well, and will drop the "qcom,pmi8994-gpio" from the driver. Thanks. regards Vivek > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi index d3879a4e8076..3b04ca63c31e 100644 --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi @@ -8,6 +8,23 @@ reg = <0x2 SPMI_USID>; #address-cells = <1>; #size-cells = <0>; + + pmi8994_gpios: gpios@c000 { + compatible = "qcom,pmi8994-gpio"; + reg = <0xc000>; + gpio-controller; + #gpio-cells = <2>; + interrupts = <2 0xc0 0 IRQ_TYPE_NONE>, + <2 0xc1 0 IRQ_TYPE_NONE>, + <2 0xc2 0 IRQ_TYPE_NONE>, + <2 0xc3 0 IRQ_TYPE_NONE>, + <2 0xc4 0 IRQ_TYPE_NONE>, + <2 0xc5 0 IRQ_TYPE_NONE>, + <2 0xc6 0 IRQ_TYPE_NONE>, + <2 0xc7 0 IRQ_TYPE_NONE>, + <2 0xc8 0 IRQ_TYPE_NONE>, + <2 0xc9 0 IRQ_TYPE_NONE>; + }; }; pmic@3 {
Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> --- arch/arm64/boot/dts/qcom/pmi8994.dtsi | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)