From patchwork Tue Aug 1 10:35:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 9874109 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4A170603B4 for ; Tue, 1 Aug 2017 10:38:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4866028173 for ; Tue, 1 Aug 2017 10:38:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3D4B9285DE; Tue, 1 Aug 2017 10:38:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 993B028684 for ; Tue, 1 Aug 2017 10:38:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=2fS6hRnZ3AsYszenoc3PZLmY6L8W8FWqs5+uL0bc1sk=; b=TJ4rbXg02nojWzLk53WERNTgbu GOw8NyiKk9xzJGM4ewTgaMfKkhwc8GHSaOz2Rfdqn9zYD9U1qBy31LBy4ZDxTBXvlvm5B1LRGuYi/ Waglccn71tHYHQzsKALe//6lJwrHb1gOHUd7KxCvx0eYH3SSwqT9lF20h4m8HzDKCH6CN/iX6kNlX 0VgjUsDLqCdZmbStwu9O2INbogoY2ncqGO2/ikMjAYmboQSRZ9xOo1p26WCobYWwHXBt5o8qH5vA3 +6kahvgfLFjsamgFrS1sjMeNcRaiX3PB+l/YtOZEpTzwDB9LdBKAFz0FMQXZtm6DvRGYwtB5OISIY N7bLmXLw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dcUYQ-0002a2-Oz; Tue, 01 Aug 2017 10:37:34 +0000 Received: from mail-qk0-x229.google.com ([2607:f8b0:400d:c09::229]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dcUXt-0001iw-JW for linux-arm-kernel@lists.infradead.org; Tue, 01 Aug 2017 10:37:10 +0000 Received: by mail-qk0-x229.google.com with SMTP id a77so6469604qkb.0 for ; Tue, 01 Aug 2017 03:36:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MMisM5mcorXGMuOn2g169zP8JloTy8BtSHmww7hbTCw=; b=Qnk6UveGo57+X4IJOBaRNR/3SuGsHK4TKTqV93bq8e6XpVnDcRk5ebQXfOwVGAjpq7 yOZ4PUjDjvZPnpSxCIL6GByYVI+9IKfcfvg5SHwQ95OoBAiQHQLeUDLAEn2LzXkLbYZL vsjPRJmEUYuP2jKXAIdzPBa0oMysbFlQ3oDXk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MMisM5mcorXGMuOn2g169zP8JloTy8BtSHmww7hbTCw=; b=C+a9QviIgTfYRRzMBCG9849FGfIcb/aYpuYpVlJzsO/7OquaM3OAtehcF9TkoA8acn u2AKhLC6i8ZqvguwuJIXBzjYzWA6hI9e+R3FelAVbamt0QSCS/eoUJLE29Fc68R/opEH RwP/P6UOfk+6LKzf/pTDI9lxZUI3pGqq2zYNq7s8LP6JFuHRb7XgBqx8JGCruY7ychV/ roQJhbVDFpE9hh/a0RYIAMQaAKik0iQmJsVh6K6EUjK7s/1o/Bq4chJG35Rv2wTCM+vq TioC7p6PnzvYnKPrBG1860lD5OxundruhZLzTxktW5/FSFXI33T1stFsVTbdqulUHl69 MJGw== X-Gm-Message-State: AIVw110GXkhPBkTopilyLlvYgg9w8NzD8AtltgH6wXdsqVw0j04rYO/H nM0Is2mMHLgAn+U7 X-Received: by 10.55.91.135 with SMTP id p129mr23512582qkb.32.1501583800258; Tue, 01 Aug 2017 03:36:40 -0700 (PDT) Received: from anup-HP-Compaq-8100-Elite-CMT-PC.dhcp.avagotech.net ([192.19.237.250]) by smtp.gmail.com with ESMTPSA id d14sm23961629qtd.21.2017.08.01.03.36.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 01 Aug 2017 03:36:39 -0700 (PDT) From: Anup Patel To: Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Jassi Brar Subject: [PATCH v3 3/5] mailbox: bcm-flexrm-mailbox: Fix mask used in CMPL_START_ADDR_VALUE() Date: Tue, 1 Aug 2017 16:05:52 +0530 Message-Id: <1501583754-31969-4-git-send-email-anup.patel@broadcom.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1501583754-31969-1-git-send-email-anup.patel@broadcom.com> References: <1501583754-31969-1-git-send-email-anup.patel@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170801_033702_663392_8774F42E X-CRM114-Status: GOOD ( 10.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Florian Fainelli , Anup Patel , Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, stable@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The mask used in CMPL_START_ADDR_VALUE() should be 27bits instead of 26bits. This incorrect mask was causing completion writes to 40bits physical address fail. This patch fixes mask used in CMPL_START_ADDR_VALUE() macro. Fixes: dbc049eee730 ("mailbox: Add driver for Broadcom FlexRM ring manager") Signed-off-by: Anup Patel Reviewed-by: Ray Jui Reviewed-by: Scott Branden Cc: stable@vger.kernel.org --- drivers/mailbox/bcm-flexrm-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c index a0be2ea..46ad305 100644 --- a/drivers/mailbox/bcm-flexrm-mailbox.c +++ b/drivers/mailbox/bcm-flexrm-mailbox.c @@ -97,7 +97,7 @@ /* Register RING_CMPL_START_ADDR fields */ #define CMPL_START_ADDR_VALUE(pa) \ - ((u32)((((u64)(pa)) >> RING_CMPL_ALIGN_ORDER) & 0x03ffffff)) + ((u32)((((u64)(pa)) >> RING_CMPL_ALIGN_ORDER) & 0x07ffffff)) /* Register RING_CONTROL fields */ #define CONTROL_MASK_DISABLE_CONTROL 12