From patchwork Tue Aug 1 10:37:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 9874191 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 377B860365 for ; Tue, 1 Aug 2017 10:43:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 447162868B for ; Tue, 1 Aug 2017 10:43:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 393D22869A; Tue, 1 Aug 2017 10:43:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 74F512868B for ; Tue, 1 Aug 2017 10:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=xnjH6RBAJeG2k+qJZuYBGTW4qMgUUEFWtR3nyDYoKL0=; b=qzcyqQZz3JqYIRHpKUHFjHmxNl Y6owU4HlyB4G4+mzPbxfHxfwPaf94axvBuTP7M23EPtzUQSP+fAiyDN+S8oV8IclXYdYrgSuDVE1s sB/oW5NRdB7dRfd4iCmzV/rEh5p4GLCAnWE8h3GjypI5t7iFu16q9UWao7ql23NKmxO9aZbEpgMSj lVF3aaCcfIt3Sb+ZrWJX1kJ76mJPt8cSZKLZSAWRLMp1TfKOBc/7ZyUwae3ToxOk/cck+Xl7JkwWk 58/u2J7lQyN4LSFFpQCf/Yaw771AyG0fL0mKHDkAqtjdNPigy0rbYeQojXyrOLA/wevAkyWwvOrJl C8dDtLzA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dcUdn-0008I4-Rd; Tue, 01 Aug 2017 10:43:07 +0000 Received: from mail-qt0-x230.google.com ([2607:f8b0:400d:c0d::230]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dcUbu-00069h-Mc for linux-arm-kernel@lists.infradead.org; Tue, 01 Aug 2017 10:42:17 +0000 Received: by mail-qt0-x230.google.com with SMTP id p3so6436412qtg.2 for ; Tue, 01 Aug 2017 03:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6IXM3WaE8YoLReAghMpVjuaAz2qOeesBXGpFIjAUlSQ=; b=IZg8gmFN73n9iNax8yHUWhswA3InPf/WveDAOgU7cPHYTR4T6otJRt5pLsFYx1M0N8 VIfguiGwKfz28vRchJ+sc+3lVNBp1ks2pAlLZBJohEYknTO14MJ7+K4QmFuJpE1FfiOr 6zF2yrh5ediBPpnnHMjSyVw3P5+8IdfjCp/XA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6IXM3WaE8YoLReAghMpVjuaAz2qOeesBXGpFIjAUlSQ=; b=sK1dgUZcE03E6x8ct0VHdDxw5tce/nz/GI0Xi/XFCoR0dQXZemMNFyhrIv0TBZCh+A DaqYQYc+181xedA+sxf/Qp1jAHUqCzshvM/kS4qJaUEL4dfNUNaLdcAK1CEyRaEpjTMH b1SvaI/dZOo7fpOM2jfy9WaYTg07ovljjHoxiiWy2bgjS1c/paoTKgcODaGKZLBLEiiE OCG81zeCJ9YjBQudlHgYAJeCqNabEc/goBxvPnazbEl6JuhTgmUBcqHTgpSO7wVBEHxE VvNlmmVtY/nLinvf65CC7NgQt5LLYGO45lAXbmVs9BQsqehq8Nda2WJqPKiCJwD3LrVO 2WKA== X-Gm-Message-State: AIVw111St3+g+OCUqeK0gzgU76wXd2UwNGgEzYwK+TyxJqXXvEs9GDlZ S6ck4nb0eZfAytds X-Received: by 10.237.47.133 with SMTP id m5mr24703148qtd.246.1501584049447; Tue, 01 Aug 2017 03:40:49 -0700 (PDT) Received: from anup-HP-Compaq-8100-Elite-CMT-PC.dhcp.avagotech.net ([192.19.237.250]) by smtp.gmail.com with ESMTPSA id e32sm21784162qtb.63.2017.08.01.03.40.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 01 Aug 2017 03:40:49 -0700 (PDT) From: Anup Patel To: Rob Herring , Mark Rutland , Vinod Koul , Dan Williams Subject: [PATCH v2 15/16] dmaengine: bcm-sba-raid: Add debugfs support Date: Tue, 1 Aug 2017 16:07:59 +0530 Message-Id: <1501583880-32072-16-git-send-email-anup.patel@broadcom.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1501583880-32072-1-git-send-email-anup.patel@broadcom.com> References: <1501583880-32072-1-git-send-email-anup.patel@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170801_034112_360251_E97B72D5 X-CRM114-Status: GOOD ( 16.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Florian Fainelli , Anup Patel , Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds debugfs support to report stats via debugfs which in-turn will help debug hang or error situations. Signed-off-by: Anup Patel Reviewed-by: Ray Jui Reviewed-by: Scott Branden --- drivers/dma/bcm-sba-raid.c | 82 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 81 insertions(+), 1 deletion(-) diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c index f0a0e80..f9d110c 100644 --- a/drivers/dma/bcm-sba-raid.c +++ b/drivers/dma/bcm-sba-raid.c @@ -36,6 +36,7 @@ */ #include +#include #include #include #include @@ -162,6 +163,9 @@ struct sba_device { struct list_head reqs_completed_list; struct list_head reqs_aborted_list; struct list_head reqs_free_list; + /* DebugFS directory entries */ + struct dentry *root; + struct dentry *stats; }; /* ====== Command helper routines ===== */ @@ -486,6 +490,45 @@ static void sba_process_received_request(struct sba_device *sba, } } +static void sba_write_stats_in_seqfile(struct sba_device *sba, + struct seq_file *file) +{ + unsigned long flags; + struct sba_request *req; + u32 free_count = 0, alloced_count = 0, pending_count = 0; + u32 active_count = 0, aborted_count = 0, completed_count = 0; + + spin_lock_irqsave(&sba->reqs_lock, flags); + + list_for_each_entry(req, &sba->reqs_free_list, node) + free_count++; + + list_for_each_entry(req, &sba->reqs_alloc_list, node) + alloced_count++; + + list_for_each_entry(req, &sba->reqs_pending_list, node) + pending_count++; + + list_for_each_entry(req, &sba->reqs_active_list, node) + active_count++; + + list_for_each_entry(req, &sba->reqs_aborted_list, node) + aborted_count++; + + list_for_each_entry(req, &sba->reqs_completed_list, node) + completed_count++; + + spin_unlock_irqrestore(&sba->reqs_lock, flags); + + seq_printf(file, "maximum requests = %d\n", sba->max_req); + seq_printf(file, "free requests = %d\n", free_count); + seq_printf(file, "alloced requests = %d\n", alloced_count); + seq_printf(file, "pending requests = %d\n", pending_count); + seq_printf(file, "active requests = %d\n", active_count); + seq_printf(file, "aborted requests = %d\n", aborted_count); + seq_printf(file, "completed requests = %d\n", completed_count); +} + /* ====== DMAENGINE callbacks ===== */ static void sba_free_chan_resources(struct dma_chan *dchan) @@ -1451,6 +1494,19 @@ static void sba_receive_message(struct mbox_client *cl, void *msg) sba_process_received_request(sba, req); } +/* ====== Debugfs callbacks ====== */ + +static int sba_debugfs_stats_show(struct seq_file *file, void *offset) +{ + struct platform_device *pdev = to_platform_device(file->private); + struct sba_device *sba = platform_get_drvdata(pdev); + + /* Write stats in file */ + sba_write_stats_in_seqfile(sba, file); + + return 0; +} + /* ====== Platform driver routines ===== */ static int sba_prealloc_channel_resources(struct sba_device *sba) @@ -1721,10 +1777,30 @@ static int sba_probe(struct platform_device *pdev) if (ret) goto fail_free_mchans; + /* Check availability of debugfs */ + if (!debugfs_initialized()) + goto skip_debugfs; + + /* Create debugfs root entry */ + sba->root = debugfs_create_dir(dev_name(sba->dev), NULL); + if (IS_ERR_OR_NULL(sba->root)) { + ret = PTR_ERR_OR_ZERO(sba->root); + goto fail_free_resources; + } + + /* Create debugfs stats entry */ + sba->stats = debugfs_create_devm_seqfile(sba->dev, "stats", sba->root, + sba_debugfs_stats_show); + if (IS_ERR_OR_NULL(sba->stats)) { + ret = PTR_ERR_OR_ZERO(sba->stats); + goto fail_free_debugfs_root; + } +skip_debugfs: + /* Register DMA device with Linux async framework */ ret = sba_async_register(sba); if (ret) - goto fail_free_resources; + goto fail_free_debugfs_root; /* Print device info */ dev_info(sba->dev, "%s using SBAv%d and %d mailbox channels", @@ -1733,6 +1809,8 @@ static int sba_probe(struct platform_device *pdev) return 0; +fail_free_debugfs_root: + debugfs_remove_recursive(sba->root); fail_free_resources: sba_freeup_channel_resources(sba); fail_free_mchans: @@ -1748,6 +1826,8 @@ static int sba_remove(struct platform_device *pdev) dma_async_device_unregister(&sba->dma_dev); + debugfs_remove_recursive(sba->root); + sba_freeup_channel_resources(sba); for (i = 0; i < sba->mchans_count; i++)