diff mbox

ARM: multi_v7_defconfig: Enable BQ32000 RTC driver

Message ID 1502975345-4209-1-git-send-email-biju.das@bp.renesas.com (mailing list archive)
State New, archived
Headers show

Commit Message

Biju Das Aug. 17, 2017, 1:09 p.m. UTC
The iWave RZ/G1M Q7 SOM supports RTC (TI BQ32000).
To increase hardware support enable the driver in the
multi_v7_defconfig multiplatform configuration.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
This patch is tested against linux-next tag next-20170817 as well as 
renesas-dev tag renesas-devel-20170815-v4.13-rc5 .

 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Horman Aug. 18, 2017, 8:06 a.m. UTC | #1
On Thu, Aug 17, 2017 at 02:09:05PM +0100, Biju Das wrote:
> The iWave RZ/G1M Q7 SOM supports RTC (TI BQ32000).
> To increase hardware support enable the driver in the
> multi_v7_defconfig multiplatform configuration.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> This patch is tested against linux-next tag next-20170817 as well as 
> renesas-dev tag renesas-devel-20170815-v4.13-rc5 .
> 
>  arch/arm/configs/multi_v7_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 18e1f80..02dc373 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -766,6 +766,7 @@ CONFIG_RTC_DRV_MAX8997=m
>  CONFIG_RTC_DRV_MAX77686=y
>  CONFIG_RTC_DRV_RK808=m
>  CONFIG_RTC_DRV_RS5C372=m
> +CONFIG_RTC_DRV_BQ32K=y

My assumption is that multi_v7_defconfig produces a very large kernel image
and that we should try to avoid making it larger by using modules where
possible. Is it practical to enable this option as a module (m) rather than
a built-in (y)?

>  CONFIG_RTC_DRV_PALMAS=y
>  CONFIG_RTC_DRV_ST_LPC=y
>  CONFIG_RTC_DRV_TWL4030=y
> -- 
> 1.9.1
>
Biju Das Aug. 18, 2017, 10:25 a.m. UTC | #2
> -----Original Message-----
> From: Simon Horman [mailto:horms@verge.net.au]
> Sent: 18 August 2017 09:06
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Russell King <linux@armlinux.org.uk>; Magnus Damm
> <magnus.damm@gmail.com>; Fabrizio Castro
> <fabrizio.castro@bp.renesas.com>; Chris Paterson
> <Chris.Paterson2@renesas.com>; linux-renesas-soc@vger.kernel.org; linux-
> arm-kernel@lists.infradead.org
> Subject: Re: [PATCH ] ARM: multi_v7_defconfig: Enable BQ32000 RTC driver
>
> On Thu, Aug 17, 2017 at 02:09:05PM +0100, Biju Das wrote:
> > The iWave RZ/G1M Q7 SOM supports RTC (TI BQ32000).
> > To increase hardware support enable the driver in the
> > multi_v7_defconfig multiplatform configuration.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > This patch is tested against linux-next tag next-20170817 as well as
> > renesas-dev tag renesas-devel-20170815-v4.13-rc5 .
> >
> >  arch/arm/configs/multi_v7_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/multi_v7_defconfig
> > b/arch/arm/configs/multi_v7_defconfig
> > index 18e1f80..02dc373 100644
> > --- a/arch/arm/configs/multi_v7_defconfig
> > +++ b/arch/arm/configs/multi_v7_defconfig
> > @@ -766,6 +766,7 @@ CONFIG_RTC_DRV_MAX8997=m
> > CONFIG_RTC_DRV_MAX77686=y  CONFIG_RTC_DRV_RK808=m
> > CONFIG_RTC_DRV_RS5C372=m
> > +CONFIG_RTC_DRV_BQ32K=y
>
> My assumption is that multi_v7_defconfig produces a very large kernel image
> and that we should try to avoid making it larger by using modules where
> possible. Is it practical to enable this option as a module (m) rather than a built-
> in (y)?

I have tested this as module and it works. OK I will send v2.


> >  CONFIG_RTC_DRV_PALMAS=y
> >  CONFIG_RTC_DRV_ST_LPC=y
> >  CONFIG_RTC_DRV_TWL4030=y
> > --
> > 1.9.1
> >



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff mbox

Patch

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 18e1f80..02dc373 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -766,6 +766,7 @@  CONFIG_RTC_DRV_MAX8997=m
 CONFIG_RTC_DRV_MAX77686=y
 CONFIG_RTC_DRV_RK808=m
 CONFIG_RTC_DRV_RS5C372=m
+CONFIG_RTC_DRV_BQ32K=y
 CONFIG_RTC_DRV_PALMAS=y
 CONFIG_RTC_DRV_ST_LPC=y
 CONFIG_RTC_DRV_TWL4030=y