From patchwork Tue Aug 22 09:56:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 9914689 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3C253603FF for ; Tue, 22 Aug 2017 09:58:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4B60928788 for ; Tue, 22 Aug 2017 09:58:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 400412885A; Tue, 22 Aug 2017 09:58:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C096528788 for ; Tue, 22 Aug 2017 09:58:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=HSBYYM7rni9XfJ9BAG/LtbvoSxjpE5K3ViqyV1K6RHU=; b=VmGcTbRWftg9jtB1krQ11Jyf8R 5qdiBjV4SDMpSH5d11AbW43SkctR3fv9NwYW/KQ5D4oEeDbfYG3xVPQt/iiGIxdxCFHYuq1wkT+c3 DwYsG3r2Fjzc6E1sU0HBgW8loQUcs3kUIjaHbkZzN6hq8ZNZ7Qb1nB2YMYZX61HMLBHb5B7g2w/61 OyAs4WKyRB9kLhKWJAnauwuQbaNJvgN742wxHrYavyRIyS3fHzpMrzlwHdHnq2Vb0KBDTdBRxMCcY PKEEjA/UqI0GzTytMc0Sy1AVCkeUUlBfwWcfhOVxOvRmdzZOjTfpXoHrvYdjZBar6yGEF7wyIQ4wC OLOwpc+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dk5wy-0006Zr-Jp; Tue, 22 Aug 2017 09:58:20 +0000 Received: from mail-wr0-x22f.google.com ([2a00:1450:400c:c0c::22f]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dk5wY-00061R-Dm for linux-arm-kernel@lists.infradead.org; Tue, 22 Aug 2017 09:58:01 +0000 Received: by mail-wr0-x22f.google.com with SMTP id z91so118757937wrc.4 for ; Tue, 22 Aug 2017 02:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uiLFN68ay51CSOl/fUXfqDOc7Qgbj2P5aWAN94AqlY0=; b=XH8PBgmWpzfCp+79bQ74FEX4Zayh8SQJ44UO8WAIQIopd+2XjXVQOC2OB2l56tYtPT YuQ73sjgkswDbKaQfqq2yRrlhR2iLaJndMYHSJ1G7JDOQF0r1dcXOFHLlXqH13IQy+OM BmOqbDmVy2kALtfj+Hx+AH8Arz+NYQayq/eYU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uiLFN68ay51CSOl/fUXfqDOc7Qgbj2P5aWAN94AqlY0=; b=AZIQlkZFiO4TtCK/K8l53Yrv/t3v4Ss7wUnDm7/ymqHYBr1r2W1p8JTXn2du2mfiJg nAg8jm/Ym9UvooiWcQh+XwMfAWbcfkOfOM4jfsm36+V4RDaR1jg6j2qaBh67ARc92+2/ Fz5oeH4XxuGM+TU1eZL8nE9gkvggUsRtfxkOVZy7j7MpiwQnqYJMYpUoEp8T2c/zJLVG JWG5DPwwAdp+QedFqP8AK3jXueF6Ld7m9Wtwum7bk0EaD038yR/Z6eiQqcooGa6oJhMR tssNOOFWIwQyT1C7geG+9rFiY8Xb4mMU9ic+qE8ro1unX57bLZW0h1NiFrcmBTw1bRX7 BqcA== X-Gm-Message-State: AHYfb5g+1KSQwp2dhAY6n29pH+qNjegeEsuVQIJXFNAKA/VEPy4QzY2H hpfhCup9/9h/0nSC X-Received: by 10.28.147.10 with SMTP id v10mr71013wmd.9.1503395852664; Tue, 22 Aug 2017 02:57:32 -0700 (PDT) Received: from anup-HP-Compaq-8100-Elite-CMT-PC.dhcp.avagotech.net ([192.19.237.250]) by smtp.gmail.com with ESMTPSA id e137sm12257913wma.29.2017.08.22.02.57.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Aug 2017 02:57:30 -0700 (PDT) From: Anup Patel To: Vinod Koul , Dan Williams Subject: [PATCH v3 01/17] dmaengine: bcm-sba-raid: Minor improvments in comments Date: Tue, 22 Aug 2017 15:26:50 +0530 Message-Id: <1503395827-19428-2-git-send-email-anup.patel@broadcom.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1503395827-19428-1-git-send-email-anup.patel@broadcom.com> References: <1503395827-19428-1-git-send-email-anup.patel@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170822_025755_093562_ED2899BA X-CRM114-Status: GOOD ( 11.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Anup Patel , Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch does following improvments to comments: 1. Make section comments consistent across the driver by avoiding " SBA " in some of the comments 2. Add/update few more section comments Signed-off-by: Anup Patel --- drivers/dma/bcm-sba-raid.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c index e41bbc7..76999b7 100644 --- a/drivers/dma/bcm-sba-raid.c +++ b/drivers/dma/bcm-sba-raid.c @@ -48,7 +48,8 @@ #include "dmaengine.h" -/* SBA command related defines */ +/* ====== Driver macros and defines ===== */ + #define SBA_TYPE_SHIFT 48 #define SBA_TYPE_MASK GENMASK(1, 0) #define SBA_TYPE_A 0x0 @@ -88,6 +89,8 @@ #define to_sba_device(dchan) \ container_of(dchan, struct sba_device, dma_chan) +/* ===== Driver data structures ===== */ + enum sba_request_state { SBA_REQUEST_STATE_FREE = 1, SBA_REQUEST_STATE_ALLOCED = 2, @@ -164,7 +167,7 @@ struct sba_device { int reqs_free_count; }; -/* ====== SBA command helper routines ===== */ +/* ====== Command helper routines ===== */ static inline u64 __pure sba_cmd_enc(u64 cmd, u32 val, u32 shift, u32 mask) { @@ -196,7 +199,7 @@ static inline u32 __pure sba_cmd_pq_c_mdata(u32 d, u32 b1, u32 b0) ((d & SBA_C_MDATA_DNUM_MASK) << SBA_C_MDATA_DNUM_SHIFT); } -/* ====== Channel resource management routines ===== */ +/* ====== General helper routines ===== */ static struct sba_request *sba_alloc_request(struct sba_device *sba) {