Message ID | 1506192619-15503-1-git-send-email-shankerd@codeaurora.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 30978602CB for <patchwork-linux-arm@patchwork.kernel.org>; Sat, 23 Sep 2017 18:51:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1F96C28F98 for <patchwork-linux-arm@patchwork.kernel.org>; Sat, 23 Sep 2017 18:51:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 14524292A4; Sat, 23 Sep 2017 18:51:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 00AD729034 for <patchwork-linux-arm@patchwork.kernel.org>; Sat, 23 Sep 2017 18:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=ELBlOSRzIPjWYQ1P+gTQKvz3aXKzOOu7CfSG5NO+XK0=; b=P53 VI6RSFp+nBB0UxjeHruBTAMpSISpWSWw+/KoXmSmxi8h1AQgKXxUyls9fxiEb8y+ypQDymqr9dKyr vxz/agjFKV738w1CMNX7GDFa1sGug4RY1USmEC1prpY+qaUEQ+CdHaexaNMbmkIpq4ScFu1cvF5OL m/aWkNjk7AY3oSkU3X1GUB4wQzI/cNm2AQ07kz03VtuMbLXfgg6n+Bfk4CNGSjUrCXqSZxr8WWAKP UPCQ4fW6OxYNBq7KvAYncDuZZDr4veHErAvRP4wyrVjLF+XOJF64c/6F+qXhY7fEKcwPanqbSAdW2 t76y4IKmsYZ/PWeUyo0WHHYk/5KWUAQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dvpVp-0004R1-8N; Sat, 23 Sep 2017 18:50:49 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dvpVk-0004Lr-8v for linux-arm-kernel@lists.infradead.org; Sat, 23 Sep 2017 18:50:46 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 00FF960718; Sat, 23 Sep 2017 18:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1506192623; bh=eZTNuiWxg3BkdM0BYZzCa3yYPbY8Va9Yw2tSufMl3cw=; h=From:To:Cc:Subject:Date:From; b=BTlUy6K3CDHbQ/PixUhLl9o4VM2KF533L1IHJEZhrG5MCXTrAOV5pcPOfIvvGWEw3 2DCBbCLazV9FlHby+s/77o6LlSYfWG8SLWbCXFi6qhG41Ep8kd9wL5nDPp3RgWcfD7 RTVsFcKJ8kgoOu7X/jfK6W04/sDmVmQEx4vm7FEI= Received: from shankerd-ubuntu.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: shankerd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B391F602A8; Sat, 23 Sep 2017 18:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1506192622; bh=eZTNuiWxg3BkdM0BYZzCa3yYPbY8Va9Yw2tSufMl3cw=; h=From:To:Cc:Subject:Date:From; b=awgGEVJp79Fo1HwlcDBC6JO3r4Jori5ljupkrJPSSJ4gOa1qkEUoTC9qmur73DBJR SBLy4Fqt1CcmCrqolmpVxZBmbMAqOpYPnbQW1K0VcQGwh3jXDxheo216q5Q/mFx+Mg q+tiorU5t7IsIDcmaXZ6ujLf1G5kIThKeyNhcfRM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B391F602A8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=shankerd@codeaurora.org From: Shanker Donthineni <shankerd@codeaurora.org> To: Marc Zyngier <marc.zyngier@arm.com>, linux-kernel <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: [PATCH] irqchip/gic-v3-its: Fix the incorrect BUG_ON in its_init_vpe_domain() Date: Sat, 23 Sep 2017 13:50:19 -0500 Message-Id: <1506192619-15503-1-git-send-email-shankerd@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170923_115044_428324_D8D56FFC X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>, Shanker Donthineni <shankerd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index e8d8934..e3a59f4 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -2851,7 +2851,7 @@ static int its_init_vpe_domain(void) return -ENOMEM; } - BUG_ON(entries != vpe_proxy.dev->nr_ites); + BUG_ON(entries > vpe_proxy.dev->nr_ites); raw_spin_lock_init(&vpe_proxy.lock); vpe_proxy.next_victim = 0;
The driver probe path hits 'BUG_ON(entries != vpe_proxy.dev->nr_ites)' on systems where it has VLPI capability, doesn't support direct LPI feature and boot with a single CPU. Relax the BUG_ON() condition to fix the issue. Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org> --- drivers/irqchip/irq-gic-v3-its.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)