| Message ID | 1507205511-23048-2-git-send-email-andrzej.p@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Thursday 05 October 2017 05:41 PM, Andrzej Pietrasiewicz wrote: > Some quirky UDCs (like dwc3 on exynos) need to have heir phys calibrated %s/heir/their > e.g. for using super speed. The commit log should also include when phy calibrate should be used and why existing API's is not sufficient for initializing/calibrating the phy. Thanks Kishon > > Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com> > --- > drivers/phy/phy-core.c | 15 +++++++++++++++ > include/linux/phy/phy.h | 10 ++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > index a268f4d..b4964b0 100644 > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > @@ -372,6 +372,21 @@ int phy_reset(struct phy *phy) > } > EXPORT_SYMBOL_GPL(phy_reset); > > +int phy_calibrate(struct phy *phy) > +{ > + int ret; > + > + if (!phy || !phy->ops->calibrate) > + return 0; > + > + mutex_lock(&phy->mutex); > + ret = phy->ops->calibrate(phy); > + mutex_unlock(&phy->mutex); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(phy_calibrate); > + > /** > * _of_phy_get() - lookup and obtain a reference to a phy by phandle > * @np: device_node for which to get the phy > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index e694d40..87580c8 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -39,6 +39,7 @@ enum phy_mode { > * @power_off: powering off the phy > * @set_mode: set the mode of the phy > * @reset: resetting the phy > + * @calibrate: calibrate the phy > * @owner: the module owner containing the ops > */ > struct phy_ops { > @@ -48,6 +49,7 @@ struct phy_ops { > int (*power_off)(struct phy *phy); > int (*set_mode)(struct phy *phy, enum phy_mode mode); > int (*reset)(struct phy *phy); > + int (*calibrate)(struct phy *phy); > struct module *owner; > }; > > @@ -141,6 +143,7 @@ static inline void *phy_get_drvdata(struct phy *phy) > int phy_power_off(struct phy *phy); > int phy_set_mode(struct phy *phy, enum phy_mode mode); > int phy_reset(struct phy *phy); > +int phy_calibrate(struct phy *phy); > static inline int phy_get_bus_width(struct phy *phy) > { > return phy->attrs.bus_width; > @@ -262,6 +265,13 @@ static inline int phy_reset(struct phy *phy) > return -ENOSYS; > } > > +static inline int phy_calibrate(struct phy *phy) > +{ > + if (!phy) > + return 0; > + return -ENOSYS; > +} > + > static inline int phy_get_bus_width(struct phy *phy) > { > return -ENOSYS; >
Hi all, This is the fourth version of patches in this thread. The series fixes problems with enumerating of SuperSpeed devices on an Odroid XU3. There was a patch series from Vivek Gautam in circulation, but it got lost somehow. Please see: https://lkml.org/lkml/2014/9/2/166 https://lkml.org/lkml/2015/2/2/257 I adapted his patch so that it does not use a hacky solution to force additional initialization in order for calibration to happen. With this patch enumeration happens correctly and a super speed device is recognized as such. Changes since v3: - improved the commit message in phy_calibrate() commit (as suggested by Kishon) - rebased onto v4.14-rc4 Changes since v2: - exported the "calibrate_phy" symbol Changes since v1: - added calibrate() callback to phy - used calibrate() instead of reset() to trigger the calibration Andrzej Pietrasiewicz (1): drivers: phy: add calibrate method Vivek Gautam (1): phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800 drivers/phy/phy-core.c | 15 +++ drivers/phy/samsung/phy-exynos5-usbdrd.c | 183 +++++++++++++++++++++++++++++++ drivers/usb/dwc3/core.c | 7 +- include/linux/phy/phy.h | 10 ++ 4 files changed, 213 insertions(+), 2 deletions(-)
On Monday 09 October 2017 05:30 PM, Andrzej Pietrasiewicz wrote: > Hi all, > > This is the fourth version of patches in this thread. > > The series fixes problems with enumerating of SuperSpeed devices > on an Odroid XU3. There was a patch series from Vivek Gautam in > circulation, but it got lost somehow. Please see: > > https://lkml.org/lkml/2014/9/2/166 > https://lkml.org/lkml/2015/2/2/257 > > I adapted his patch so that it does not use a hacky solution to force > additional initialization in order for calibration to happen. > With this patch enumeration happens correctly and a super speed device > is recognized as such. > > Changes since v3: > > - improved the commit message in phy_calibrate() commit > (as suggested by Kishon) > - rebased onto v4.14-rc4 merged, thanks! -Kishon > > Changes since v2: > > - exported the "calibrate_phy" symbol > > Changes since v1: > > - added calibrate() callback to phy > - used calibrate() instead of reset() to trigger the calibration > > Andrzej Pietrasiewicz (1): > drivers: phy: add calibrate method > > Vivek Gautam (1): > phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800 > > drivers/phy/phy-core.c | 15 +++ > drivers/phy/samsung/phy-exynos5-usbdrd.c | 183 +++++++++++++++++++++++++++++++ > drivers/usb/dwc3/core.c | 7 +- > include/linux/phy/phy.h | 10 ++ > 4 files changed, 213 insertions(+), 2 deletions(-) >
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index a268f4d..b4964b0 100644 --- a/drivers/phy/phy-core.c +++ b/drivers/phy/phy-core.c @@ -372,6 +372,21 @@ int phy_reset(struct phy *phy) } EXPORT_SYMBOL_GPL(phy_reset); +int phy_calibrate(struct phy *phy) +{ + int ret; + + if (!phy || !phy->ops->calibrate) + return 0; + + mutex_lock(&phy->mutex); + ret = phy->ops->calibrate(phy); + mutex_unlock(&phy->mutex); + + return ret; +} +EXPORT_SYMBOL_GPL(phy_calibrate); + /** * _of_phy_get() - lookup and obtain a reference to a phy by phandle * @np: device_node for which to get the phy diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h index e694d40..87580c8 100644 --- a/include/linux/phy/phy.h +++ b/include/linux/phy/phy.h @@ -39,6 +39,7 @@ enum phy_mode { * @power_off: powering off the phy * @set_mode: set the mode of the phy * @reset: resetting the phy + * @calibrate: calibrate the phy * @owner: the module owner containing the ops */ struct phy_ops { @@ -48,6 +49,7 @@ struct phy_ops { int (*power_off)(struct phy *phy); int (*set_mode)(struct phy *phy, enum phy_mode mode); int (*reset)(struct phy *phy); + int (*calibrate)(struct phy *phy); struct module *owner; }; @@ -141,6 +143,7 @@ static inline void *phy_get_drvdata(struct phy *phy) int phy_power_off(struct phy *phy); int phy_set_mode(struct phy *phy, enum phy_mode mode); int phy_reset(struct phy *phy); +int phy_calibrate(struct phy *phy); static inline int phy_get_bus_width(struct phy *phy) { return phy->attrs.bus_width; @@ -262,6 +265,13 @@ static inline int phy_reset(struct phy *phy) return -ENOSYS; } +static inline int phy_calibrate(struct phy *phy) +{ + if (!phy) + return 0; + return -ENOSYS; +} + static inline int phy_get_bus_width(struct phy *phy) { return -ENOSYS;
Some quirky UDCs (like dwc3 on exynos) need to have heir phys calibrated e.g. for using super speed. Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com> --- drivers/phy/phy-core.c | 15 +++++++++++++++ include/linux/phy/phy.h | 10 ++++++++++ 2 files changed, 25 insertions(+)