From patchwork Wed Oct 11 18:48:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 10000335 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6A39C60216 for ; Wed, 11 Oct 2017 18:49:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 595FB25F3E for ; Wed, 11 Oct 2017 18:49:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4DA4628A08; Wed, 11 Oct 2017 18:49:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E3BD225F3E for ; Wed, 11 Oct 2017 18:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x6KFyNRbCOF5D2iX8Farq31NpoyZB5acn04B2/yi6f8=; b=TqNSP21/tQBYBg 68ffsXUlk0YVTm9d6ut0Bf933YwSGAo0LbhzTeK9ji85fzTU8CA0t04VHdUnYgQeNrZb8SOyY18yH TCb9flk3PlPE5+FevgB9jkNlVgwBZHqRQQEIqhYl2vGxXKPsna8YOaczkQgZBPU4+++rc7drnKl7m VBOl+OKanfyTbY+lcXIOR4LOQvma4YcKcx8XFtlGhqe3OYmC3pg1/M/kbnSMlhgjBtCEbc9YhEBaq DZR4tvOI/IbK+ufOR0ipazPaM+eWfnh1RNa8Vbepmcd13sFKhKkyMfgzJp66/azC6wGd8OG+r1Xuf EGhVXHVvXTIdNqUnhVxg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1e2M3z-0003NB-8s; Wed, 11 Oct 2017 18:49:03 +0000 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1e2M3v-0003JM-Tk for linux-arm-kernel@lists.infradead.org; Wed, 11 Oct 2017 18:49:01 +0000 Received: by mail-pf0-x243.google.com with SMTP id i23so3016689pfi.2 for ; Wed, 11 Oct 2017 11:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=Kg8gqCdTvHlRaY9L/yr0ozb9Wv1HDAfNCAEQSP8qmPo=; b=Zo7oyn3GoFPUa4XIQJdE0avlfpopnfqcfD8VH3NBqXj8a4Z3ZHXpMiMf8kRZwgLm/P W8ublA4/8OklAf0mFbkcww5HjxS1eCjw0OvwNSRYFfkN6RDyiZab6F2mr/vQq19yP7B+ 2ciTafATuVRJcJFdmiFfdlKIubxc+O9ak5KL8fxHR8tYGtKbOfGWxm2jM7UgC4C+wYms S3Bnnq6f1LBwCGyZMm8UuCJR+k43OYIGfh2yfP/ldVg579WdYbE+Sjslb0A3GKChL/q9 XlSU5jMtNHIpkDhk8QdhviS6lkL3OKEw3B24g4n7RJCCMTb4CEjZgn9urt8itbN5XWRj S/aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=Kg8gqCdTvHlRaY9L/yr0ozb9Wv1HDAfNCAEQSP8qmPo=; b=OKyexlUWeWGPk8bzon9cPNqeUuqa2QFzJTl5vdsZbKntPRbSYyEm10oG/8aaT1yfSn ZaPXheWOsjz0S2GnnIxplJf/V4gvRYP/rFrYFRLWld/O53fN4ntpzVWmMgxgjcd3gjIF Bs3FLk6nKnfMoLM/QsXaWDZOpcq8gexshQk/1wsvVbAOVu3n5r1vUVgWQrVY61lM1svD oUplEpkVzqzDEwSFBjggoHCYsUpB/r9KNA684u3k8wpVECOYaQl0OMC/iCUKvR9TwH6h gyObP5T8ZHP2jSsOEKO61YtgrfJrREfmZbZShd/UkWxjmgFhghLZBnuXfn1xdZgmjR97 3l1Q== X-Gm-Message-State: AMCzsaXyJjjw1QxDdqb5nM/WIelFzB3hMqPZ+9kXfZeZsy8CsCOSguPz Y/3rGIe/EmKzK7zi19Uaffk= X-Google-Smtp-Source: AOwi7QBzSTW4ZP+hfG3yHjxPZjYrJ4+lrJUG9BZo5erbtWHyrSfPWLEoGtPgRPTlKnqbtV1thFiVVA== X-Received: by 10.99.117.29 with SMTP id q29mr431141pgc.61.1507747719240; Wed, 11 Oct 2017 11:48:39 -0700 (PDT) Received: from ?IPv6:2620:15c:2c1:100:64e9:5de2:ce96:928a? ([2620:15c:2c1:100:64e9:5de2:ce96:928a]) by smtp.googlemail.com with ESMTPSA id g24sm27388709pfk.0.2017.10.11.11.48.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Oct 2017 11:48:38 -0700 (PDT) Message-ID: <1507747717.31614.28.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: next: arm64: LTP sendto01 test causes system crash in ilp32 mode From: Eric Dumazet To: Yury Norov Date: Wed, 11 Oct 2017 11:48:37 -0700 In-Reply-To: <1507747313.31614.27.camel@edumazet-glaptop3.roam.corp.google.com> References: <20171011183522.tm2xxgzbdspjtsax@yury-thinkpad> <1507747313.31614.27.camel@edumazet-glaptop3.roam.corp.google.com> X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171011_114900_028941_E0A01426 X-CRM114-Status: GOOD ( 11.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Florian Westphal , linux-kernel@vger.kernel.org, Catalin Marinas , "David S. Miller" , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 2017-10-11 at 11:41 -0700, Eric Dumazet wrote: > On Wed, 2017-10-11 at 21:35 +0300, Yury Norov wrote: > > Hi all, > > > > It seems like next-20171009 with ilp32 patches crashes on LTP sendto01 test > > in sys_sendto() path, like this: > > Thanks for the report. > Probably caused by one of my recent patches, so I am taking a look. Yes, this was silly. Please test this fix : Tested-by: Yury Norov diff --git a/include/net/tcp.h b/include/net/tcp.h index 5a95e5886b55e03e4a8bfeac3506c657a4f97dde..15163454174babdcb465904f725b919268dd1bc7 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -1712,6 +1712,7 @@ static inline void tcp_insert_write_queue_before(struct sk_buff *new, static inline void tcp_unlink_write_queue(struct sk_buff *skb, struct sock *sk) { + tcp_skb_tsorted_anchor_cleanup(skb); __skb_unlink(skb, &sk->sk_write_queue); }