| Message ID | 1508170320.6530.15.camel@perches.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Oct 16, 2017 at 09:12:00AM -0700, Joe Perches wrote: > Some of the definitions are very long and can't be split > into multiple lines because ctags is limited. > > Exempt these lines from the line length checks. > > Signed-off-by: Joe Perches <joe@perches.com> It might make sense to point at commit: 25528213fe9f75f4 ("tags: Fix DEFINE_PER_CPU expansions") ... for the gory details, but either way: Acked-by: Mark Rutland <mark.rutland@arm.com> Thanks, Mark. > --- > scripts/checkpatch.pl | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 2a8c6c3c1bdb..5fa0f5467d99 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2900,8 +2900,9 @@ sub process { > $line =~ /^\+\s*#\s*define\s+\w+\s+$String$/) { > $msg_type = ""; > > - # EFI_GUID is another special case > - } elsif ($line =~ /^\+.*\bEFI_GUID\s*\(/) { > + # More special cases > + } elsif ($line =~ /^\+.*\bEFI_GUID\s*\(/ || > + $line =~ /^\+\s*(?:\w+)?\s*DEFINE_PER_CPU/) { > $msg_type = ""; > > # Otherwise set the alternate message types
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2a8c6c3c1bdb..5fa0f5467d99 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2900,8 +2900,9 @@ sub process { $line =~ /^\+\s*#\s*define\s+\w+\s+$String$/) { $msg_type = ""; - # EFI_GUID is another special case - } elsif ($line =~ /^\+.*\bEFI_GUID\s*\(/) { + # More special cases + } elsif ($line =~ /^\+.*\bEFI_GUID\s*\(/ || + $line =~ /^\+\s*(?:\w+)?\s*DEFINE_PER_CPU/) { $msg_type = ""; # Otherwise set the alternate message types
Some of the definitions are very long and can't be split into multiple lines because ctags is limited. Exempt these lines from the line length checks. Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)