Message ID | 1510146472-24069-1-git-send-email-jens.wiklander@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4F0D0603FA for <patchwork-linux-arm@patchwork.kernel.org>; Wed, 8 Nov 2017 13:08:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 407012A5F2 for <patchwork-linux-arm@patchwork.kernel.org>; Wed, 8 Nov 2017 13:08:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 33DEE2A5F4; Wed, 8 Nov 2017 13:08:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 102742A5F2 for <patchwork-linux-arm@patchwork.kernel.org>; Wed, 8 Nov 2017 13:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=co018QWzSTEzoKqFqUoH6RMzmqaU7fCtRKteaIHS2Ac=; b=rqi S607gpu7EYfQS7KVA4ogGnDfw1LzlrdUJP3JYLigOiO65/frOuvDYEtgCbLnQ02h521epAWh3jKgy Z98q9YH2rN0y26j2vMTFfSvKDDWtGVtINOzo7rYfyi5hCnzdSqwc/sIIm/Cs8mgzVPnVQrorAS0Fb z07bovq/h/Zpilv7a+g2SNC5tYaH6QdXQLsS6pbF2L9R6wWHBjTySRSc1kcypv5D3auak3+qliIAl 2XSBQizQIel5XdUTiGNVPBDkJPuhpMqsRwa/vf0HjnLSyAkgSBaGt//MmR92MpmJdFDWeY02BArFi lKF7+hFdCprfI1BpnMFNSEYAvY+gpPA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eCQ5f-0002kM-KQ; Wed, 08 Nov 2017 13:08:23 +0000 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eCQ5b-0002j9-Nc for linux-arm-kernel@lists.infradead.org; Wed, 08 Nov 2017 13:08:21 +0000 Received: by mail-lf0-x241.google.com with SMTP id f125so2984989lff.4 for <linux-arm-kernel@lists.infradead.org>; Wed, 08 Nov 2017 05:07:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=FZytlhCiWNQxMLTnrpb9EMmT+bFlbUHBiKPCADXZ4zc=; b=gbB//MVspeuQdQp6Ufpk7zCrDUlw9c6BWQwhKT1mOHYTLpRUXMRlq2Ac5mY9ZD6riq fxI26bjVIJ1aPw27GvhJWJTtmKX9+mkOrBXDYWk3Ymb4Mv8BGAKSqv3xrvcfzxRFzjnm 0pExk7qLkDjGfqXSVM+nraQ68/R0uQvRwUzIQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FZytlhCiWNQxMLTnrpb9EMmT+bFlbUHBiKPCADXZ4zc=; b=gMLKNE2iC787BbzFyTmHenPORS0EH+VyKUmARBJOsAm1OfpGtUDU2VVl5huGlHygvx P3A+rBnMTnS+cBszI+WdcdxFbIRD4XV5W9mcDKI7QsgF69wZD/8uPGZAgrlJBHUY4cXe q/CszN0JlSI4zeX7y/gcjTFjUbQF0MwQ/fd581ld8vAGA2C8+q1UW3uJAGiwFpFrnOSy BktyoJ+8rTE2b2dnO3O7rT4izvxfNSjYDIOZMcb9kYtApAHUVGKLPf3eBgoG6lTXtD5w 6xT3x6bZSphFt7oHcmLknfwlISXA0ELqak6j8e1Yb7vlOZzuXZ029nsY4W9is0Z/zPom yhog== X-Gm-Message-State: AJaThX6L1v+e4lkWPScMXrCni7+lEj9ZeCA9hwNcSxhS5rCn2WdicE+q 1IxIZuUyRotdCt6/DgpJ95IH3A== X-Google-Smtp-Source: ABhQp+RZ+8xJ5i+jXrEGLBU1wBeiuOeUt6EzwIgaMNSjggSD71PfrOQx70xJUJqFjNv/dQAdLb5oTg== X-Received: by 10.46.22.88 with SMTP id 24mr233850ljw.20.1510146477448; Wed, 08 Nov 2017 05:07:57 -0800 (PST) Received: from jax.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id 77sm782706ljj.12.2017.11.08.05.07.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 08 Nov 2017 05:07:56 -0800 (PST) From: Jens Wiklander <jens.wiklander@linaro.org> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tee-dev@lists.linaro.org Subject: [PATCH] optee: fix invalid of_node_put() in optee_driver_init() Date: Wed, 8 Nov 2017 14:07:52 +0100 Message-Id: <1510146472-24069-1-git-send-email-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171108_050819_965837_3025EDB7 X-CRM114-Status: GOOD ( 10.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: Jens Wiklander <jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index 58169e519422..18c8c0a50d37 100644 --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -589,7 +589,6 @@ static int __init optee_driver_init(void) return -ENODEV; np = of_find_matching_node(fw_np, optee_match); - of_node_put(fw_np); if (!np) return -ENODEV;
The first node supplied to of_find_matching_node() has its reference counter decreased as part of call to that function. In optee_driver_init() after calling of_find_matching_node() it's invalid to call of_node_put() on the supplied node again. So remove the invalid call to of_node_put(). Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> --- drivers/tee/optee/core.c | 1 - 1 file changed, 1 deletion(-)