From patchwork Sat Nov 18 06:36:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10064397 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5DD7D60230 for ; Sat, 18 Nov 2017 06:38:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4FE8E2AEED for ; Sat, 18 Nov 2017 06:38:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 44CF82AF0C; Sat, 18 Nov 2017 06:38:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4435C2AEED for ; Sat, 18 Nov 2017 06:38:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=KhyW2CuvAVQvivAW73IGHgaG0/JV/1rcmfquU8vRKRQ=; b=Z1SrfWgOGhIgl7yLK34xAAct7V FQCEiIcxADRzFVIslPfw8CUrVt6mFru9kq+W4JJiteu4/8Iq8O/K1JTruXC5krUy+W1SaZ7m35daG 8vXimmYbwzQdxxOWCPN1ZWCS8X692MLMwr21vf0CJ5nB1VNXk/wU/G/UAWEUdN+/r3+wONGmr8ych BNsdb166qzSI2kEUeWF6hiOVcQds6G/iGtVsyJv4G5FIiP8nHPokyIeuvgjZCvvSZEEiYvO+cw9kn XG7MgJsIZIY5gpw3P7v1tJyGJ17QDuTcyHIH4tupYumFAFRCCy7ZbANLrnrJcc94ltFmsdR1oOS0U cRyWbLOw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eFwlX-0005Uh-C7; Sat, 18 Nov 2017 06:38:11 +0000 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eFwkd-0004dS-Ht for linux-arm-kernel@lists.infradead.org; Sat, 18 Nov 2017 06:37:18 +0000 Received: by mail-pf0-x243.google.com with SMTP id r62so3541826pfd.5 for ; Fri, 17 Nov 2017 22:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fyYZ7TBQQV4xRv8XxgRyZWDdTh6Uv01vHEKR7kquaCc=; b=P3RTeEuRtng7rIcnqebAng1Vp9uxg0Ohz8/VsXBO3xOHkgeYGPK1ijuR35mrOBxkc1 oqzxxqF6mi2IPja5zCMlDoNOuKE3xIAfEetSmZp6QB+s+h2G2v+P+Dcv/e2n4aISR3f8 HDLvDMF4/KlZBavW/KUxrFLLiWNH2q8QiM2T30uZqguGeDKhnDAo5RCgJsb82WkJAzKo uMqENJ7Hp8aHRIZXOju3hn1zYzWUSm+2DkzW4Tvqxb90MOAoMEgjmLFdqUC7mCBygRxl 5Z6Jdv2smeL1YiZ0WbD187XMEwXNruLbJA+W1tlauOSfs0B14nFB6OdlCXh2PDK2p2BM rLhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fyYZ7TBQQV4xRv8XxgRyZWDdTh6Uv01vHEKR7kquaCc=; b=T+b+2P4HU59AIWs2n+GnMLlEWkfJNaeC+swyeMQXQmZTmLlzjLAdnvAJVvWsRb3A4U WqI266WyrkIppIfaERYHJ0wFMPiftEihhHwH+MRmsAkAO01yUhEK9yqIrZadFU9mCyG4 i2hyTBaDDbbvMWebRVkA45KHjr5aDUT7xL2IQbGqJ+xChpzQoARtF5bhluJleh30MfO1 3NiryisW2SwxEexcmo4/mK68sw9I4ZMs4defPTRiECogQ6DuTMWSarxBHgyzBcHPWkgf 3UEERY2EgO4RdouzjGQ4nHqgg3SK1KMQv8Pf7PETEVjB5FTqIHi8YEHSYHv/O1lh0vr2 MCBQ== X-Gm-Message-State: AJaThX5D7vENdJVSiq4rFcRmfznD9C5MfdPY7mPdKaSRyrcUG++MhEkM bv1T3b7eVPuqJc+KEXK2bao= X-Google-Smtp-Source: AGs4zMYpS5a1iBKlqtpJC8q64awYRpuDhstZZT0WP3el1F0Ra0N0urfo22XljxK2FTbm/J5ZwZNznQ== X-Received: by 10.159.229.136 with SMTP id az8mr7458777plb.133.1510987014566; Fri, 17 Nov 2017 22:36:54 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id d68sm9905504pfl.38.2017.11.17.22.36.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Nov 2017 22:36:54 -0800 (PST) From: Arvind Yadav To: lee.jones@linaro.org, maxime.ripard@free-electrons.com, wens@csie.org Subject: [PATCH 3/3] mfd: sun4i-gpadc: Handle return value of platform_get_irq Date: Sat, 18 Nov 2017 12:06:33 +0530 Message-Id: <1510986993-4936-4-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510986993-4936-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1510986993-4936-1-git-send-email-arvind.yadav.cs@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171117_223715_801846_3947AFC3 X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/mfd/sun4i-gpadc.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/sun4i-gpadc.c b/drivers/mfd/sun4i-gpadc.c index 9cfc881..1c89235 100644 --- a/drivers/mfd/sun4i-gpadc.c +++ b/drivers/mfd/sun4i-gpadc.c @@ -100,8 +100,8 @@ static int sun4i_gpadc_probe(struct platform_device *pdev) struct resource *mem; const struct of_device_id *of_id; const struct mfd_cell *cells; - unsigned int irq, size; - int ret; + unsigned int size; + int ret, irq; of_id = of_match_node(sun4i_gpadc_of_match, pdev->dev.of_node); if (!of_id) @@ -148,6 +148,9 @@ static int sun4i_gpadc_probe(struct platform_device *pdev) regmap_write(dev->regmap, SUN4I_GPADC_INT_FIFOC, 0); irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + ret = devm_regmap_add_irq_chip(&pdev->dev, dev->regmap, irq, IRQF_ONESHOT, 0, &sun4i_gpadc_regmap_irq_chip,