| Message ID | 1512338693-16781-1-git-send-email-david@lechnology.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday 04 December 2017 03:34 AM, David Lechner wrote: > This fixes the battery voltage monitoring gpio-hog settings. > > When the gpio is low, it turns off the battery voltage to the ADC chip. > However, this needs to be on all of the time so that we can monitor > battery voltage. > > Also, there was a typo that prevented pinmuxing from working correctly. > > Signed-off-by: David Lechner <david@lechnology.com> Applied to fixes with subject line changed to: ARM: dts: da850-lego-ev3: Fix battery voltage gpio Please follow this style for future patches. Thanks, Sekhar
On 12/07/2017 01:35 AM, Sekhar Nori wrote: > On Monday 04 December 2017 03:34 AM, David Lechner wrote: >> This fixes the battery voltage monitoring gpio-hog settings. >> >> When the gpio is low, it turns off the battery voltage to the ADC chip. >> However, this needs to be on all of the time so that we can monitor >> battery voltage. >> >> Also, there was a typo that prevented pinmuxing from working correctly. >> >> Signed-off-by: David Lechner <david@lechnology.com> > > Applied to fixes with subject line changed to: > > ARM: dts: da850-lego-ev3: Fix battery voltage gpio > > Please follow this style for future patches. Ack
diff --git a/arch/arm/boot/dts/da850-lego-ev3.dts b/arch/arm/boot/dts/da850-lego-ev3.dts index 413dbd5..81942ae 100644 --- a/arch/arm/boot/dts/da850-lego-ev3.dts +++ b/arch/arm/boot/dts/da850-lego-ev3.dts @@ -178,7 +178,7 @@ */ battery { pinctrl-names = "default"; - pintctrl-0 = <&battery_pins>; + pinctrl-0 = <&battery_pins>; compatible = "lego,ev3-battery"; io-channels = <&adc 4>, <&adc 3>; io-channel-names = "voltage", "current"; @@ -392,7 +392,7 @@ batt_volt_en { gpio-hog; gpios = <6 GPIO_ACTIVE_HIGH>; - output-low; + output-high; }; };
This fixes the battery voltage monitoring gpio-hog settings. When the gpio is low, it turns off the battery voltage to the ADC chip. However, this needs to be on all of the time so that we can monitor battery voltage. Also, there was a typo that prevented pinmuxing from working correctly. Signed-off-by: David Lechner <david@lechnology.com> --- v3 changes: * Rebased patch so that it applies cleanly to mainline v2 changes: * Fixed pinctrl typo arch/arm/boot/dts/da850-lego-ev3.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)