From patchwork Thu Dec 28 02:40:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 10134357 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 349286037D for ; Thu, 28 Dec 2017 02:35:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 253A42CA7C for ; Thu, 28 Dec 2017 02:35:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 183652CA82; Thu, 28 Dec 2017 02:35:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9D94F2CA7C for ; Thu, 28 Dec 2017 02:35:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=JqFSl6AhCmD3vQRFM5QvpvIqFacuugPsokt/jTHcLFI=; b=MNn7O91SksloHm Axfqj/K87hQ6CF93nNrbbTeCYwJEa0BdXhD9JgDCL012ImKDKJ+NgatVq7SrkfyWUvI3KgPLrTmnr /R81BEb2LNG96ySiTriEJDq2XiGyz5+zmY4EJVxuKH/sw0ClWp99b7HUReQsermAKZUTbQ0pgcsLX Q3nUNh/cr9z3UhLbtKI9Wi+wsUhWb6VwgwuDY3/IfPHY2VJlkloopV4g/5r1YL2Hv5ZkiU9O9uNYw V9YV0GfnmvYLGi+X3M7G0het0GaQO321EWFyPAWCQmptWqsdIeRKMJebpG1ZOZpKoADc2anUUlbPC Bf0hxPApkEx7rtq/GJRw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eUO2q-0001JP-Fr; Thu, 28 Dec 2017 02:35:44 +0000 Received: from [45.249.212.32] (helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eUO2P-0008W1-Pi; Thu, 28 Dec 2017 02:35:19 +0000 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 93535B32DB377; Thu, 28 Dec 2017 10:34:45 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.361.1; Thu, 28 Dec 2017 10:34:37 +0800 From: Wei Yongjun To: Neil Armstrong , Jerome Brunet , Michael Turquette , "Stephen Boyd" , Carlo Caione , Kevin Hilman , Qiufang Dai Subject: [PATCH -next] clk: meson-axg: fix return value check in axg_clkc_probe() Date: Thu, 28 Dec 2017 02:40:49 +0000 Message-ID: <1514428849-61681-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171227_183518_057072_07313245 X-CRM114-Status: UNSURE ( 6.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, Wei Yongjun , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP In case of error, the function devm_ioremap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 78b4af312f91 ("clk: meson-axg: add clock controller drivers") Signed-off-by: Wei Yongjun --- drivers/clk/meson/axg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index a66b3a5..717c02d 100644 --- a/drivers/clk/meson/axg.c +++ b/drivers/clk/meson/axg.c @@ -880,7 +880,7 @@ static int axg_clkc_probe(struct platform_device *pdev) /* Generic clocks and PLLs */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); clk_base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); - if (IS_ERR(clk_base)) { + if (!clk_base) { dev_err(&pdev->dev, "Unable to map clk base\n"); return -ENXIO; }