From patchwork Mon Jan 1 19:43:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 10139543 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 63613601A1 for ; Mon, 1 Jan 2018 19:51:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5310A28700 for ; Mon, 1 Jan 2018 19:51:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 451E528705; Mon, 1 Jan 2018 19:51:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7E2C028700 for ; Mon, 1 Jan 2018 19:51:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=UiUi5gkHVHZYqmL4H/TqcterZ6jcXOqoiRNaj2sRQDE=; b=jZSU39ZjYCJgSFABMfF1c8TNDp TSLVFpD0lZUWQ8dYtMNmMGbMlSN3n2wmGRZ44IgEVEsyJx6gItDG6Lt5EZ9drs2KWzep4iybRGNHf mDaI1rmPyk5OMcLNzexFI39rboK2H37q1KyJlzH4BrbQHhqCcpJQXce360lF83JCrFoXRLUSJWULt PzcfovlVHClz+ApHVJIYeIvczv4ZRLVoE0myFzN+eTIgXiWStSur3b/w/IPTAaHh+6i1hF++r6Spe GMp5TGGOv67JlKlBljDJD19LMdiGBqwtSAe1ykuDJ5VulN4PnHtRrh+qu/LczUZgXBrc1Gz8O7eCj HWyOdU8w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eW67U-0000ek-3Q; Mon, 01 Jan 2018 19:51:36 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eW67S-0000QY-4Q for linux-arm-kernel@bombadil.infradead.org; Mon, 01 Jan 2018 19:51:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dR18/oejCALiWSgbOvjO7r98++P30n5JOrS/EjAfWjE=; b=svQg/eAgRj7Td9Q1ISYaHLxr+ JRCx0LswWi3UZ/vn2g1YSD9M3m2qf85ljBXXpUGlRnUY0Ee/h3R8o8sqn6DDOLkw5I12j4vMbXtmi kwpfY2ksEFpL4PWkCVpVWRkeM6mJE1kfcgGvuQ0/CfcO22nRt4/DL9ZWuu5VX6WLgs8PnVf8cwbk5 a0fAtklaJc3Q8Tif43KpE2gTDuP5jU/BUNOUyrrZ9Sl6aH3qcaZk+QbulPFXT5MeAM0Pz7B1ZhjQ0 DrdsqZo/uiTH2B7eTDuLteMWAfbZBo/5TDrRE+aTKT/6OCVKHIJeWT+4WpyL+4vl4/ouqBU4ojdjU SXQbZYMxA==; Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]) by casper.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eW607-0005Eb-Ve for linux-arm-kernel@lists.infradead.org; Mon, 01 Jan 2018 19:44:01 +0000 Received: by mail-wm0-x243.google.com with SMTP id i11so57918430wmf.4 for ; Mon, 01 Jan 2018 11:43:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dR18/oejCALiWSgbOvjO7r98++P30n5JOrS/EjAfWjE=; b=idLel1MAwQuGEaHCmFqwygQyot7Vxes1yQiDUsGXLWgu9e4QJ68pRpOfQY0UjYz6to yy55tr73HPrW9HfnDgvKfp/87TYECDqVUceXyvHkDHnOD8L6Q9JysHowVXOfWITB0b4O w5qBzN+D/4IQA3KGIEEu8nkTUESt3z7lFFmp2CYWv3+2F69iuIZGI91K7vUgyfsrlP9H 1JLi84bX9bAt9OEheNXy0JqUjRHCkInHlNoOOevht4DBAZ8qv7+TAQG1ckPPEdQ/9v9w 3yTazvkdCvXu4FpZ5oRSI6DypRYLt38pJOYXthjfpZCrne8vK6Oi9U5ofPAyx6x7F69v 51FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dR18/oejCALiWSgbOvjO7r98++P30n5JOrS/EjAfWjE=; b=QRu6v2e07OmjhRWSNn5wCm0SfcXREnyMnc2zXfee+RHatjnuKsK3u9C0gCGzW16S25 jpRzN/JZl0aNL2x7d1UQTVkex/Isyo+u/Qpb8ATlcKsaMHZ34Bt3TANQ/TWMM9v10Cdg 2sU6fyLqllPxJxhMca2KDVi3vLNJ+TnzSfIxmv4pN55qES1DZkgZKfMrtKShZA5IGR0G rx0pa/6YnbidVtBYM97PvbgzdvAACJEcOHfNHNRFWtq62WjvdAc6tyw0HDt0GLfInPEQ Q5UbvoGT1mdY+VR9aDyT4Y/5P8+oWxAN4AZ+ssqx34Xfz3vj9+snY3Elelps78V1HMK6 2ajg== X-Gm-Message-State: AKGB3mLgrBBNaDwws7oD1AibfDPE5C05oQTGCdvWbFWsdr+mq5C0Jpvd vaT1NLOn7wvCEjDThrKnBdqb3A== X-Google-Smtp-Source: ACJfBov8+5gCRsDKlj2PxLpKQCii1TRG3RQHU21Ie5XRXZzHgdWuLEs8hIE3k4NWM/LO2rmxS43v5A== X-Received: by 10.80.204.7 with SMTP id m7mr58081196edi.73.1514835828191; Mon, 01 Jan 2018 11:43:48 -0800 (PST) Received: from localhost.localdomain (D4CCACC7.cm-2.dynamic.ziggo.nl. [212.204.172.199]) by smtp.gmail.com with ESMTPSA id w2sm39361075edb.4.2018.01.01.11.43.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 01 Jan 2018 11:43:47 -0800 (PST) From: Bryan O'Donoghue To: mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: [PATCH v3 33/34] clk: lpc32xx: change round_rate() return logic Date: Mon, 1 Jan 2018 19:43:12 +0000 Message-Id: <1514835793-1104-34-git-send-email-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514835793-1104-1-git-send-email-pure.logic@nexus-software.ie> References: <1514835793-1104-1-git-send-email-pure.logic@nexus-software.ie> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180101_194400_012213_02F76C4F X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bryan O'Donoghue , Sylvain Lemieux , Gabriel Fernandez , linux-arm-kernel@lists.infradead.org, Vladimir Zapolskiy MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch updates the round_rate() logic here to return zero instead of a negative number on error. In conjunction with higher-level changes associated with acting on the return value of clk_ops->round_rate() it is then possible to have clk_ops->round_rate() return values from 1 Hz to ULONG_MAX Hz instead of the current limitation of 1 Hz to LONG_MAX Hz. Signed-off-by: Bryan O'Donoghue Cc: Michael Turquette Cc: Stephen Boyd Cc: Vladimir Zapolskiy Cc: Sylvain Lemieux Cc: Gabriel Fernandez Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/clk/nxp/clk-lpc32xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c index 76c17f4..0e0d258 100644 --- a/drivers/clk/nxp/clk-lpc32xx.c +++ b/drivers/clk/nxp/clk-lpc32xx.c @@ -664,17 +664,17 @@ static unsigned long clk_usb_pll_round_rate(struct clk_hw *hw, * USB divider, USB PLL N and M parameters. */ if (rate != 48000000) - return -EINVAL; + return 0; /* USB divider clock */ usb_div_hw = clk_hw_get_parent_by_index(hw, 0); if (!usb_div_hw) - return -EINVAL; + return 0; /* Main oscillator clock */ osc_hw = clk_hw_get_parent_by_index(usb_div_hw, 0); if (!osc_hw) - return -EINVAL; + return 0; o = clk_hw_get_rate(osc_hw); /* must be in range 1..20 MHz */ /* Check if valid USB divider and USB PLL parameters exists */ @@ -697,7 +697,7 @@ static unsigned long clk_usb_pll_round_rate(struct clk_hw *hw, } } - return -EINVAL; + return 0; } #define LPC32XX_DEFINE_PLL_OPS(_name, _rc, _sr, _rr) \