diff mbox

arm: dts: sun7i: include correct ccu clock header

Message ID 1517427086-66480-1-git-send-email-giulio.benetti@micronovasrl.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Giulio Benetti Jan. 31, 2018, 7:31 p.m. UTC
Include correct clock header sun7i-a20-ccu.h
instead of sun4i-a20-ccu.h.

Including sun4i header instead of sun7i
prevents using sun7i specific defines.

Substitute header inclusion in sun7i-a20.dtsi
using right one.

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 arch/arm/boot/dts/sun7i-a20.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maxime Ripard Feb. 1, 2018, 3:19 p.m. UTC | #1
Hi,

On Wed, Jan 31, 2018 at 08:31:26PM +0100, Giulio Benetti wrote:
> Include correct clock header sun7i-a20-ccu.h
> instead of sun4i-a20-ccu.h.

You should wrap at 72 characters.

> Including sun4i header instead of sun7i
> prevents using sun7i specific defines.
> 
> Substitute header inclusion in sun7i-a20.dtsi
> using right one.

This sentence is redundant with the first one.

Dropped the first one, corrected the wrapping and applied, thanks

Maxime
Giulio Benetti Feb. 1, 2018, 3:37 p.m. UTC | #2
Il 01/02/2018 16:19, Maxime Ripard ha scritto:
> Hi,
> 
> On Wed, Jan 31, 2018 at 08:31:26PM +0100, Giulio Benetti wrote:
>> Include correct clock header sun7i-a20-ccu.h
>> instead of sun4i-a20-ccu.h.
> 
> You should wrap at 72 characters.

Ok, keep in mind for next patches. Thanks

> 
>> Including sun4i header instead of sun7i
>> prevents using sun7i specific defines.
>>
>> Substitute header inclusion in sun7i-a20.dtsi
>> using right one.
> 
> This sentence is redundant with the first one.

Yes, you're right. Thanks

> 
> Dropped the first one, corrected the wrapping and applied, thanks
> 
> Maxime
>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 1aa05a0..d0865d2 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -47,7 +47,7 @@ 
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/thermal/thermal.h>
 #include <dt-bindings/dma/sun4i-a10.h>
-#include <dt-bindings/clock/sun4i-a10-ccu.h>
+#include <dt-bindings/clock/sun7i-a20-ccu.h>
 #include <dt-bindings/reset/sun4i-a10-ccu.h>
 
 / {