From patchwork Wed Mar 14 03:19:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10281385 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1BF61602BD for ; Wed, 14 Mar 2018 03:21:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0D8E02866C for ; Wed, 14 Mar 2018 03:21:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F3F7D2866F; Wed, 14 Mar 2018 03:21:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 785F02866C for ; Wed, 14 Mar 2018 03:21:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5TujYKea8PRnJZUV7CexqALPA4lUW2Pm8khz8W/WRsc=; b=Wc/lQiU+zZXZJP 8gFNrfuk5QQA8tLTarPki/yEj28I5XJ+qZh6fpyeWW5hZRLyg+FpakNeAspFx+Ea/HefU4AUhlN97 3RbjPMwWe9D2MZVxWQhwFbicXjU2HWMhxjsGRAGYJZVS6+tm0i5cGCrVSyQMtKbOkOJMNWlByIHuL pkO+4Mll/FDA+j5M9BiqyDXYl9HnOukXGgOGOWjl9tNbUFiAfrN1hbGqU7C430SIporY5uvQTM7B4 Ck52j36U1EdBHIOBCem5z0cajl6hBUZRnKzkg2JL+ys9PXv/FL+m/GZOtHXODjNQnHLuelaEQKvxt 9uFjOeIdyMYz6XdiFdag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1evwyR-0004Ds-De; Wed, 14 Mar 2018 03:21:07 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1evwxz-0003rJ-5B for linux-arm-kernel@lists.infradead.org; Wed, 14 Mar 2018 03:20:40 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8DF4160592; Wed, 14 Mar 2018 03:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1520997626; bh=zqEDc5+sVTJuqPfrwG2GU85GD5muqnwKbTmbuxIGE+Y=; h=From:To:Cc:Subject:Date:From; b=TyXJkc4I5aoRij0Nb3C/JSlUyosT2a9HqlNgcgINoK61ZJQcWO4QOOihRdAfGgGy6 92BSUp8zEsSYTjBCXzWrcWyll6naF/wn8/pKT+IHKjYIyLB0ZwLnIMsyMhXeIx+/1x vNgUNuceOctQCd0HOOa7om/ZwukClj2SSdeBol34= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D503560592; Wed, 14 Mar 2018 03:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1520997626; bh=zqEDc5+sVTJuqPfrwG2GU85GD5muqnwKbTmbuxIGE+Y=; h=From:To:Cc:Subject:Date:From; b=TyXJkc4I5aoRij0Nb3C/JSlUyosT2a9HqlNgcgINoK61ZJQcWO4QOOihRdAfGgGy6 92BSUp8zEsSYTjBCXzWrcWyll6naF/wn8/pKT+IHKjYIyLB0ZwLnIMsyMhXeIx+/1x vNgUNuceOctQCd0HOOa7om/ZwukClj2SSdeBol34= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D503560592 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH 1/7] i40e/i40evf: Eliminate duplicate barriers on weakly-ordered archs Date: Tue, 13 Mar 2018 23:19:52 -0400 Message-Id: <1520997599-17298-1-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180313_202039_277641_9A4A7646 X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya , intel-wired-lan@lists.osuosl.org, Jeff Kirsher , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +- drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c index e554aa6cf..7028516 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c @@ -1375,7 +1375,7 @@ static inline void i40e_release_rx_desc(struct i40e_ring *rx_ring, u32 val) * such as IA-64). */ wmb(); - writel(val, rx_ring->tail); + writel_relaxed(val, rx_ring->tail); } /** diff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c index 357d605..2d323fc 100644 --- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c +++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c @@ -667,7 +667,7 @@ static inline void i40e_release_rx_desc(struct i40e_ring *rx_ring, u32 val) * such as IA-64). */ wmb(); - writel(val, rx_ring->tail); + writel_relaxed(val, rx_ring->tail); } /**